by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jun 24 21:06
    GitLab | Greg Slepak pushed 4 commits to Group Income - Simple
  • Jun 11 19:05
    GitLab | Greg Slepak pushed 5 commits to Group Income - Simple
  • May 11 19:00
    GitLab | Greg Slepak pushed 1 commits to Group Income - Simple
  • May 10 22:02
    GitLab | Greg Slepak pushed 1 commits to Group Income - Simple
  • May 09 20:33
    GitLab | Greg Slepak pushed 2 commits to Group Income - Simple
  • May 08 02:05
    GitLab | Greg Slepak pushed 1 commits to Group Income - Simple
  • May 07 19:17
    GitLab | Greg Slepak pushed 1 commits to Group Income - Simple
  • May 07 01:42
    GitLab | Greg Slepak pushed 2 commits to Group Income - Simple
  • May 02 11:45
    GitLab | Sandrina Pereira pushed 12 commits to Group Income - Simple
  • May 01 19:44
    GitLab | Greg Slepak pushed 6 commits to Group Income - Simple
  • Apr 14 21:07
    GitLab | Greg Slepak pushed 1 commits to Group Income - Simple
  • Apr 11 20:11
    GitLab | Greg Slepak pushed 1 commits to Group Income - Simple
  • Apr 07 00:43
    GitLab | Greg Slepak pushed 3 commits to Group Income - Simple
  • Apr 03 02:10
    GitLab | Greg Slepak pushed 1 commits to Group Income - Simple
  • Apr 03 00:44
    GitLab | Greg Slepak pushed 1 commits to Group Income - Simple
  • Apr 03 00:20
    GitLab | Greg Slepak pushed 1 commits to Group Income - Simple
  • Mar 29 21:57
    GitLab | Greg Slepak pushed 1 commits to Group Income - Simple
  • Mar 29 00:46
    GitLab | Greg Slepak pushed 1 commits to Group Income - Simple
  • Mar 23 21:35
    GitLab | Greg Slepak pushed 2 commits to Group Income - Simple
  • Mar 14 17:41
    GitLab | Greg Slepak pushed 1 commits to Group Income - Simple
slack-relay
@slack-relay
<Sandrina> Good luck with your stuff Pierre! ๐Ÿคž
slack-relay
@slack-relay
<Margarida> Sorry about that @Pierre, hope you can solve whatever is happening โค๏ธ
slack-relay
@slack-relay
<Pierre> Thanks for your understandingโ€ฆ
slack-relay
@slack-relay
<greg> No worries @Pierre! Thank you very much for letting us know, and best of luck ๐Ÿ€ with whatever it is!
slack-relay
@slack-relay
<catarina_chavinha> Hope it isnโ€™t anything too serious @Pierre, weโ€™ll talk and see you soon ๐Ÿคž
<greg> i'll be running about a minute late or so.... see you guys soon!
slack-relay
@slack-relay
<greg> Summary of Chat:
  • Greg: Merge Payments PR early in the week!! + Posting job listing (@andrea) + PR/Figma/Blog reviews
  • Margarida: More chat stuff + PR reviews
  • Sandrina: Continuing payments + PR reviews
  • Catarina: Second draft of the blog post following feedback
  • Pierre: Life ๐Ÿ˜„ + Finish implementing 404/500 error pages + Pick and open issue + PR reviews
slack-relay
@slack-relay
<greg> @channel $1000 up for grabs: https://twitter.com/taoeffect/status/1280194895831904259
<greg> https://twitter.com/taoeffect/status/1280194895831904259 *new tweet (no edit on twitter yet!)
slack-relay
@slack-relay
<Margarida> Just shared it with the members of Factory Berlin (the co-work space / community I usually go to in Berlin) and there are some people who seem very interested! You should receive some applications soon :)
<greg> Awesome! thanks @Margarida! ๐Ÿ˜„
slack-relay
@slack-relay
<greg> @Sandrina wow just saw that you pushed some changes
<greg> didn't think you'd be up this late. one thing i'm wondering is if you can get the tests to pass
<greg> might be too late to do that tonight
<greg> cause i can't merge anything unless they're passing
slack-relay
@slack-relay
<Sandrina> it's exactly that that I'm fixing ๐Ÿ™‚ i didn't realize yesterday that the tests failed
<Sandrina> and yes, it's late... but my schedules are very flexible, especially nowadays that I can't work during the day because it's just too hooot ๐Ÿฅต
slack-relay
@slack-relay
<Sandrina> done, @greg. tests are green โœ…
<greg> awesome!! thanks for the update! gonna check out the latest changes ๐Ÿ™‚
slack-relay
@slack-relay

<greg> Alright @Sandrina, since on the call we noted that the Payments would be merged either monday/today, I went ahead and merged it after not seeing anything super critical, although I might have missed something! okTurtles/group-income-simple#918

You are now unblocked to finish polishing that PR and implementing the rest of the TODOs in a new PR!

<greg> @Pierre I think you didn't get a chance to review that PR? You can still do it, please feel free to leave any feedback on things you notice even though it was merged. Sandrina can then fix them in a followup!
<Pierre> ok, will do
slack-relay
@slack-relay
<Sandrina> Today I spent a good amount of time testing the payments and found quite a few scenarios with unexpected outcomes related to income/payments distribution... I described some of them here: https://github.com/okTurtles/group-income-simple/issues/763#issuecomment-656250338.
I don't consider all of them exactly a "code bug", but more of "UX/userflow flaws". So, @Margarida your feedback would also be welcome here.
<greg> @Sandrina excellent research! ๐Ÿ‘
<greg> i didn't fully read the post yet but i skimmed it and was impressed by its thoroughness
<greg> will be also diving deeper into that later today
<greg> am also curious to hear Margarida's thoughts
<Sandrina> I'm not done yet relating each scenario. I'll add more info later today, but it's already a good chunk of problems.
<greg> cool, looking forward to it ๐Ÿ‘
slack-relay
@slack-relay
<Margarida> If Iโ€™m getting this right, the problem is that whenever someone new adds their income details or someone changes their income details, the distribution is re-calculated but payments already sent in that month are not accounted for, right?
<Margarida> @Sandrina
<Sandrina> Yes @Margarida, that's part of the problem in the first chunk of scenarios.
<Margarida> ok, Iโ€™ll read the rest and leave a comment ๐Ÿ™‚
slack-relay
@slack-relay
<Margarida> @Sandrina Iโ€™m a bit confusedโ€ฆ do you mind jumping on a quick call so we can chat a bit about this? I think itโ€™ll be faster
slack-relay
@slack-relay
<Sandrina> Yes we can do one. Iโ€™ll send you a PM to schedule it
slack-relay
@slack-relay
<Sandrina> Meanwhile, I also opened a small PR, ready to review, with some improvements to payments.
okTurtles/group-income-simple#951
@greg, from the current TODO list in #763, is there anything in particular you want me to work on?
slack-relay
@slack-relay
<greg> @Sandrina /me looks
<greg> @Sandrina wait, you closed 763, but not all the checkboxes have been checked
<greg> so why did you close the issue?
<Sandrina> did i? my mistake! reopened! probably clicked on the wrong button when I was posting an answer
<greg> ah thanks ๐Ÿ™‚
<greg> @Sandrina so i just got back from my run (today i've had a late start), and a great answer to your question will need to wait until i've settled into work mode. however, a quick off-the-cuff answer is: anything that needs doing, and hasn't been done, feel free to do it in the order you feel like doing. Hope that's helpful? If not, let me know exactly what I can do to help (and i'll help as soon as I'm ready!)
slack-relay
@slack-relay
<Sandrina> It's just that everything that is missing doesn't seem "quick/easy" to do taking in account I won't have much time available to work on GI after this week. So, I focused only on the the small semi-tasks
<greg> so you're asking what's the highest priority?

<greg> I would say everything having to do with basic payment dynamics, e.g.:

  • cancelling payment workflow (after you've sent one accidentally or made a mistake in recording it; might need to coordinate with @Margarida on that)
  • pagination
  • full partial payments support

Meanwhile, everything more complicated or not super critical, e.g. archiving of payments for future retrieval, can be de-prioritized and done later

<greg> aim for getting the core payments functionality fully working
<Sandrina> ok. I'll see what I can do ๐Ÿ™‚
<greg> awesome ๐Ÿ™‚ ๐Ÿ‘
slack-relay
@slack-relay
<greg> @Sandrina I wasn't feeling well enough today to tackle all of the scenarios that you wrote about, will attempt again tomorrow!