<Margarida> Another thing… I would love to get to know our users a bit better. It would be great if we could send an email to everyone that entered their email at http://groupincome.org and ask them something like “What do you plan on using groupincome for? Tell us your story!”
<Margarida> This way we can get some more realistic scenarios and do some thought exercises on whether or not what we are doing will help!
<greg> @Sandrina came up with a really great idea here to improve our Cypress tests. Very impressive! https://github.com/okTurtles/group-income-simple/issues/799#issuecomment-573301251
<greg> @Pierre posted a review based on some tests I ran! https://github.com/okTurtles/group-income-simple/pull/789#pullrequestreview-341632605
will continue reviewing based on the code next
will continue reviewing based on the code next
<Pierre> Ok. I will fix that today
<greg> Summary of Chat:
- Greg: edit issue #651 & getting back to Sandrina on what to work on next + finishing PR reviews + blog post if time available
- Margarida: reviewing PRs + responding to Figma feedback + and working on Payments design
- Sandrina: improving speed of Cypress tests + something else if time available
- Pierre: finishing dashboard PR
<Margarida> Replied to @Sandrina’s comment on @Pierre’s PR! https://github.com/okTurtles/group-income-simple/pull/789#discussion_r365950977
<Sebin> @greg Sorry for the late response to your comment here(https://okturtles.slack.com/archives/C0EH7P20Y/p1578525505001000)! I just pushed some commits to the PR that resolve the merge conflicts and also fix all the change requests brought up there.
<Sebin> Hi @Margarida , Have you read this comment here(https://github.com/okTurtles/group-income-simple/pull/765#issuecomment-562731411)? 🙂
<greg> (and hopefully merging it this week!)
<Sandrina> I’ll take a look tomorrow @greg, if it’s okay for me, can I merge it?
<greg> @Sandrina yep!
<greg> (since that's the name of the component in the PR)
<greg> @Sebin finished my review! https://github.com/okTurtles/group-income-simple/pull/765#pullrequestreview-342844713
<greg> @Pierre done! https://github.com/okTurtles/group-income-simple/pull/789#pullrequestreview-342936299
(Still more to come but this way I get you feedback early so you don't have to wait)
(Still more to come but this way I get you feedback early so you don't have to wait)
<greg> The labels work great now :smile: :+1:: https://files.slack.com/files-pri/T02K87MKW-FSNMC8CBA/download/screen_shot_2020-01-14_at_5.05.48_pm.png
<greg> @Pierre code review done! note that i skipped reviewing the graph code and am trusting you on that because reviewing that will hold me up from moving on to other items, and as long as it works I trust you! 🙂 https://github.com/okTurtles/group-income-simple/pull/789#pullrequestreview-342954250
<greg> oh i just realized I missed some i18n stuff. just added a few more comments about that
<greg> @Sandrina as far as getting back to you on what to work on next (one of my tasks for this week), I think I've done that by giving the go-ahead for the Cypress test speedup. There is also this issue I created for fixing an invite link bug: okTurtles/group-income-simple#800
<Sandrina> so an update on my side @greg , I spent these days working on cypress to bypass UI and some weird bugs related to identityContract happened. Basically after login/groupCreation, the
state[identityContractID] is empty, but state.loggedIn.identityContractID exists. In other words, the contract itself is gone. If I refresh the page everything works fine again. I think it has something to do with async stuff not getting fully completed. Does this popup anything to your mind that might be useful for me to debug?
<Sandrina> Thanks greg, I’ll take a look at it and let u know if I do any progress
<greg> @Sandrina cool. Oh, right, it’s the relationship between main.js and the stuff in Cypress which checks the attributes it sets. We have code in the Cypress command for logging in that waits for the contracts to finish syncing
<greg> @Sandrina updated issue 651: https://github.com/okTurtles/group-income-simple/issues/651#issuecomment-575361625
<greg> well, i'm somewhat surprised with the amount of progress I managed to get done this week. I make not promises about the Margarida/Pierre blog post, but it seems like I might finally be able to start on it!
<greg> alternatively (to the blog post) I could work on sysadmin stuff. There are some things I'd like to do:
- converting the site from Wordpress to a static site, which would make it much easier to (1) update the site's design, (2) for anyone to contribute posts, (3) for posts to be reviewable before they are published, i.e. via pull requests, just like code, and (4) will improve the speed and security of the site
- fixing our mailing list situation (migrating back to Mailchimp)
- setting up a forum of some sort
I'm not sure what should be taking priority.
<greg> any thoughts/suggestions/feedback on that is welcome
<greg> Maybe finish blog post, then work on converting website to static site?
<Sandrina> Blog post and then mailing list so we can ask for earlier feedback as margarida suggested days ago
<greg> hmm. there is a technical issue with Margarida's suggestion that needs to be addressed to do it, which is how to receive the feedback. Sure, we can ask people to just email us... that's one way. But maybe it would be more useful to have them give us feedback on a forum?
<Sandrina> For now email/github would work fine. Personally i never use forums, so I can’t say what’s best. I always look for channels like slack, discord, spectrum,..