Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 21 18:28
    GitLab | Greg Slepak pushed 3 commits to Group Income - Simple
  • Jan 20 03:25
    GitLab | Greg Slepak pushed 4 commits to Group Income - Simple
  • Jan 20 02:26
    GitLab | Greg Slepak pushed 1 commits to Group Income - Simple
  • Jan 20 02:26
    GitLab | Greg Slepak pushed 1 commits to Group Income - Simple
  • Jan 03 23:53
    GitLab | Greg Slepak pushed 1 commits to Group Income - Simple
  • Jan 02 23:51
    GitLab | Greg Slepak pushed 11 commits to Group Income - Simple
  • Dec 05 2020 20:01
    GitLab | Greg Slepak pushed 4 commits to Group Income - Simple
  • Dec 03 2020 21:47
    GitLab | Greg Slepak pushed 1 commits to Group Income - Simple
  • Dec 01 2020 02:08
    GitLab | Greg Slepak pushed 2 commits to Group Income - Simple
  • Nov 30 2020 21:03
    GitLab | Greg Slepak pushed 3 commits to Group Income - Simple
  • Nov 17 2020 22:40
    GitLab | Greg Slepak pushed 2 commits to Group Income - Simple
  • Nov 09 2020 18:13
    GitLab | Greg Slepak pushed 1 commits to Group Income - Simple
  • Oct 17 2020 22:16
    GitLab | Greg Slepak pushed 1 commits to Group Income - Simple
  • Sep 30 2020 03:52
    GitLab | Greg Slepak pushed 1 commits to Group Income - Simple
  • Sep 28 2020 04:53
    GitLab | Greg Slepak pushed 2 commits to Group Income - Simple
  • Sep 21 2020 23:01
    GitLab | Greg Slepak pushed 5 commits to Group Income - Simple
  • Sep 14 2020 16:14
    GitLab | Greg Slepak pushed 1 commits to Group Income - Simple
  • Sep 13 2020 02:28
    GitLab | Greg Slepak pushed 1 commits to Group Income - Simple
  • Sep 13 2020 02:17
    GitLab | Greg Slepak pushed 3 commits to Group Income - Simple
  • Sep 08 2020 17:41
    GitLab | Greg Slepak pushed 2 commits to Group Income - Simple
slack-relay
@slack-relay
<greg> Feel free to improve the type support as much as you'd like in any future PRs you send as part of boyscoutting, so whether that includes adding a Conversation type, etc, if it improves the code clarity/simplicity it's fair game!
<greg> cc @Geometric Algorithm you should probably merge master again now that the flow support has been added. And all of us need to take care to keep the flow errors away πŸ™‚
slack-relay
@slack-relay
<Geometric Algorithm> Roger
slack-relay
@slack-relay
<Snowteamer> Who is Roger?
<Geometric Algorithm> Roger means "ok"
<Snowteamer> Oh ok sorry πŸ˜„
slack-relay
@slack-relay
<Geometric Algorithm> Good night.
<Snowteamer> Good night
slack-relay
@slack-relay
<greg> Don't know why I was assigned to the okTurtles/group-income-simple#586, but removed that so it's actually Note:up-for-grabs
slack-relay
@slack-relay

<Snowteamer> @Geometric Algorithm I've found something regarding the failing Cypress test in your PR:

A type errors appears in the browser console, from the file GroupPledgesGraph.vue at line 51:
import distributeIncome from '@utils/distribution/group-income-distribution.js'
This distributeIncome() function is an alias for the groupIncomeDistribution({ getters, monthstamp, adjusted }),
which means that it expects an object with getters.

However, at line [118] it gets called with arguments only suitable for functions formerly imported from mincome-default.js or mincome-proportional.js :
ourIncomeToReceive = distributeIncome(incomeDistribution, mincome) .filter(i => http://i.to === this.ourUsername) .reduce((acc, cur) => cur.amount + acc, 0)
So I've tried this as a possible solution, after restoring the relevant file, and that test case passed!
import distributeIncome from '@utils/distribution/mincome-proportional.js'

slack-relay
@slack-relay

<Geometric Algorithm> Good morning.

Getting coffee and looking into, @Snowteamer

slack-relay
@slack-relay
<Geometric Algorithm> @Snowteamer after trying to create the getters from the vue state (to no avail), I have tried your approach.
<Geometric Algorithm> It eventually ends in this error:
slack-relay
@slack-relay
<system> file Screenshot from 2021-01-22 07-52-06.png too big to download (1450080 > allowed size: 1000000)

<Geometric Algorithm> @Snowteamer and @greg the above picture is if I use the antiquated file.

If I try to use our new distribution function (in the way pushed to the PR here: okTurtles/group-income-simple@62ec8a3), we get the same error as above:

<Geometric Algorithm> It is at least starting to pass MORE of the cypress tests.
<Geometric Algorithm> With either solution.
slack-relay
@slack-relay
<greg> @Geometric Algorithm Just a heads up: as this week I'm mostly taking it easy to recover from a second wave of whatever it was that was getting me last year (maybe covid, maybe burnout, or maybe something else entirely) I'm going to be avoiding coding much and trusting that you and others can handle investigating these issues, and meanwhile I'll be focusing on stuff that I do have the energy for, which is reviewing PRs that have passing tests, reviewing Catarina's changes to the copy for FAQs/crowdfunding, and also figuring out the recruiting stuff
slack-relay
@slack-relay
<Snowteamer> @Geometric Algorithm There were two antiquated distribution files to try, did you try both?
<Snowteamer> @greg Take care!
<greg> Thx!
slack-relay
@slack-relay

<Geometric Algorithm> @Snowteamer Good question:

No, just one, and in retrospect it might have been an older version of it...

What is the most efficient way of restoring the newest-deleted-version of a file in git? Is it git cherry-pick?

slack-relay
@slack-relay

<Geometric Algorithm> Looking into.

Also: if anyone is familiar with how to use Zap wallet for Android, please let me know.

<greg> @Geometric Algorithm have a look at β€œgit show”
<Geometric Algorithm> Will do!
<Geometric Algorithm> Also: looking into https://btcpayserver.org/
<greg> Yeah, we might pair with that later
<greg> Calling it a night for now
<Geometric Algorithm> Get some rest, homie!
<Geometric Algorithm> We got this.
slack-relay
@slack-relay
<greg> :man-bowing:😴
slack-relay
@slack-relay
<Snowteamer> @Geometric Algorithm To restore a given file from a specific branch or commit, I commonly do git restore --source <branch_or_hash> -- <file_path>
<Snowteamer> And you can even specify multiple files to restore at once - see the manual page that opens when running git help restore πŸ™‚
slack-relay
@slack-relay

<Geometric Algorithm> Relavent links for me (and maybe others) for lightning network:
https://lightninginabox.co/2018/12/how-to-install-btcpayserver-on-raspberry-pi-3-b/
https://www.ecorobotics.com.na/collections/development-kits/products/raspberry-pi-4-model-b-8gb-kit

It will take me until the next billing cycle to fully configure this setup.

slack-relay
@slack-relay
<Geometric Algorithm> I am beginning to think it is the cypress tests that are broken. This error happens no matter what.
slack-relay
@slack-relay
<Geometric Algorithm> This suspicion comes after trying the old methods from the two different old files on master branch (mincome-proportional.js and mincome-default.js).
slack-relay
@slack-relay
<Geometric Algorithm> Trying to use the new distribution function is yielding another problem:
<Geometric Algorithm> import { currentMonthstamp } from '@utils/time.js' doesn't seem to work inside of GroupPledgeGraph.vue
<Geometric Algorithm> I'll push this version as the new PR before bed.
slack-relay
@slack-relay
<Snowteamer> Cypress tests almost never work on my end, even when they pass on Travis
<Snowteamer> Probably because I'm still on Windows, but still
slack-relay
@slack-relay
<Snowteamer> Interestingly enough, an unhandled promise rejection error appears on this screenshot;
it might have caused the UI to stop updating and fail the subsequent tests
slack-relay
@slack-relay
<Snowteamer> I also frequently see so-called "duplicate redirection errors to '/' " when using the app manually.
Besides, a comment in frontend/controller/router.js already mentions a redirection issue, so there might be a bug lurking around in that file or in the vue-router module itself.
slack-relay
@slack-relay
<Geometric Algorithm> Good morning!
<Geometric Algorithm> I am eager to try to get the new distribution logic function tested today.
<Geometric Algorithm> I will try to resolve the currentMonthstamp is undefined today and let you know the results.
slack-relay
@slack-relay
slack-relay
@slack-relay
<greg> Summary of Chat: