Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Dec 17 2019 18:44
    GitLab | Greg Slepak pushed 1 commits to Group Income - Simple
  • Dec 17 2019 18:04
    GitLab | Greg Slepak pushed 2 commits to Group Income - Simple
  • Nov 30 2019 22:32
    GitLab | Greg Slepak pushed 1 commits to Group Income - Simple
  • Nov 30 2019 17:28
    GitLab | Greg Slepak pushed 2 commits to Group Income - Simple
  • Nov 18 2019 23:19
    GitLab | Greg Slepak pushed 3 commits to Group Income - Simple
  • Nov 13 2019 19:07
    GitLab | Greg Slepak pushed 1 commits to Group Income - Simple
  • Nov 09 2019 18:34
    GitLab | Greg Slepak pushed 3 commits to Group Income - Simple
  • Oct 23 2019 18:28
    GitLab | Greg Slepak pushed 1 commits to Group Income - Simple
  • Oct 23 2019 18:27
    GitLab | Greg Slepak pushed 1 commits to Group Income - Simple
  • Oct 23 2019 07:01
    GitLab | Greg Slepak pushed 6 commits to Group Income - Simple
  • Oct 22 2019 07:18
    GitLab | Greg Slepak pushed 1 commits to Group Income - Simple
  • Oct 22 2019 06:50
    GitLab | Greg Slepak pushed 5 commits to Group Income - Simple
  • Oct 20 2019 07:04
    GitLab | Greg Slepak pushed 2 commits to Group Income - Simple
  • Oct 19 2019 16:32
    GitLab | Greg Slepak pushed 1 commits to Group Income - Simple
  • Oct 19 2019 15:27
    GitLab | Greg Slepak pushed 5 commits to Group Income - Simple
  • Oct 18 2019 09:27
    GitLab | Greg Slepak pushed 2 commits to Group Income - Simple
  • Oct 17 2019 09:03
    GitLab | Greg Slepak pushed 2 commits to Group Income - Simple
  • Oct 16 2019 12:55
    GitLab | Greg Slepak pushed 1 commits to Group Income - Simple
  • Oct 16 2019 09:17
    GitLab | Greg Slepak pushed 1 commits to Group Income - Simple
  • Oct 05 2019 04:48
    GitLab | Greg Slepak pushed 1 commits to Group Income - Simple
slack-relay
@slack-relay
<Margarida> Another thing… I would love to get to know our users a bit better. It would be great if we could send an email to everyone that entered their email at http://groupincome.org and ask them something like “What do you plan on using groupincome for? Tell us your story!”
<Margarida> This way we can get some more realistic scenarios and do some thought exercises on whether or not what we are doing will help!
slack-relay
@slack-relay
<greg> @Margarida Really great work and I think your idea about the mailing list is a good one worth exploring. I'm going to see if that's maybe something @mae can help us with 🙂
slack-relay
@slack-relay
<greg> just posted my replies on Figma. Still need to get to @Pierre's PR, was hoping to have done that today but wasn't able to get to it. Hopefully tomorrow!
slack-relay
@slack-relay

<Margarida> @Pierre the only thing missing from what I requested is this comment:

Horizontal spacing between labels (desktop and tablet) - Should be 40px as you have them, but the last item should not have a margin-right;

slack-relay
@slack-relay
<Margarida> Let me know when that’s ready so I can approve it 🙂
slack-relay
@slack-relay
<greg> @Sandrina came up with a really great idea here to improve our Cypress tests. Very impressive! https://github.com/okTurtles/group-income-simple/issues/799#issuecomment-573301251
slack-relay
@slack-relay
<greg> @Pierre posted a review based on some tests I ran! https://github.com/okTurtles/group-income-simple/pull/789#pullrequestreview-341632605
will continue reviewing based on the code next
<Pierre> Ok. I will fix that today
slack-relay
@slack-relay
slack-relay
@slack-relay
slack-relay
@slack-relay
<greg> Summary of Chat:
  • Greg: edit issue #651 & getting back to Sandrina on what to work on next + finishing PR reviews + blog post if time available
  • Margarida: reviewing PRs + responding to Figma feedback + and working on Payments design
  • Sandrina: improving speed of Cypress tests + something else if time available
  • Pierre: finishing dashboard PR
slack-relay
@slack-relay
<Margarida> Replied to @Sandrina’s comment on @Pierre’s PR! https://github.com/okTurtles/group-income-simple/pull/789#discussion_r365950977
slack-relay
@slack-relay
<Sebin> @greg Sorry for the late response to your comment here(https://okturtles.slack.com/archives/C0EH7P20Y/p1578525505001000)! I just pushed some commits to the PR that resolve the merge conflicts and also fix all the change requests brought up there.
<Sebin> Hi @Margarida , Have you read this comment here(https://github.com/okTurtles/group-income-simple/pull/765#issuecomment-562731411)? 🙂
slack-relay
@slack-relay
<greg> @Sebin excellent! I'm looking forward to reviewing it! 😄
<greg> (and hopefully merging it this week!)
slack-relay
@slack-relay
<greg> Currently reviewing @Sebin's PR. @Sandrina if you have a moment, please also check if all your concerns were addressed :)
<Sandrina> I’ll take a look tomorrow @greg, if it’s okay for me, can I merge it?
<greg> @Sandrina yep!
slack-relay
@slack-relay
<greg> @Sebin just letting you know, I edited your PR's description to rename InviteLinkToCopy.vue => LinkToCopy.vue
<greg> (since that's the name of the component in the PR)
slack-relay
@slack-relay
slack-relay
@slack-relay
<greg> @Pierre currently writing a partial review of your PR based solely on testing. once that's posted will continue ahead with the code review
slack-relay
@slack-relay
<greg> @Pierre done! https://github.com/okTurtles/group-income-simple/pull/789#pullrequestreview-342936299
(Still more to come but this way I get you feedback early so you don't have to wait)
slack-relay
@slack-relay
<greg> edited my comment to remove my suggestion about what should be done to fix Issue 1. I'm assuming the designs give better guidance on that.
slack-relay
@slack-relay
<greg> The way you've done the animations on the labels is also very cool (how they fly from bar to bar)
slack-relay
@slack-relay
<greg> @Pierre code review done! note that i skipped reviewing the graph code and am trusting you on that because reviewing that will hold me up from moving on to other items, and as long as it works I trust you! 🙂 https://github.com/okTurtles/group-income-simple/pull/789#pullrequestreview-342954250
<greg> oh i just realized I missed some i18n stuff. just added a few more comments about that
slack-relay
@slack-relay
<greg> @Sandrina as far as getting back to you on what to work on next (one of my tasks for this week), I think I've done that by giving the go-ahead for the Cypress test speedup. There is also this issue I created for fixing an invite link bug: okTurtles/group-income-simple#800
slack-relay
@slack-relay
<greg> Also left some more feedback on 793 (Contributions Widget PR)
slack-relay
@slack-relay
<Sandrina> @greg Okay, I’ll work on those 3 things.
slack-relay
@slack-relay
<Sandrina> so an update on my side @greg , I spent these days working on cypress to bypass UI and some weird bugs related to identityContract happened. Basically after login/groupCreation, the state[identityContractID] is empty, but state.loggedIn.identityContractID exists. In other words, the contract itself is gone. If I refresh the page everything works fine again. I think it has something to do with async stuff not getting fully completed. Does this popup anything to your mind that might be useful for me to debug?
slack-relay
@slack-relay
<greg> @Sandrina you might want to check to make sure that everything finishes syncing. main.js has code in it that does that
<Sandrina> Thanks greg, I’ll take a look at it and let u know if I do any progress
<greg> @Sandrina cool. Oh, right, it’s the relationship between main.js and the stuff in Cypress which checks the attributes it sets. We have code in the Cypress command for logging in that waits for the contracts to finish syncing
slack-relay
@slack-relay
<Margarida> Ooops @Sebin! I missed your comment, but I agree with what you said there 🙂
slack-relay
@slack-relay
<greg> well, i'm somewhat surprised with the amount of progress I managed to get done this week. I make not promises about the Margarida/Pierre blog post, but it seems like I might finally be able to start on it!
slack-relay
@slack-relay

<greg> alternatively (to the blog post) I could work on sysadmin stuff. There are some things I'd like to do:

  • converting the site from Wordpress to a static site, which would make it much easier to (1) update the site's design, (2) for anyone to contribute posts, (3) for posts to be reviewable before they are published, i.e. via pull requests, just like code, and (4) will improve the speed and security of the site
  • fixing our mailing list situation (migrating back to Mailchimp)
  • setting up a forum of some sort

I'm not sure what should be taking priority.

<greg> any thoughts/suggestions/feedback on that is welcome
<greg> Maybe finish blog post, then work on converting website to static site?
<Sandrina> Blog post and then mailing list so we can ask for earlier feedback as margarida suggested days ago
slack-relay
@slack-relay
<Sandrina> Wordpress works perfectly fine for our current needs. Big blog sites like css-tricks work on wordpress and they receive external articles almost daily and can manage the review without github. So I’m sure we can do it as well.
<greg> hmm. there is a technical issue with Margarida's suggestion that needs to be addressed to do it, which is how to receive the feedback. Sure, we can ask people to just email us... that's one way. But maybe it would be more useful to have them give us feedback on a forum?
<Sandrina> For now email/github would work fine. Personally i never use forums, so I can’t say what’s best. I always look for channels like slack, discord, spectrum,..
slack-relay
@slack-relay
<greg> ok, we can ask them to email us... we can also use Github as our forum (by creating a community repo, and using the issues as threads)... lol
slack-relay
@slack-relay
<Sandrina> And I think that worsks perfectly fine for now 👌
slack-relay
@slack-relay
<Sandrina> And I think that worsks perfectly fine for now 👌