Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 02:12
    GitLab | Greg Slepak pushed 3 commits to Group Income - Simple
  • May 16 02:43
    GitLab | Greg Slepak pushed 7 commits to Group Income - Simple
  • May 16 01:32
    GitLab | Pierre Schweiger pushed to Group Income - Simple
  • May 16 01:31
    GitLab | Pierre Schweiger pushed to Group Income - Simple
  • May 16 01:28
    GitLab | Pierre Schweiger pushed 3 commits to Group Income - Simple
  • May 04 21:19
    GitLab | Greg Slepak pushed 2 commits to Group Income - Simple
  • May 03 00:25
    GitLab | Greg Slepak pushed 4 commits to Group Income - Simple
  • Apr 28 21:01
    GitLab | Greg Slepak pushed 2 commits to Group Income - Simple
  • Apr 26 22:40
    GitLab | Greg Slepak pushed 5 commits to Group Income - Simple
  • Apr 22 14:56
    GitLab | Greg Slepak pushed 25 commits to Group Income - Simple
  • Apr 22 05:07
    GitLab | Greg Slepak pushed 1 commits to Group Income - Simple
  • Apr 22 04:18
    GitLab | Greg Slepak pushed 21 commits to Group Income - Simple
  • Apr 12 20:25
    GitLab | Greg Slepak pushed 3 commits to Group Income - Simple
  • Apr 09 19:05
    GitLab | Greg Slepak pushed 3 commits to Group Income - Simple
  • Apr 06 04:46
    GitLab | Greg Slepak pushed 3 commits to Group Income - Simple
  • Apr 06 04:45
    GitLab | Greg Slepak pushed 2 commits to Group Income - Simple
  • Apr 06 04:40
    GitLab | Greg Slepak pushed 3 commits to Group Income - Simple
  • Apr 03 23:57
    GitLab | Greg Slepak pushed 1 commits to Group Income - Simple
  • Apr 02 00:11
    GitLab | Greg Slepak pushed 8 commits to Group Income - Simple
  • Mar 30 13:35
    GitLab | Greg Slepak pushed 6 commits to Group Income - Simple
slack-relay
@slack-relay
slack-relay
@slack-relay

<greg> Summary of Chat:

  • Pierre: info icon disappears on scroll (#1234) + 6 months support history mobile version + PR feedback
  • Leihla: Mobile version of support history widget + Document new proposals widget + Dark theme system settings (#985)
  • Ricardo: Implementing key management for joining a group
  • Greg: Review Ricardo’s PR + Review Alex’s PR + Review Pierre’s PR + Get started implementing contract versions (#1214) (Maybe: review other PRs)
  • Andrea: Schedule A to 100% + working with Mae on blogs & grants
  • Alex: TBD
  • Snowteamer: TBD

Preliminary Success Rate: 90% ! (Pending Alex)

slack-relay
@slack-relay
<Alex Jin> @greg, @Snowteamer, @Pierre. Opened okTurtles/group-income#1274 again. Ready for the review.
slack-relay
@slack-relay
<greg> Got it, should be able to have a look tomorrow
slack-relay
@slack-relay
<Snowteamer> • Snowteamer: Review Alex's PR + Improving Deno backend server + captureLogs.js http://console.info issue

<Snowteamer> Regarding that last issue, not sure whether converting appLogsFilter from an array to a plain object is a valid optimization as it only has up to four elements.

If app log capturing performance should be questioned or improved, I think I'd first look for a way to reduce the frequency of local storage calls. I'm not sure but they are likely slow.

Other smaller changes might also be considered, like replacing the Proxy object by plain hooks. This might remove one level of indirection when calling console methods.

slack-relay
@slack-relay
<Alex Jin> Thanks, @Pierre
slack-relay
@slack-relay
<Snowteamer> About issue #1272, if we strongly care about local storage space and/or bandwitdh usage minimization then maybe we should look into https://github.com/BonsaiDen/BiSON.js
slack-relay
@slack-relay
<greg> I caught a cold, and spent today being kinda groggy. Will try to get something done today, but might have to wait for my brain to be back online (hopefully tomorrow)
slack-relay
@slack-relay
<Alex Jin> @greg, take care of your self. 💊
<greg> Thanks Alex, will do! I've been resting and eating lots of garlic :)
slack-relay
@slack-relay

<greg> @Snowteamer

Regarding that last issue, not sure whether converting appLogsFilter from an array to a plain object is a valid optimization as it only has up to four elements.
Fair point.

If app log capturing performance should be questioned or improved, I think I’d first look for a way to reduce the frequency of local storage calls. I’m not sure but they are likely slow.
True… although, AFAIK they are done asynchronously right? And we don’t await on them.

Other smaller changes might also be considered, like replacing the Proxy object by plain hooks. This might remove one level of indirection when calling console methods.
Interesting idea 👍

<greg> Today I’m feeling better, but still not so good that I’d consider myself back to normal. It’s interesting how when I get a cold, my body seems to have to go through various stages until it is “done” being sick. Tomorrow, hopefully, I’ll be relatively normal. Today I might work away slowly at a PR review, we’ll see
slack-relay
@slack-relay
<Alex Jin> @greg, can you please have a look at and reply to https://github.com/okTurtles/group-income/pull/1274#discussion_r876424978?
slack-relay
@slack-relay
<greg> @Alex Jin i’ll try, am not sure if my head will work though
<greg> @Alex Jin this is something that I’ll have to get back to you later on in the week when my head is feeling better
slack-relay
@slack-relay
<Alex Jin> Sure. Take care.
slack-relay
@slack-relay
<Alex Jin> @Snowteamer, replied to your comments. Can you please check my comments and reply again?
slack-relay
@slack-relay
<Snowteamer> Maybe dumb question: why do we store logs in local storage anyway? Do we need to keep logs across sessions or page refreshs?
slack-relay
@slack-relay
<greg> @Snowteamer yeah, so that users can send them to us. The user settings has an applications log page that lets them do it. Without it we might miss what went wrong. It's to help users send us useful info when opening bug reports
slack-relay
@slack-relay
<greg> Today I’m feeling better, around 80% back to normal. That cold stole a few days from me! 🤧😤
<Alex Jin> Congratulation to kick the cold out.
slack-relay
@slack-relay
<greg> @Alex Jin heh, I managed two review comments today. Tomorrow hopefully I’ll post a whole lot more!
slack-relay
@slack-relay
<Alex Jin> Awesome. 👍
slack-relay
@slack-relay
<Snowteamer> @greg Yea that page has a "Download" button to extract the logs as a .json file the user can send us. But why do we need log data to come from local storage? Wouldn't this work as well if the logs came from an in-memory array?
slack-relay
@slack-relay
<greg> @Snowteamer if they refresh the page it would clear the log
<greg> Sometimes errors stack on top of one another, and after refresh a different error might occur, and we'd lose the log of the original error that triggered any subsequent errors
slack-relay
@slack-relay
<greg> however, you do raise a valid point about it being a possible performance issue, especially if they enable debug logging. So… we might have to consider the option of redirecting the code to write to an in-memory array instead.
<greg> we’d be trading more reliable logs for performance, but it might not be a big deal
slack-relay
@slack-relay
<greg> I’ve added a comment to the issue with the pros & cons here: https://github.com/okTurtles/group-income/issues/1273#issuecomment-1133179927
slack-relay
@slack-relay
<greg> @Alex Jin I suggested an alternative implementation of 'backend/db/streamEntriesBefore' here: https://github.com/okTurtles/group-income/pull/1274/files#r878461748
I don’t know though how to properly handle letting the caller know of an error during the stream though, and the same issue exists in 'backend/db/streamEntriesSince'. Maybe either you or @Snowteamer have ideas for that
<Snowteamer> @greg In order to keep logs across page refreshs, we could also flush the log array to local storage e.g. once every 5 minutes, or when a specific error event occurs.
slack-relay
@slack-relay
<Snowteamer> Or in window.onbeforeunload but it has some issues
<greg> @Snowteamer great idea! Could you add that idea in a comment to that issue so we don’t forget?
<Snowteamer> Sure 🙂
<greg> @Snowteamer and also, as I know you’re working on Deno, I’ve a question for you here in Alex’s PR related to that: https://github.com/okTurtles/group-income/pull/1274/files#r878467762
(Btw, I will assign the Deno issue to you, so that others know you’re working on it)
slack-relay
@slack-relay
<Snowteamer> @greg Replied to your questions! 🙂
<Snowteamer> Took me a while as I'm not very good to write quickly
slack-relay
@slack-relay
<Snowteamer> Regarding ReadableStream, that has not much to do with the original question but I would add that Deno has a quite different API (Readable) , so using these APIs directly is not that great for compatibility.
Also, I understand that we're streaming entries from the server for improved throughput, but on the client-side it looks like we're waiting for all entries to be received before going on. Does streaming still makes sense in that case? Maybe it really does. I'm just not sure here.
slack-relay
@slack-relay

<greg> @Snowteamer thanks for the replies! Hopefully it help @Alex Jin.

Does streaming still makes sense in that case? Maybe it really does. I’m just not sure here.
Well, that’s a fair point, it just means that if needed, the client-side of the code could be improved to take advantage of it

slack-relay
@slack-relay
<Alex Jin> Thanks. I will have a look at it.
slack-relay
@slack-relay

<greg> ✅ Review Alex’s PR: https://github.com/okTurtles/group-income/pull/1274#pullrequestreview-980739154

Great job @Alex Jin! 😄

slack-relay
@slack-relay

<greg> ✅ Review @Pierre’s PR: https://github.com/okTurtles/group-income/pull/1278#pullrequestreview-980750053

Also fantastic work! 🙂

slack-relay
@slack-relay

<greg> ✅ Review @Ricardo Iván Vieitez Parra’s PR. https://github.com/okTurtles/group-income/pull/1257#pullrequestreview-980771674

Fantastic progress! This is a preliminary review and I will wait for replies to the various comments (old unaddressed ones & new) before proceeding with a more in-depth review.

slack-relay
@slack-relay
<greg> Approved and merged @Pierre’s updates to the Support History widget! Great job Pierre!!! 😄 okTurtles/group-income#1278
slack-relay
@slack-relay
<greg> And thank you @Pierre for PR #1280 - Info icon mobile fix! First commit - perfect! Merged! 😄 🎉
slack-relay
@slack-relay
<Snowteamer> @greg Small PR available for #1268, awaiting review and testing
slack-relay
@slack-relay
<Snowteamer> I wonder whether Application Logs and Troubleshooting should be merged into one section
<Snowteamer> They are definetely related
<Snowteamer> And there is quite a lot of empty space left at the bottom of the Troubleshooting page