<greg> i'll be running about a minute late or so.... see you guys soon!
<greg> Summary of Chat:
- Greg: Merge Payments PR early in the week!! + Posting job listing (@andrea) + PR/Figma/Blog reviews
- Margarida: More chat stuff + PR reviews
- Sandrina: Continuing payments + PR reviews
- Catarina: Second draft of the blog post following feedback
- Pierre: Life 😄 + Finish implementing 404/500 error pages + Pick and open issue + PR reviews
<greg> https://twitter.com/taoeffect/status/1280194895831904259 *new tweet (no edit on twitter yet!)
<greg> Awesome! thanks @Margarida! 😄
<greg> didn't think you'd be up this late. one thing i'm wondering is if you can get the tests to pass
<greg> might be too late to do that tonight
<greg> cause i can't merge anything unless they're passing
<Sandrina> and yes, it's late... but my schedules are very flexible, especially nowadays that I can't work during the day because it's just too hooot 🥵
<greg> awesome!! thanks for the update! gonna check out the latest changes 🙂
<greg> Alright @Sandrina, since on the call we noted that the Payments would be merged either monday/today, I went ahead and merged it after not seeing anything super critical, although I might have missed something! okTurtles/group-income-simple#918
You are now unblocked to finish polishing that PR and implementing the rest of the TODOs in a new PR!
<greg> @Pierre I think you didn't get a chance to review that PR? You can still do it, please feel free to leave any feedback on things you notice even though it was merged. Sandrina can then fix them in a followup!
<Pierre> ok, will do
<Sandrina> Today I spent a good amount of time testing the payments and found quite a few scenarios with unexpected outcomes related to income/payments distribution... I described some of them here: https://github.com/okTurtles/group-income-simple/issues/763#issuecomment-656250338.
I don't consider all of them exactly a "code bug", but more of "UX/userflow flaws". So, @Margarida your feedback would also be welcome here.
I don't consider all of them exactly a "code bug", but more of "UX/userflow flaws". So, @Margarida your feedback would also be welcome here.
<greg> @Sandrina excellent research! 👍
<greg> i didn't fully read the post yet but i skimmed it and was impressed by its thoroughness
<greg> will be also diving deeper into that later today
<greg> am also curious to hear Margarida's thoughts
<Sandrina> I'm not done yet relating each scenario. I'll add more info later today, but it's already a good chunk of problems.
<greg> cool, looking forward to it 👍
<Margarida> @Sandrina
<Sandrina> Yes @Margarida, that's part of the problem in the first chunk of scenarios.
<Margarida> ok, I’ll read the rest and leave a comment 🙂
<Sandrina> Meanwhile, I also opened a small PR, ready to review, with some improvements to payments.
okTurtles/group-income-simple#951
@greg, from the current TODO list in #763, is there anything in particular you want me to work on?
okTurtles/group-income-simple#951
@greg, from the current TODO list in #763, is there anything in particular you want me to work on?
<greg> @Sandrina wait, you closed 763, but not all the checkboxes have been checked
<greg> so why did you close the issue?
<Sandrina> did i? my mistake! reopened! probably clicked on the wrong button when I was posting an answer
<greg> ah thanks 🙂
<greg> @Sandrina so i just got back from my run (today i've had a late start), and a great answer to your question will need to wait until i've settled into work mode. however, a quick off-the-cuff answer is: anything that needs doing, and hasn't been done, feel free to do it in the order you feel like doing. Hope that's helpful? If not, let me know exactly what I can do to help (and i'll help as soon as I'm ready!)
<greg> so you're asking what's the highest priority?
<greg> I would say everything having to do with basic payment dynamics, e.g.:
- cancelling payment workflow (after you've sent one accidentally or made a mistake in recording it; might need to coordinate with @Margarida on that)
- pagination
- full partial payments support
Meanwhile, everything more complicated or not super critical, e.g. archiving of payments for future retrieval, can be de-prioritized and done later
<greg> aim for getting the core payments functionality fully working
<Sandrina> ok. I'll see what I can do 🙂
<greg> awesome 🙂 👍