These are chat archives for opal/opal

26th
Dec 2015
Alexandr Smirnov
@JelF
Dec 26 2015 09:55
Hi guys. What about rails 5?
Whould it be supported, where it should be discussed and how can i contribute?
Elia Schito
@elia
Dec 26 2015 10:07
@JelF hi!
Alexandr Smirnov
@JelF
Dec 26 2015 10:07
@elia hi!
Elia Schito
@elia
Dec 26 2015 10:07
the right place is Opal-rails
Alexandr Smirnov
@JelF
Dec 26 2015 10:08
any gitter for it?
Elia Schito
@elia
Dec 26 2015 10:08
no, you can discuss it right here
Alexandr Smirnov
@JelF
Dec 26 2015 10:08
ok¸ ty
Elia Schito
@elia
Dec 26 2015 10:09
also I'm working on using appraisal to test against multiple rails versions
the reference branch is Opal-RSpec-rails
because the plan is to extermalize RSpec support and give choice (and support) for Opal-Minitest too
if you wanna help with rails 5 I can merge it to master to make it stable (i.e. No push -f)
@JelF ^ :smile:
Alexandr Smirnov
@JelF
Dec 26 2015 10:13
im writing an issue to describe problems of rails 5 migrating
Alexandr Smirnov
@JelF
Dec 26 2015 10:20
@elia, made it (opal/opal-rails#76)
Alexandr Smirnov
@JelF
Dec 26 2015 10:31
also, after i fixed it i found my assets/*/.js.rb files aoutoloaded
trying to find why right now
Elia Schito
@elia
Dec 26 2015 10:42
@JelF that's a problem we had in the past too, I even sent a couple PRs to rails that were merged and then reverted (because of some regression) but in the meanwhile it was fixed by calling eager_load_paths during the init process (https://github.com/opal/opal-rails/blob/270d20e24046c3a746d1654e90ae333741fe8589/lib/opal/rails/engine.rb#L20-L22)
Alexandr Smirnov
@JelF
Dec 26 2015 10:43
ok, so my problem is only rack2, than i can use opal-rails
Elia Schito
@elia
Dec 26 2015 10:50
then it's probably just a metter of making opal work with the latest rack and sprockets gems
@JelF if you can put toghether a PR for that (even with just some failing specs) that would be awesome
Alexandr Smirnov
@JelF
Dec 26 2015 10:51
i'll make a PR with updated travis, which will fix rack issue
found simple workaround
Elia Schito
@elia
Dec 26 2015 10:51
:+1:
Alexandr Smirnov
@JelF
Dec 26 2015 10:53
can't find file: "rubyspec/core/array"  in ["/home/jelf/docs/ruby/opal/opal", "/home/jelf/docs/ruby/opal/stdlib", "/home/jelf/docs/ruby/opal/lib", "/home/jelf/docs/ruby/opal/spec", "/home/jelf/docs/ruby/opal/lib", "/home/jelf/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/bundler/gems/mspec-b8be21eef09d/lib"]
b/ruby/gems/2.2.0/bundler/gems/mspec-b8be21eef09d/lib"]
    from /home/jelf/docs/ruby/opal/lib/opal/builder.rb:127:in `process_require'
    from /home/jelf/docs/ruby/opal/lib/opal/builder.rb:42:in `block in build_str'
    from /home/jelf/docs/ruby/opal/lib/opal/builder.rb:42:in `map'
    from /home/jelf/docs/ruby/opal/lib/opal/builder.rb:42:in `build_str'
    from /home/jelf/docs/ruby/opal/lib/opal/cli.rb:110:in `block in build'
    from /home/jelf/docs/ruby/opal/lib/opal/cli.rb:157:in `evals_or_file'
    from /home/jelf/docs/ruby/opal/lib/opal/cli.rb:109:in `build'
    from /home/jelf/docs/ruby/opal/lib/opal/cli.rb:119:in `compiled_source'
    from /home/jelf/docs/ruby/opal/lib/opal/cli.rb:85:in `run_code'
    from /home/jelf/docs/ruby/opal/lib/opal/cli.rb:69:in `run'
    from bin/opal:22:in `<main>'
bundle exec rake :(
Elia Schito
@elia
Dec 26 2015 10:55
from which project?
Alexandr Smirnov
@JelF
Dec 26 2015 10:55
opal
without ENV
Elia Schito
@elia
Dec 26 2015 10:56
try bundle exec rake mspec_opal_nodejs
wait
git submodule update --init
that should make it work
Alexandr Smirnov
@JelF
Dec 26 2015 10:56
lol, ty :)
Alexandr Smirnov
@JelF
Dec 26 2015 11:34
@elia opal/opal#1260
check pending rspec example, please
Elia Schito
@elia
Dec 26 2015 11:36
sure, was reading through it just now : )
I'll add a couple questions/comments to the diff direclty on GH
Alexandr Smirnov
@JelF
Dec 26 2015 11:36
waiting for it :)
Alexandr Smirnov
@JelF
Dec 26 2015 12:05
@elia, can you answer my questions on GH?
Elia Schito
@elia
Dec 26 2015 12:11
done :)
Alexandr Smirnov
@JelF
Dec 26 2015 12:21
@elia, done :)
Elia Schito
@elia
Dec 26 2015 13:12
@JelF see my comment on squashing commits, let me know if you need any help on that, I already have you're branch checked out so I can do that myself too
Alexandr Smirnov
@JelF
Dec 26 2015 19:49
@elia sory, was away from keyboard. As far as i see, it already have been merged
when would it be released?
Alexandr Smirnov
@JelF
Dec 26 2015 20:00
@elia, seems i have broken master, lol
tests passing, but their coverage is too low
Elia Schito
@elia
Dec 26 2015 20:01
ouch
Alexandr Smirnov
@JelF
Dec 26 2015 20:01
made PR with fix
Do you want me to improve coverage, and possibly make 100% coverage to be required to travis pass?
Elia Schito
@elia
Dec 26 2015 20:02
I had the impression the build was particularly slow with the previous PR…
Alexandr Smirnov
@JelF
Dec 26 2015 20:03
i am not familar with your travis system, so i did not set USE flag in RACK2 test
it could be speeded up
Elia Schito
@elia
Dec 26 2015 20:04
let me check because I'm not sure I follow :)
Alexandr Smirnov
@JelF
Dec 26 2015 20:04
also, i think there is no matter which time it takse to build (if less than a hour)
target is time of rake task which will be mnostly used
Elia Schito
@elia
Dec 26 2015 20:08
@JelF where did you see the coverage report?
Alexandr Smirnov
@JelF
Dec 26 2015 20:08
i did not see the coverage report
i only can see some uncovered lines
e.g. my line with binding.pry
if travis would check coverage, it would be simplier
i can also suggest rubocop if you like it
Elia Schito
@elia
Dec 26 2015 20:11

I had the impression the build was particularly slow with the previous PR…

(no, it wasn't, just checked)

Alexandr Smirnov
@JelF
Dec 26 2015 20:11
it actualy was, for 1 task
which i have added
what about coverage check?
i can create an issue describing it benefits
Elia Schito
@elia
Dec 26 2015 20:13
no need for it, I think the best would be to use a service like coveralls for that…
Alexandr Smirnov
@JelF
Dec 26 2015 20:13
afaik, it actualy uses travis ci task to report it :)
Elia Schito
@elia
Dec 26 2015 20:14
ok, gotta go, please send more tests if you can, they're greatly appreciated!
Elia Schito
@elia
Dec 26 2015 23:55
@meh anything against adding coveralls?