opal/opal

Ruby in the Browser

Ilya Bylich

@iliabylich

We can't fix it

Or even this :smile:

def m
  `#{"return"}`
end

Jan Biedermann

@janbiedermann

Then the fix is documentation, i guess: if you use anonymous functions with return in a inlined js block, you must explicitly return a value from the inlined block

Jan Biedermann

@janbiedermann

no wait, its worse, it would also hit a return_ticket_price = #{total_ticket_price - to_ticket_price}

Jan Biedermann

@janbiedermann

makes 6 specs fail

is actually not true, works perfectly with mulitline = strs > 0, was my debugging output leftover that made tests fail

Jan Biedermann

@janbiedermann

@iliabylich now this multiline patch breaks for example:

  def self.find(selector)
    `$(#{selector})`
  end

from opal-query, which is now considered a multiline, so no return is added, leading to:

  return Opal.defs(self, '$find', TMP_find_1 = function $$find(selector) {
    var self = this;

    $(selector)
  }, TMP_find_1.$$arity = 1)

chaning it to multiline = strs.any? { |str| str.end_with?("\n") }does seem to do the right thing

Simon George

@sfcgeorge

Kinda makes sense as semicolons are optional in JS, checking for newlines would do what it says on the tin I guess.

Ilya Bylich

@iliabylich

I guess it does handle

def m
  %x{
    1 + 1
  }
end

Simon George

@sfcgeorge

I'd assume there's a strip somewhere

Ilya Bylich

@iliabylich

That's an AST, not a string with the source code

Simon George

@sfcgeorge

Yeah, an AST usually doesn't have whitespace in

Jan Biedermann

@janbiedermann

but thats a ruby ast, where the inline js is just a string

or many strings

interrupted by ruby ast, if you js #{ ruby } more js

and the problem is exactly there, to understand js without parsing it :(

Simon George

@sfcgeorge

If the JS is just a string then surely you can strip it, so that wouldn't mistakenly be treated as multiline.

Jan Biedermann

@janbiedermann

and the ruby ast in between?

so its still ast nodes, of type :str, containing partial js

thats a :str

oh, ok, so for this case:

`$(#{selector})`

there is a tree :xstr with children:
:str (first part of js) :begin (ruby ast) :str (last part of js)

that are :strs

Jan Biedermann

@janbiedermann

so the 'mulitline' her is not the whitespace in the :strbut multiple :str, was, now with above fix, to look in the :str for a \nmulitline js is detected.
But @sfcgeorge you have a point, as minified js is minified to one line strings with no whitespace, but how would that stripping of whitespace benefit the situation here?

Mitch VanDuyn

@catmando

@/all question just came up... there is a Promise.when which could be called Promise.when_all, so why is there not a Promise.when_any?

G. Gibson

@mistergibson

So, is it impossilbe to work with a string that is ASCII8BIT ?

G. Gibson

@mistergibson

oh - got it - nevermind

G. Gibson

@mistergibson

Does anyone know of some example code for working with Buffer class?

Jamie Gaskins

@jgaskins

@catmando Bowser has a PR open for an implementation of ES6-style promises including Promise.race, which sounds like what you're looking for clearwater-rb/bowser#9

I just rewrote it a few weeks ago and rebased, so it's not actually an 18-month-old implementation I just haven't merged yet. :-) I've been considering merging it for a long time, but it removes all of Bowser's use of Opal's Promise implementation in favor of an API closer to what newer browsers offer natively, which is kinda scary.

Jan Biedermann

@janbiedermann

@elia @iliabylich and everybody else working on opal, opal 0.11 is a blessing! Its a giant step forward to ruby on the client! Its just amazing what bugs i find in existing 0.10 code and do keep wondering, "How did this ever work at all?"
I am amzed, fantastic :+1: :+1: :+1: :smile:

Elia Schito

@elia

@janbiedermann :smile: printed and framed! :laughing:

G. Gibson

@mistergibson

@elia : even though I've been into Opal a short time, I can second that sentiment. Opal is truly amazing and it has taken me in a whole new direction.

Elia Schito

@elia

@mistergibson I should add a "praise" section to the home page :smile:

G. Gibson

@mistergibson

lol, yeah

Billy.Zheng

@zw963

Thank @elia a lot for wonderful Opal. Hope see Opal 1.0 is released in the future.

G. Gibson

@mistergibson

Question: can I call a ruby object from js directly? example: @timer_handle = 'setInterval(#{self}.tick(),2000)' ... ?

Simon George

@sfcgeorge

Yes :)

do_later = $$[:setTimeout] # Accessing the "setTimeout" property
do_later.call(->{ puts :hello}, 2000)
do_later.call(->{ tick }, 2000)
do_later.call(method(:tick), 2000) # maybe

G. Gibson

@mistergibson

Sweet , thanks :)

ok, but not the way I expressed it in my question right?

Simon George

@sfcgeorge

This syntax also works $$.setTimeout(method(:tick).to_proc, 2000) http://opalrb.com/try/?code:def%20tick%0A%20%20puts%20%22yo%22%0Aend%0A%0A%24%24.setTimeout(method(%3Atick).to_proc%2C%20500)

G. Gibson

@mistergibson

Excellent, and much simpler than I thought it was - thanks again :)

Simon George

@sfcgeorge

That's from Ruby calling a JS function. If you mean from JS calling a Ruby function then no I don't think so. But you can do from Ruby inline JS calling Ruby

`setTimeout(#{method(:tick).to_proc}, 500)`

Note the backticks

G. Gibson

@mistergibson

ok, sure - that's cool

Simon George

@sfcgeorge

This post has more
https://dev.mikamai.com/2014/03/12/using-native-javascript-objects-from-opal/
Here is some docs
https://github.com/opal/opal/blob/master/stdlib/native.rb

G. Gibson

@mistergibson

That all seems very straight forward. at first I was just unsure about HOW to refer to an object/method with respect to the native call. Thanks for clarifying.

Elia Schito

@elia

Thank @elia a lot for wonderful Opal. Hope see Opal 1.0 is released in the future.

@zw963 Thanks! The plan is to have the next major release be 1.0

Forrest Chang

@fkchang

what versions of opal are people running, esp. in production?

G. Gibson

@mistergibson

@fkchang : I use a github pull for mine

Where communities thrive

People

Repo info

Activity