Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Tristan Sloughter
    @tsloughter
    to me the main thing to have in the Elixir API is a macro start_span
    which takes care of having to end_span manually but without the overhead of an anonymous fun
    since it is idiomatic in Elixir I think it is the best API to suggest to users. Erlang could technically do similar with its "macros" but it isn't idiomatic and wouldn't be used
    agree about plug. I'll get the telemetry org made this morning so we can start creating those projects
    Tristan Sloughter
    @tsloughter
    I would actually argue against having a wrapper like this PR, where it delegates, have the user use :otel directly if they want to step outside the macro
    Irving Reid
    @irvingreid
    Yeah, it felt a bit funny to be writing those wrappers when it's normal for Elixir code to call Erlang APIs directly.
    Tristan Sloughter
    @tsloughter
    yea, I just left a more detailed comment to the PR
    uh
    who created this https://github.com/opentelemetry-beam
    Tristan Sloughter
    @tsloughter
    nm, it was deadtrickster and we are all setup now
    https://github.com/opentelemetry-beam/opentelemetry_plug
    Tristan Sloughter
    @tsloughter
    Observability WG meeting is this Thursday, we'll be discussing opentelemetry and I think Metrics in particular https://calendar.google.com/calendar/embed?src=7nggdb5hnfqp828oapi119jkes%40group.calendar.google.com&ctz=America%2FDenver
    Tristan Sloughter
    @tsloughter
    working on the agenda for tomorrow morning's WG meeting https://docs.google.com/document/d/18JVh6ICLyRCJBpRVIXwcR1fb-K4qRX3WHYgtM7mFx2U/edit?usp=sharing
    Irving Reid
    @irvingreid
    i'm making a bit of progress on the telemetry API, stealing code from opencensus-elixir. If it's OK I'll probably listen in to the WG call tomorrow
    Tristan Sloughter
    @tsloughter
    cool. yes, definitely join the call if you are able
    Zach Daniel
    @zachdaniel
    sigh Things are transpiring against me. I cleared my schedule for the meeting, but a work fire took up all of my time. Sorry I wasn’t there :(
    Tristan Sloughter
    @tsloughter
    :(
    no worries
    Tristan Sloughter
    @tsloughter
    I think the opentelemetry metrics actually play nicely into use of persistent_term and counters as optimizations
    you can "bind" an instrument and labels for an optimized reference to a metric you want to be recording to
    Tristan Sloughter
    @tsloughter
    the issue with persistent terms to counter refs was always that you didn't know what the labels would be -- I guess ericsson is still in the days of recording metrics for static keys and not including labels/tags :) so this feature was added in such a way
    Tristan Sloughter
    @tsloughter
    community feedback form https://docs.google.com/forms/d/e/1FAIpQLSfe7sSL1jZjbBl0YBLgPW8vm1v7UA6YmREQcSql6D3oC_Buog/viewform
    Tristan Sloughter
    @tsloughter
    damn, that CLA is smart
    @irvingreid can you sign the CLA here? open-telemetry/opentelemetry-erlang-api#13
    Irving Reid
    @irvingreid
    @tsloughter bah, sorry for going silent for so long - I had a bit of WIP that I was going to clean up over the holidays and ended up not getting to it. Looks like you're already past the point I got to with macros. I'll need to check with my management about getting the CLA signed, I'll dig into that on Monday.
    Tristan Sloughter
    @tsloughter
    @irvingreid cool, thanks
    Tristan Sloughter
    @tsloughter
    @irvingreid any luck on the CLA?
    now that we have some Elixir code does anyone else want to be official reviewers? @zachdaniel ? hm, I'd include Gregg in that but he doesn't appear to be in here. Spandex team :)
    Zach Daniel
    @zachdaniel
    I can definitely review code
    :)
    I haven’t been able to give much, but I can do that at the bare minimum
    🙂
    Tristan Sloughter
    @tsloughter
    cool, yea, it is just a "if you have the time and want to" thing
    Tristan Sloughter
    @tsloughter
    hm, oh right, you already are a member, I don't understand why your reviews don't "count"... I could have swore you +1'ed something the other day and it wasn't considered a valid review
    Tristan Sloughter
    @tsloughter
    oooh right, CODEOWNERS
    Irving Reid
    @irvingreid
    Unfortunately it's probably going to take a while to get PD to sign the corporate CLA. I'll do the individual form to get the current PR unblocked.
    Irving Reid
    @irvingreid
    Anyone going to Lone Star Elixir (aside from Greg Mefford and Samuel Mullen, who are speaking on OpenTelemetry and Telemetry, respectively...)? Unfortunately I have a conflict & can't make it to Code Beam.
    Tristan Sloughter
    @tsloughter
    thanks
    I'm not making it to shit this year :(. missing codebeam even. since I'm in Colorado I'll probably make it to ElixirConf for the first time, but that's not until September
    Tristan Sloughter
    @tsloughter
    I'm not satisfied with it yet but https://github.com/open-telemetry/opentelemetry-erlang-api/pull/13/files
    trying our hauleth's idea of having named tracers in Elixir be modules like Ecto does with Repos
    I like that part, just not sure where some stuff goes
    Tristan Sloughter
    @tsloughter
    created issues for what is needed to reach beta milestone (scheduled for March 16) https://github.com/open-telemetry/opentelemetry-erlang-api/issues based on https://docs.google.com/document/d/1eviggoIguOS89dgKL-8ntUOCfPP6FLWAoQkGoBDsld0/edit#
    in case anyone is interested and has time to pick up one of those tasks so we can hit beta by the 16th :)
    Tristan Sloughter
    @tsloughter
    so with LibraryResource being the opentelemetry library are there resource attribute defined for the tracer name/version yet?
    Tristan Sloughter
    @tsloughter
    or wait, library resource is changed to telemetry? I must have really zoned out yesterday
    dammit, this is the wrong channel, haha
    Tristan Sloughter
    @tsloughter
    https://hex.pm/orgs/opentelemetry
    ^ API and SDK published to Hex under an opentelemetry organization
    Tristan Sloughter
    @tsloughter
    honeycomb elixir integeration now available thanks to garth :) https://hex.pm/packages/opentelemetry_honeycomb