lots to discuss in the Otel Erlang meeting this afternoon https://docs.google.com/document/d/1EbBiRjBc_cBf0T_B5OtNRPhbD4jdBrVYJAy8euCDrUI/edit#
new PR is open. this is the important change to take note of (when reviewing, it isn't touched by a user) https://github.com/open-telemetry/opentelemetry-erlang/pull/126/files#diff-8411ab5f399a2f02fad4d7808c21f1f3e1450fbbdf7b007b499e7f9de2b79024R56
6:43
the main erlang macro api and elixir api (now with macros only for start_span and
6:43
the main erlang macro api and elixir api (now with macros only for start_span and
with_span since the tracer isn't needed in many calls anymore) remain the same
Hello all, wouldn't something like this always get sampled? I don't see this exported at all (using
otel_exporter_stdout)span_with_sleep_ms(Delay) ->
Sampler = otel_sampler:setup(always_on, #{}),
Tracer = opentelemetry:get_tracer(otel_example),
otel_tracer:with_span(Tracer, <<"span_with_sleep_ms/1">>, #{sampler => Sampler},
fun(SpanCtx) ->
otel_span:set_attribute(SpanCtx, <<"Delay">>, Delay),
timer:sleep(Delay)
end).
and I'm seeing SPANS FOR DEBUG output in the Erlang console, but not the spans.
so I wanted to explicitly set an always_on sampler. I'll have to explore this a little further then
you can just print out the Tracer and it'll be the first element in the tuple is the module
if it ends with noop then that explains this
jep, it's the default tracer. Would the default tracer not sample a call as above?
Btw do exporters have to fully implements those return values? https://github.com/open-telemetry/opentelemetry-erlang/blob/0e448fd368bce65f812b8d8fea6f345176ce6ad0/apps/opentelemetry/src/otel_exporter.erl#L28
I put above example in a minimal app: https://github.com/ioolkos/otel_example/. I still must be missing some basic step in the setup, as I don't see that span exported.
becuase the way it is setup in your _app is slightly wrong
yea
@ioolkos you need to load and set the env variable before starting opentelemetry https://gist.github.com/tsloughter/7ff0ce8bfb0a884560de82e6b2a331a6
but still requires moving set_env of course
ok
great stuff :)
Howdy. Was just wondering if I could ask for a few more pointers. Relating to your comment in this issue. https://github.com/open-telemetry/opentelemetry-erlang/issues/160#issuecomment-734831168 stdout exporter is in the example config.exs. I'm looking at the example and can't see where the stdout exporter is set up. Looked at both the phoenix application https://github.com/opentelemetry-beam/opentelemetry-examples/blob/master/phoenix_backend/config/config.exs and the plug application that doesn't have a config file
?
I now have a mostly functioning setup here https://github.com/did-app/glance/pull/2/files
All that's let is to send the traces to somewhere I can usefully view them. i.e. replace the stdout exporter.
What would anyone recommend using for local development.