Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    ioolkos
    @ioolkos
    so I wanted to explicitly set an always_on sampler. I'll have to explore this a little further then
    Tristan Sloughter
    @tsloughter
    ok
    ioolkos
    @ioolkos
    but it's good to know this should work
    Tristan Sloughter
    @tsloughter
    I guess make sure the Tracer isn't noop
    you can just print out the Tracer and it'll be the first element in the tuple is the module
    if it ends with noop then that explains this
    ioolkos
    @ioolkos
    I register an application tracer, so I think it will just be otel_default_tracer
    jep, it's the default tracer. Would the default tracer not sample a call as above?
    Tristan Sloughter
    @tsloughter
    ok. no, it should
    ioolkos
    @ioolkos
    ok, thanks
    ioolkos
    @ioolkos
    Btw do exporters have to fully implements those return values? https://github.com/open-telemetry/opentelemetry-erlang/blob/0e448fd368bce65f812b8d8fea6f345176ce6ad0/apps/opentelemetry/src/otel_exporter.erl#L28
    Tristan Sloughter
    @tsloughter
    no, they can return any subset
    ioolkos
    @ioolkos
    I put above example in a minimal app: https://github.com/ioolkos/otel_example/. I still must be missing some basic step in the setup, as I don't see that span exported.
    Tristan Sloughter
    @tsloughter
    oh, I bet the sampler arg isn't working
    becuase the way it is setup in your _app is slightly wrong
    yea
    @ioolkos you need to load and set the env variable before starting opentelemetry https://gist.github.com/tsloughter/7ff0ce8bfb0a884560de82e6b2a331a6
    ioolkos
    @ioolkos
    @tsloughter ah man, of course.
    thanks!
    Tristan Sloughter
    @tsloughter
    ok, hm, the sampler arg does work
    but still requires moving set_env of course
    ioolkos
    @ioolkos
    yeah, I can still set the sampler dynamically
    Tristan Sloughter
    @tsloughter
    oh, yea, so the processors weren't setup
    ioolkos
    @ioolkos
    jep
    Tristan Sloughter
    @tsloughter
    that was the issue before
    ok
    ioolkos
    @ioolkos
    exactly
    Tristan Sloughter
    @tsloughter
    better to just put this stuff in a sys.config and add the apps to applications in the .app.src :)
    ioolkos
    @ioolkos
    sure, just wanted to be as dynamic and explicit as possible
    great stuff :)
    Tristan Sloughter
    @tsloughter
    cool
    ioolkos
    @ioolkos
    thanks for your help
    ioolkos
    @ioolkos
    I noticed ?set_status(?OTEL_STATUS_OK) doesn't set status.code to 1 in opentelemetry-collector pipeline to jaeger. Always stays 'unset' and 0 in jaeger. But I guess that's an issue of the collector, not otel-erlang. (and there's also a set of deprecated status codes, it seems)
    Peter Saxton
    @CrowdHailer
    Howdy. Was just wondering if I could ask for a few more pointers. Relating to your comment in this issue. https://github.com/open-telemetry/opentelemetry-erlang/issues/160#issuecomment-734831168 stdout exporter is in the example config.exs. I'm looking at the example and can't see where the stdout exporter is set up. Looked at both the phoenix application https://github.com/opentelemetry-beam/opentelemetry-examples/blob/master/phoenix_backend/config/config.exs and the plug application that doesn't have a config file
    Tristan Sloughter
    @tsloughter
    "tdout exporter is in the example config.exs."
    ?
    Peter Saxton
    @CrowdHailer
    I've figured that part out. Was just asking for clarification on the linked comment on github.
    I now have a mostly functioning setup here https://github.com/did-app/glance/pull/2/files
    All that's let is to send the traces to somewhere I can usefully view them. i.e. replace the stdout exporter.
    What would anyone recommend using for local development.
    Peter Saxton
    @CrowdHailer
    I see a datadog setup in the examples repo but cant work out if the locally running agent will show my traces or if I need to send them to an account I have with datadog
    Peter Saxton
    @CrowdHailer
    So it looks like Jaeger and zipkin are my choices for running a collector and ui locally.
    Tristan Sloughter
    @tsloughter
    yea
    Peter Saxton
    @CrowdHailer
    I've also moved on to using the opentelemetry_exporter I can only find docs on jaeger about supporting protobuf.
    From what it says here https://www.jaegertracing.io/docs/1.21/getting-started/ I "think" I need to point the opentelemetry_exporter to use localhost: 14250
    What I'm not sure about is if model.proto means that it accepts the opentelemetry http_protobuf format. I'm guessing it does.
    Tristan Sloughter
    @tsloughter
    hm, don't know. but you can use the zipkin exporter to write to jaeger
    if you don't want to have to to the collector to get to jaeger
    Peter Saxton
    @CrowdHailer
    The zipkin exporter doesn't work with {opentelemetry, 0.5.0}
    What would you use to look at traces generated locally?