Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Bartlomiej Obecny
    @obecny
    but that is a separate discussion, for now I will go simple and let the collector to have only grpc
    Daniel Dyla
    @dyladan
    I like that idea, but it seems like a bigger topic
    Valentin Marchaud
    @vmarchaud
    I will personally deploy in the next couples of week and i planned to export them in http (for the browser specially), i guess that i would need to pin the older version of the exporter then ?
    Daniel Dyla
    @dyladan
    no the browser will export using http. the unacceptable part was not having a grpc option
    in your case the browser will still use http (using xhr) but node will use grpc. Is that acceptable to you?
    Valentin Marchaud
    @vmarchaud
    yeah sure but in this case i believe i will have to be sure to treeshake the grpc dependency right ?
    Bartlomiej Obecny
    @obecny
    when I say http I refer to nodejs package, for browser it works fine using xmlhttprequest my main idea about splitting data transport and data transformer is partially done for exporter collector
    Daniel Dyla
    @dyladan
    @vmarchaud not sure about that. like i said, i'm not very familiar with web build tools
    Bartlomiej Obecny
    @obecny
    the web doesn't care about grpc from node, it is done the same way you have our core and for example time.ts
    Valentin Marchaud
    @vmarchaud
    Sure it does, the issue is that the grpc dependency is in this case inside the dependencies of the exporter, so pulled everytime even if i only use the browser impl
    Actually i just pulled the @grpc/grpc-js and it's only 1.4Mb on disk
    Bartlomiej Obecny
    @obecny
    with regards to extra dependency that is a valid point @vmarchaud
    Valentin Marchaud
    @vmarchaud
    guess they changed a lot in the recent version cause i pulled > 500Mb package for an older version of a an service that i maintain
    Bartlomiej Obecny
    @obecny
    it won't be however included in webpack etc. so it will be just there in node_modules
    Valentin Marchaud
    @vmarchaud
    thats assuming that its correctly treeshaked by webpack ^^
    the legacy front at my company is 1.14 which cames out looong ago
    Bartlomiej Obecny
    @obecny
    it will be there wont be dependency of grpc
    in web
    Daniel Dyla
    @dyladan
    I think this is a non-issue until we are sure it is a problem. let's move forward and if the deployment size becomes large we can address that as a separate issue
    Valentin Marchaud
    @vmarchaud
    agree
    Thomas Noe
    @t3h2mas
    What should we use while open-telemetry is in beta? I'm itching to get more tracing in our production services...
    Daniel Dyla
    @dyladan
    @/all need fast reviews on this open-telemetry/opentelemetry-js#904 currently the grpc plugin throws on any request that doesn't contain a trace context header
    Bartlomiej Obecny
    @obecny
    guys when the next beta is going to be released , or can we just release what is in master ?
    Bartlomiej Obecny
    @obecny
    any1 knows how to use github subfolder as npm source for example this "@opentelemetry/core": "github:open-telemetry/opentelemetry-js#master" will use the master branch but unfortunately it won't get core but the main folder, so how to get subfolder from packages/opentelementry-core any1 any idea ?
    Daniel Dyla
    @dyladan
    @obecny I want to release current master today as 0.5.2 as it contains some bugfixes
    0.6.0 will go out soon after with changes which are not compatible with 0.5
    no idea about install from subfolder
    Bartlomiej Obecny
    @obecny
    thx
    Daniel Dyla
    @dyladan
    Would like to include open-telemetry/opentelemetry-js#893 in 0.5.2 today if we can get enough approvals in a reasonable time
    Mayur Kale
    @mayurkale22
    in case you haven't seen it already, Austin Parker from lightstep is doing an OT JS demo at 12:30
    https://twitter.com/austinlparker/status/1244654930067107840
    https://www.twitch.tv/videos/579161661 - recording. The session got over already.
    Daniel Dyla
    @dyladan
    @mayurkale22 cool ty for link. did he happen to reach out for help making this or did he just do it on his own?
    Mayur Kale
    @mayurkale22
    I guess, he just did it on this own.
    Daniel Dyla
    @dyladan
    interesting. i'm watching it now and i'm curious to see where his sticking points are
    for instance, he is looking for a plugin for a particular http library, but any generic http library should probably work
    Mayur Kale
    @mayurkale22
    I just skimmed through the video, didnt find anything specific to OpenTelemetry.
    Daniel Dyla
    @dyladan
    he was building a simple server app and was looking for an http library which was supported
    Mayur Kale
    @mayurkale22
    I see
    Daniel Dyla
    @dyladan
    My takeaway is that people who use axios or node-fetch might look for a plugin and not find one and assume their library is not supported
    Daniel Dyla
    @dyladan
    looks like he never got the app working though, so never even got to show opentelemetry
    Mayur Kale
    @mayurkale22
    Hmm true
    Daniel Dyla
    @dyladan
    he just went live again
    Naseem
    @naseemkullah
    So axios, got, node-fetch all work with the http plugin right? BTW what is your request lib of choice and why? e.g. why axios over got and or vice-versa
    Daniel Dyla
    @dyladan
    any http library which uses the http standard lib module will work
    I don't really have a strong preference. I tend to use axios because it is popular and actively maintained
    Naseem
    @naseemkullah
    same here, I don't do much coding but when I do I use axios... got's quite popular too and some ppl at my org use it https://www.npmjs.com/package/got
    Amir Blum
    @BlumAmir
    Hi guys, I have a question regarding using SpanProcessors in JS.
    It looks like the implementation allows processors to modify spans, but it does not support filtering spans on the processors pipeline.
    Is there a way to apply filters and drop a span after it's been created and before it is consumed by the exporter?
    Bartlomiej Obecny
    @obecny
    currently there is no such possibility
    Amir Blum
    @BlumAmir
    Thanks