Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Bob Strecansky
    @bobstrecansky
    We also need to find someone that is unfamiliar with our project and has tried to implement OT-PHP in one of their projects. @dkarlovi - you might fight squarely into this bucket? : open-telemetry/opentelemetry-php#206
    Dalibor Karlović
    @dkarlovi
    sure, let me know how I can help
    I definitely qualify as "unfamiliar with OT" :)
    Bob Strecansky
    @bobstrecansky
    @dkarlovi - just following along with that document listed in open-telemetry/opentelemetry-php#206
    That would be most helepful.
    Dalibor Karlović
    @dkarlovi
    I'll try to get it done tomorrow
    Bob Strecansky
    @bobstrecansky
    You’re the best!
    HTH :)
    Dalibor Karlović
    @dkarlovi
    I've created open-telemetry/opentelemetry-php#218 to add Infection to the CI
    it highlights how far away the project's code coverage is from actual code coverage :)
    currently the MSI is 77% for covered only, 74% for everything
    Dalibor Karlović
    @dkarlovi
    which isn't all that bad, but it does leave room to improve
    added a small rationale how to read the results, hopefully that helps
    Bob Strecansky
    @bobstrecansky
    Very much appreciate it @dkarlovi !
    Dalibor Karlović
    @dkarlovi
    sure, hope it helps :)
    if there's any additional questions, feel free to ask, I've provided my work mail also in the form submission
    erv
    @ervishal

    hi guys,
    curious to know if nginx opentelemetry package available like opentracing https://docs.nginx.com/nginx/admin-guide/dynamic-modules/opentracing/?

    however I see this thread where it says under development kubernetes/ingress-nginx#5883.
    please check.

    Bob Strecansky
    @bobstrecansky
    @ervishal - Did you mean to post this in the PHP room? This might be a better question for one of the metrics rooms?
    5 replies
    Bob Strecansky
    @bobstrecansky
    I created a bunch of new tickets this morning related to @dkarlovi 's User Research document. They are all stored in a Project called "User Research Feedback Improvements". You can find it here: https://github.com/open-telemetry/opentelemetry-php/projects/5
    Bob Strecansky
    @bobstrecansky
    I’m going to have to miss our weekly meeting this week; can someone else coordinate it?
    Bob Strecansky
    @bobstrecansky
    Just so everyone is aware, the maintainers have come up with an OTEP for versioning and stability for OpenTelemetry clients (like PHP): open-telemetry/oteps#143
    I don’t think this is super important for us right now, but it certainly will be in the future as we move more towards a stable release.
    Bob Strecansky
    @bobstrecansky

    I also worked with one of the other maintainers yesterday to talk about semantic versioning for OpenTelemetry-PHP. Would love some feedback on it!

    https://docs.google.com/document/d/1qJn8LnCyl1oYAev6dTShC_Icdl1InQf8jXl8f5qPGfg/edit?usp=sharing

    Bob Strecansky
    @bobstrecansky
    Anyone else have insight into that semver document I linked above? I can finish that up today or Monday but I’d love some community feedback.
    Bob Strecansky
    @bobstrecansky
    Following up once more on that semver document I listed above cc:\ @beniamin @morrisonlevi
    Maor Goldberg
    @maorgoldberg
    Hey all,
    I have a question regarding instrumentation in php, is there an option currently to use auto-instrumentation like in node or is it currently not possible
    2 replies
    Beniamin
    @beniamin
    @bobstrecansky I added some comments on the document.
    Bob Strecansky
    @bobstrecansky
    Bob Strecansky
    @bobstrecansky
    PR for the semantic versioning rationale is up: open-telemetry/opentelemetry-php#232
    Bob Strecansky
    @bobstrecansky
    Beniamin
    @beniamin
    Hope you had great holidays. In the last period I started to analyze the specification changes in order to identify differences between our implementation and specs. The analysis is still WIP, but I will really appreciate if you have some time to review it so far. Any suggestion is wellcome. You can find it here: https://docs.google.com/document/d/1NYlT8Cxm04gLEKNFuGQYRQsgm5eUf4xIduXuxm3wGRc/edit?usp=sharing
    Bob Strecansky
    @bobstrecansky
    Planning on reading through that with a fine toothed comb tomorrow. Thank you @beniamin !
    Bob Strecansky
    @bobstrecansky
    @beniamin - thanks for the analysis! Are you planning on creating tickets for the work that needs to be done, or would you like me or @jodeev to complete that task?
    Beniamin
    @beniamin
    please, feel free to create the tasks, I will continue with the analysis
    Bob Strecansky
    @bobstrecansky
    Mohasin
    @mohasin-ali
    Hi All, do opentelemetry-php have custom exporter? in the examples section i see only Zipkin and Jaeger exporters. I am expecting like OTEL (gRPC or Http/json) exporters which is supported in Opentelemetry-JAVA.
    Bob Strecansky
    @bobstrecansky
    @mohasin-ali - @riticksingh is currently working through the OTEL implementations:
    Anish B
    @anishb_gitlab

    Hi Guys, Need some help in generating ParentBased spans for remote requests.

    When ever I generate a ParentBased span, it is appearing as a root span in the Jaeger UI. It is not appearing under the current active span.

    This is the part of php code I have written for this.

    $traceId = $request->headers->get('X-B3-TraceId');
    $spanId = $request->headers->get('X-B3-SpanId');

    $parentContext = new SpanContext(
        $traceId,
        $spanId,
        1
    );
    $root = new AlwaysOnSampler();
    $sampler = new ParentBased($root);
    
    $sampler->shouldSample(
        $parentContext,
        $traceId,
        $spanId,
        'parent-based',
        API\SpanKind::KIND_SERVER
    );
    
    $span = $tracer->startAndActivateSpanFromContext('parent-based', $parentContext, true) ;
    $tracer->endActiveSpan();

    Currently it looks like this: https://www.screencast.com/users/banish1979/folders/Default/media/bd2ab5c9-d47e-4aab-8fb6-617524c42925

    I want the span to appear like this: https://www.screencast.com/users/banish1979/folders/Default/media/d3d0f220-6844-426f-8fc0-cd111225b322

    Is there anything wrong in this code? Please advice.
    @bobstrecansky Can you please look into this request when you get a chance?
    Bob Strecansky
    @bobstrecansky
    @anishb_gitlab - we have our meeting today; I’ll be sure to bring this up. Will you please create a GIthub issue to track this when you have a moment?
    Anish B
    @anishb_gitlab
    sure
    Bob Strecansky
    @bobstrecansky
    Thank you!
    Bob Strecansky
    @bobstrecansky
    @anishb_gitlab - we are going to prioritize your fix. Were you able to make a ticket?
    Anish B
    @anishb_gitlab
    yes @bobstrecansky, here is the link open-telemetry/opentelemetry-php#244
    Please let me know if you need more info
    Bob Strecansky
    @bobstrecansky
    Thanks @anishb_gitlab will do