Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Evan Locke
    @elocke
    so when I want to send these traces to stackdriver, i switch to the export for SD? jaeger is for local dev
    Chris Kleinknecht
    @c24t
    yeah, although the SD exporter work is sitting in an open PR: open-telemetry/opentelemetry-python#288
    "collector" and "agent" are pretty common terms, e.g. the jaeger collector and various APM agents
    but when we mention "collector" it's usually the OT collector we're talking abotu
    Evan Locke
    @elocke
    ah word ok
    Evan Locke
    @elocke
    one more yall, opentracing vs opencensus? which will give me the best path forward to OT? the stackdriver thing looks to be a blocker for OT
    Chris Kleinknecht
    @c24t
    do you need metrics too or only tracing?
    Evan Locke
    @elocke
    metrics too
    metrics are actually the priority
    Chris Kleinknecht
    @c24t
    what would you use for metrics if you use opentracing? prometheus?
    Evan Locke
    @elocke
    I haven't gotten that far yet haha. but yeah prometheus or if google has an offering (i guess stackdriver?)
    Chris Kleinknecht
    @c24t
    there's stackdriver monitoring, but opencensus is actually the recommended client for stackdriver too now
    I previously worked on OC python so you can guess my biases, other people in this channel used to work on opentracing
    if you use opentracing there's an easy upgrade path to opentelemetry via https://github.com/open-telemetry/opentelemetry-python/tree/master/ext/opentelemetry-ext-opentracing-shim
    Evan Locke
    @elocke
    so from what I'm gathering is that OC/OT were 2 separate endeavors attempting to accomplish the same thing
    Chris Kleinknecht
    @c24t
    yeah
    except that OC included metrics
    Evan Locke
    @elocke
    ah, sometime in the future is there a plan to help port OC to Otelemetry?
    Chris Kleinknecht
    @c24t
    yes, but it may be easier to just switch the code to use opentelemetry
    because there are some complications in OC that make it harder to port
    Evan Locke
    @elocke
    i feel that. i mean this wont be the most complicated implementation
    Chris Kleinknecht
    @c24t
    opentracing had a nice API from the beginning, which makes it easy to use an otel tracer under the hood
    OC makes that harder
    anyway either system should work, OC has support for metrics and better support for stackdriver
    opentracing has more users and a better upgrade story to OT
    Evan Locke
    @elocke
    thanks for the help dude. looks like i got more reading to do
    Chris Kleinknecht
    @c24t
    np, good luck!
    Yusuke Tsutsumi
    @toumorokoshi
    Anyone want to chime in on #516? it's approved but Christian and I are discussing if the default value should be true or false: https://github.com/open-telemetry/opentelemetry-python/pull/516#discussion_r396585414
    Yusuke Tsutsumi
    @toumorokoshi
    @elocke sorry you're blocked on the stackdriver support. It's been sitting around a while, We'll see if we can't prioritize it a little higher. But in the meantime, I might just consider copying the code too. It's a single module licensed under Apache2: https://github.com/open-telemetry/opentelemetry-python/blob/e1b07e75d2fe7748c8b276de3d91c7b2ce8056ad/ext/opentelemetry-ext-stackdriver/src/opentelemetry/ext/stackdriver/trace/__init__.py
    Chris Kleinknecht
    @c24t
    alright gRPC is ready for review again: open-telemetry/opentelemetry-python#476
    thanks everybody for bearing with me while I was getting this working, now that it's up I'll get back on reviews
    one big problem is that gRPC servers use threadpools and handle one RPC per thread -- it looks like this isn't compatible with our contextvars-backed context: https://github.com/open-telemetry/opentelemetry-python/pull/476/files#diff-db2b3056ce2e2f6aa9f02c1e71b902d2R53
    Chris Kleinknecht
    @c24t
    @codeboten I'd love to get your opinion on that, and for you to check that I'm setting the context correctly here: https://github.com/open-telemetry/opentelemetry-python/pull/476/files#diff-c1700594ec3c6841b1f5df0cd0b65b2aR146-R150
    Mauricio Vásquez
    @mauriciovasquezbernal
    Hi!, could anybody please review open-telemetry/opentelemetry-python#512 that is fixing our documentation? thanks!
    Chris Kleinknecht
    @c24t
    @mauriciovasquezbernal stamped
    Mauricio Vásquez
    @mauriciovasquezbernal
    @c24t thanks!
    Chris Kleinknecht
    @c24t
    #525 too, thanks for doing these maintenance PRs!
    Yusuke Tsutsumi
    @toumorokoshi
    @mauriciovasquezbernal if you can update your base, I can merge in the getting started: open-telemetry/opentelemetry-python#512
    Chris Kleinknecht
    @c24t
    @codeboten thanks for the review on #476
    I'm going to make a separate PR to add the attributes from the spec, branching off this one
    if anyone objects to how the grpc package is structured so far please let me know on #476 before I start building a jenga tower of other PRs on top of it
    alrex
    @codeboten
    no objections from me
    Chris Kleinknecht
    @c24t
    @mauriciovasquezbernal if you pick up master in open-telemetry/opentelemetry-python#508 I can merge it
    (no worries if not though -- I know it's the weekend already for you)
    Diego Hurtado
    @ocelotl

    Hello folks

    Just a friendly reminder of open-telemetry/opentelemetry-python#327

    all comments have been addressed, it is ready for review :+1:

    Chris Kleinknecht
    @c24t
    thanks @ocelotl, looking again now
    Yusuke Tsutsumi
    @toumorokoshi
    Hey all, just a heads up over this weekend I'm planning on trying to play the PR merge game and get as many merged as possible, then focus on reviews after. I'll try to fire out a list of PRs that we can most likely get into our second beta release sunday evening.
    Yusuke Tsutsumi
    @toumorokoshi
    Hi Everyone, after looking through the code, I've given autoinstrumentation it's second stamp: open-telemetry/opentelemetry-python#327. I'm planning on merging it in on Monday morning, so if you have any concerns, please put your changes requested on it ASAP.
    Yusuke Tsutsumi
    @toumorokoshi
    @ocelotl can you check if your requested changes are addressed? they seem to be: open-telemetry/opentelemetry-python#474. Looks like you resolved the main comment you had as well.
    Diego Hurtado
    @ocelotl
    letsee...