Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Eric Mustin
    @ericmustin
    @fbogsany @mwear could u share the zoom link? I keep ending up in the python sig? or are we not mtg till next tuesday?
    Eric Mustin
    @ericmustin
    welp, i think i can safely assume next tuesday. :sweat_smile: . If anything needed from mtg and it did occur pls lmk. I am aiming to be able to get more active outside of reviews with the next release and getting some more integration work added
    Francis Bogsanyi
    @fbogsany
    Sorry - I probably mentioned this in a thread: I moved the meeting to Tuesday, on Tuesday evening, so we're skipping the meeting this week.
    Eric Mustin
    @ericmustin
    ok no worries! see ya tuesday
    Francis Bogsanyi
    @fbogsany
    :+1:
    Gene Liverman
    @genebean
    Should the 0.6.0 versions be showing on https://rubygems.org/search?utf8=%E2%9C%93&query=OpenTelemetry+
    Daniel Azuma
    @dazuma
    I'm checking on it.
    Daniel Azuma
    @dazuma
    I am a complete incompetent nitwit, and had the release system set on dry-run mode. That's fixed now. The releases should show up on rubygems now.
    Gene Liverman
    @genebean
    Glad that’s all it was :) Thanks for your work on this!
    Are there any examples of using the noop span exporter?
    4 replies
    Gene Liverman
    @genebean
    FYI, the new Jaeger exporter tripped me up for quite a while today. open-telemetry/opentelemetry-ruby#378 documents the issue.
    Gene Liverman
    @genebean
    Does anyone know what causes this error?
    E, [2020-09-12T00:36:44.445784 #1] ERROR -- : unexpected error in Jaeger::CollectorExporter#export - Not enough bytes remain in buffer
    6 replies
    Andrew Hsu
    @andrewhsu

    i noticed https://github.com/open-telemetry/opentelemetry-ruby/releases/tag/opentelemetry-exporter-otlp%2Fv0.6.0 released last week. does this mean https://github.com/open-telemetry/opentelemetry-specification/blob/master/spec-compliance-matrix.md#exporters table Exporters can be updated with the OTLP feature implemented?

    apologies if i’m jumping the gun on this…just excited to see more language sigs implement otlp.

    1 reply
    Mateusz "mat" Rumian
    @mat-rumian
    Hello everyone,
    I have complex issue, I'm using ot-ruby with newest OTLP by http exporter. Application is dockerized and deployed on the Kubernetes. OpenTelemetry-Collector-Contrib is used as collector with OTLP http receiver and k8s_tagger processor. The problem is that spans from ruby application don't have Kubernetes tags like k8s.namespace, k8s.container.name, k8s.container.id. Java and Python apps don't have this kind of problem, they work fine.
    6 replies
    Trey Hyde
    @treyhyde
    I've added the following to my app. This is only generating spans for redis but they that don't have parents (no context whatsover). No spans for rails (v6), db activity via AR, etc. Am I missing something basic?
    require 'opentelemetry/sdk'
        require 'opentelemetry/exporter/jaeger'
    
        # Configure the sdk with custom export
        OpenTelemetry::SDK.configure do |c|
          c.use_all
          c.add_span_processor(
            OpenTelemetry::SDK::Trace::Export::SimpleSpanProcessor.new(
              OpenTelemetry::Exporter::Jaeger::AgentExporter.new(
                host: ENV["JAEGER_AGENT_HOST"], port: 6831
              )
            )
          )
    
          c.resource = OpenTelemetry::SDK::Resources::Resource.create(
            OpenTelemetry::SDK::Resources::Constants::SERVICE_RESOURCE[:name] => 'rails'
          )
        end
    7 replies
    Azfaar Qureshi
    @AzfaarQureshi
    Hey! I was told to :shipit: this PR (open-telemetry/opentelemetry-ruby#386) but I don't have approval to merge :sweat_smile: Could someone else merge it if they have permission? Thanks
    Gene Liverman
    @genebean
    Note for the masses: SimpleSpanProcessor broke a service for us - it made an endpoint response time go from sub-1s to 20s. The batch processor fixed our issue. I also think there were additional issues that are harder to quantify too, fwiw.
    3 replies
    This is paired with the Jaeger collector exporter
    Gene Liverman
    @genebean
    I am using the auto instrumentation of the Sinatra but need to account for url paramters so that /api/v2/status/queue/info/1600289926679 is instead traced as /api/v2/status/queue/info/{job_id} - any tips on how to do this?
    Francis Bogsanyi
    @fbogsany
    The Sinatra instrumentation lacks the quantization callback support from the Rack instrumentation: https://github.com/open-telemetry/opentelemetry-ruby/blob/1c37b00dc82d490dace1f92739977aa4674d7039/instrumentation/rack/lib/opentelemetry/instrumentation/rack/middlewares/tracer_middleware.rb#L122-L137 -- we should add the same functionality to Sinatra. I'll open an issue to track this.
    7 replies
    Eric Mustin
    @ericmustin
    made a graphql instrumentation gem pr....i have been hand-wavy pretending to know what graphql is for the past 4 years, so any and all feedback on this graphql instrumentation is appreciated, as i don't use graphql in my day to day at all . open-telemetry/opentelemetry-ruby#410
    Michael Lang
    @mwlang
    I will sadly miss another week's SIG due to scheduling conflicts, but expect to see everyone next week! In the meanwhile, if there's a good "next issue" I can help with, feel free to point me at it. Otherwise, I'll pluck the next most interesting one to me off the list of open issues.
    3 replies
    Eric Mustin
    @ericmustin
    Hey friends, I am not going to be able to attend the SIG this evening, I have a last min conflict. The Graphql feedback/fixes are still on my radar, have just been a little underwater with some work on the otel-collector they want me to do internally
    related: i'm very bad at Go :crying_cat_face:
    Eric Mustin
    @ericmustin
    :wave: is there anything in spec around identifying an environment? A resource attribute or span attribute perhaps?
    6 replies
    ie: env: test
    Gene Liverman
    @genebean
    I hadn’t noticed that spec but can certainly put it to use so thanks 😀
    Gene Liverman
    @genebean
    Anyone have tips or suggested reading about how to add OTel to a ruby library? I’ve gathered that I should only require the API as opposed to the sdk but don’t really know yet what that looks like in practice.
    2 replies
    Gene Liverman
    @genebean
    Thanks!
    Gene Liverman
    @genebean
    I can’t join the meeting today. My one question is probally the one on every user’s mind: is there a timeline for the 0.7.0 release yet? My main reason for asking is related to the updates to sinatra span names that went in post 0.6.0
    2 replies
    CFPs accepted till Oct11
    Gene Liverman
    @genebean
    Would y’all mind making it so PRs count fir Hacktoberfest? https://hacktoberfest.digitalocean.com/hacktoberfest-update
    For Hacktoberfest that is
    Francis Bogsanyi
    @fbogsany
    Sure
    2 replies
    Francis Bogsanyi
    @fbogsany
    Any concerns if I kick off a release? I think we may have discussed that on the last SIG call, but I don't recall the conclusion.
    4 replies
    Daniel Azuma
    @dazuma
    Looks like the last release went okay. (phew!) Just a note: the release process is now building and pushing the reference docs to github pages. (Links to the various library docs are at https://open-telemetry.github.io/opentelemetry-ruby/)
    Gene Liverman
    @genebean
    Assuming it’s not a big deal to do, once open-telemetry/opentelemetry-ruby#434 gets merged in, would you all mind doing a Z release of the sinatra gem so that I can put it to use?
    16 replies
    Gene Liverman
    @genebean
    I just wanted to circle back and say that the Sinatra bit is working well and has instantly made the trace data more useful as I can now get metrics per endpoint automatically
    1 reply
    Gene Liverman
    @genebean
    Can someone educate me on how to log trace ids generated by OTel ruby?
    10 replies
    Francis Bogsanyi
    @fbogsany

    @dazuma I'm trying to do a release (all:0.8.0), but the "open release pull request" step is failing:

    Error: GitHub check "Test Ruby 2.5 (--include-simple --include-appraisal)" was not successful
    Error: Process completed with exit code 1.

    https://github.com/open-telemetry/opentelemetry-ruby/runs/1316347351

    3 replies
    Francis Bogsanyi
    @fbogsany
    open-telemetry/opentelemetry-ruby#457 and open-telemetry/opentelemetry-ruby#455 -- small chores before release -- :eyes: appreciated
    Gene Liverman
    @genebean
    I am excited about the B3 support :)
    Francis Bogsanyi
    @fbogsany
    3 replies
    Francis Bogsanyi
    @fbogsany
    :loudspeaker: We've cut a new release for OpenTelemetry Ruby: 0.8.0. Key changes include:
    1. Added B3 propagation
    2. Moved context/span manipulation methods to the OpenTelemetry::Trace module (breaking change)
    3. Removed 'canonical' from status codes (breaking change)
    4. Renamed Link.context to Link.span_context to clarify which kind of context is returned
    5. Added gzip support to the OTLP/HTTP exporter
    Daniel Azuma
    @dazuma
    The B3 gem is not quite released yet, but I'm working on it and should have it out in a few minutes.
    Gene Liverman
    @genebean
    Is there an upgrade guide related to the breaking changes?
    Daniel Azuma
    @dazuma
    The remaining gems have now all been released, including the new opentelemetry-propagator-b3.
    Gene Liverman
    @genebean
    @mwear is there any guidance availabe on b3 single vs multi?