Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Mike Goldsmith
    @MikeGoldsmith
    Hi Jack, discussion here is fine :+1:
    Jack Liddiard
    @deadcore
    :ok_hand: Thank's Mike, full disclosure tho I did just find the solution around setting stdout pipeline to print to stderr :flushed: Thank's for the response tho!
    Mark Ingram
    @markdingram

    Hi! I started to toy around with what a nicer API would look like for setting up metric batch observers, here's a proposal -

            let cache_stats: tokio::sync::watch::Receiver<CacheStats> = cache_stats();
            let _batch = meter.batch_observer(move |r: BatchObserver| {
                let hits = r.u64("cache.hits");
                let misses = r.u64("cache.misses");
                move |c: BatchObserverResult| {
                    let stats = cache_stats.borrow();
                    c.observe(
                        &[],
                        &[
                            hits.observation(stats.hits),
                            misses.observation(stats.misses),
                        ],
                    )
                }
            });

    & alternatively without closures where the structs are written out in user code, like Hyper - https://github.com/hyperium/hyper/blob/master/examples/service_struct_impl.rs

    Any feedback would be appreciated as I'm still pretty new to Rust & also to check that this is a direction that would be worth pursuing. Thanks

    Julian Tescher
    @jtescher
    @markdingram yeah the batch observer is still in progress
    Are you contrasting it to https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/metrics/api.md#batch-observer in that you prefer the observer instruments inside the closure?
    (does seem tricky to move values in before they are declared 😬)
    Julian Tescher
    @jtescher
    But yeah, that's the direction that we'd like to get working
    Julian Tescher
    @jtescher
    @markdingram is open-telemetry/opentelemetry-rust#429 similar to what you were looking for?
    Dirkjan Ochtman
    @djc
    @jtescher would be great to get a new release out with tokio 1.0 support
    Julian Tescher
    @jtescher
    ya agreed
    we can probably punt on open-telemetry/opentelemetry-rust#427
    although if we're going to change it sooner is probably better than later
    Dirkjan Ochtman
    @djc
    AFAICT a solution is not super apparent
    Julian Tescher
    @jtescher
    yeah no quick fix there
    Mark Ingram
    @markdingram
    @jtescher yes this looks good! thanks, I'll give it a try
    Dirkjan Ochtman
    @djc
    @jtescher anything I can do to help out with the release?
    Julian Tescher
    @jtescher
    Just need to update all the changelogs and bump the version
    I don't have time currently, but can do later today as well
    Dirkjan Ochtman
    @djc
    ok
    Julian Tescher
    @jtescher
    we could start requiring changelog updates in prs, would make the release process quicker
    Dirkjan Ochtman
    @djc
    hmm, in my own crates I also default to post-hoc changelog maintenance
    but am happy to help out updating changelogs in general
    (although it's a bit late here today)
    Zhongyang Wu
    @TommyCpp
    I can help with changlogs if needed
    Julian Tescher
    @jtescher
    I generally prefer that approach in my personal crates as well
    Zhongyang Wu
    @TommyCpp
    Also +1 on require changlog entry in PRs
    Julian Tescher
    @jtescher
    Happy to merge a PR and update crates.io if someone wants to wrangle all the changelogs and version updates
    Zhongyang Wu
    @TommyCpp
    Have a PR for update and change logs. @jtescher
    Let me know if I missed anything
    Julian Tescher
    @jtescher
    @TommyCpp sorry about the mixup
    figured it was getting late on the east coast
    Zhongyang Wu
    @TommyCpp
    🤣It’s OK I should have commented first before I work on this
    Julian Tescher
    @jtescher
    It'll all get cleaned up when the pr is squashed on merge :grimacing:
    Zhongyang Wu
    @TommyCpp
    👍Yeah I think we are good
    Julian Tescher
    @jtescher
    Zhongyang Wu
    @TommyCpp
    :clap:
    Next issue is what are we gonna do with open-telemetry/opentelemetry-rust#427
    Julian Tescher
    @jtescher
    Yeah may have to protype some alternatives to see if we can improve on the current impl
    Dirkjan Ochtman
    @djc
    awesome work geetting the release out
    it looks like the http removal isn't mentioned in the core crate changelog?
    also it talks about the "api crate removal", but it was the api module and it wasn't exposed publicly
    Jan Kühle
    @frigus02
    Just wanted to say good job all with v0.12. Updating the App Insights exporter was super easy and everything seems to work great :tada:
    Dirkjan Ochtman
    @djc
    should we rename the master branch to main?
    Julian Tescher
    @jtescher
    Probably a good idea
    Can open an issue and ping a tc member to update settings
    Julian Tescher
    @jtescher
    Dirkjan Ochtman
    @djc
    :thumbsup:
    Dirkjan Ochtman
    @djc
    that was pretty quick :)
    Julian Tescher
    @jtescher
    :tada:
    Zhongyang Wu
    @TommyCpp
    Nice GitHub actually gives how to tips to change git settings locally