I have hacked around by adding a Filter to the thrift client service which sends the requests to the primary, candidate, secondary servers and it seems to work - any thoughts on this idea or a better/cleaner approach?
@puneetkhanduri they are plain HTTP services and not Thrift services. Ex. primary - http://svr/prod/svc1 & candidate http://svr/staging/svc1 - so in this case the URL prefix for service ep - svc1 on primary has /prod as the prefix in the URL where as the candidate is deployed to /staging
@/all So there was a ton of feedback I had received on diffy since it was open sourced but never had the time to work on. We ended up starting from scratch and building out isotope. We are rolling it out slowly and accepting applications for free beta access. For a rundown on all the features we built into Isotope, take a look at this tweet storm https://twitter.com/pzdk/status/1045632806691295235
I 1214 08:51:33.381 THREAD1: candidate: name resolution failed
java.lang.IllegalArgumentException: requirement failed: You must specify host and port
java.lang.IllegalArgumentException: requirement failed: You must specify host and port
for all three servers
we have following setup:
candidate: https://qs.ourproduct.com
candidate: https://qs.ourproduct.com
primary: https://stage1.ourproduct.com
secondary: https://stage2.ourproduct.com
and in the run.sh file I have:
java -jar ./target/scala-2.11/diffy-server.jar \
-candidate='https://qs.ourproduct.com:80' \
-master.primary='https://stage1.ourproduct.com:80' \
-master.secondary='https://stage2.ourproduct.com:80' \
-service.protocol='https' \
-serviceName='My Service' \
-proxy.port=:8880 \
-admin.port=:8881 \
-http.port=:8888 \
-https.port=:443 \
-rootUrl='localhost:8888' \
-allowHttpSideEffects=true &\
also tried not having the https part on the hostnames
any clues?
You can upgrade your Diffy instance to Isotope by following these steps: https://github.com/opendiffy/diffy#upgrade-to-isotope. You can then track all your historical results in one place.
Why is the right side always empty？
version: 19.8.28.0
@puneetkhanduri
@puneetkhanduri
@JackieDing @eric-caiyao : Apologies for the delayed response. Let me look into it over the weekend. Please file an issue on github(https://github.com/opendiffy/diffy) and let's follow up there.
Looks like that feature exists on diffy, but it is not available on opendiffy yet
twitter/diffy#48
Are there plans to add it?
under windows
on another note, hoping someone can assist on this: in my tests I'm getting a response larger than the limit and causing a 500. I get " Throw(com.twitter.finagle.http.TooLongMessageException: Response entity too large" on the logs. Looking at a related issue I saw a suggestion to set "com.twitter.finagle.Http.param.MaxRequestSize" when starting the service. Since my error is due to response size I set two parameters when starting diffy, as such: "java -jar -Dcom.twitter.finagle.Http.param.MaxRequestSize=15728640.bytes -Dcom.twitter.finagle.Http.param.MaxResponseSize=15728640.bytes /root/Diffy/diffy-server.jar". Does anyone know how to make Diffy accept a larger response?
Due to the lack of a responseMode I'm still using a quite old version of the openDiffy, before the isotope...
Could this be the reason for those flags not applying?
@sky-eduardolopes : Please verify the latest Opendiffy build works for you and comment on opendiffy/diffy#45
@nickreffitt : Currently, there are no plans to support protobuf in Diffy which behaves purely as a network proxy. We do have a commercial product - Isotope - that supports protobuf via the Isotope sdk integration. What language & framework is your service written in?
it's pretty vanilla - no DI
