Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Krish Verma
    @kvrma_twitter
    I have a use case where due to our infra setup - the webservice is not deploying at the same URLs on the webserver in primary vs. candidate env. they have different URL prefixes to differentiate between prod/staging/dev env.
    I have hacked around by adding a Filter to the thrift client service which sends the requests to the primary, candidate, secondary servers and it seems to work - any thoughts on this idea or a better/cleaner approach?
    Krish Verma
    @kvrma_twitter
    @puneetkhanduri :point_up_2:
    Puneet Khanduri
    @puneetkhanduri
    @kvrma_twitter I am not sure what you mean by URL prefixes in the context of Thrift services. Can you share an example?
    Krish Verma
    @kvrma_twitter
    @puneetkhanduri they are plain HTTP services and not Thrift services. Ex. primary - http://svr/prod/svc1 & candidate http://svr/staging/svc1 - so in this case the URL prefix for service ep - svc1 on primary has /prod as the prefix in the URL where as the candidate is deployed to /staging
    Puneet Khanduri
    @puneetkhanduri
    @/all So there was a ton of feedback I had received on diffy since it was open sourced but never had the time to work on. We ended up starting from scratch and building out isotope. We are rolling it out slowly and accepting applications for free beta access. For a rundown on all the features we built into Isotope, take a look at this tweet storm https://twitter.com/pzdk/status/1045632806691295235
    sky-eduardolopes
    @sky-eduardolopes
    hi, I am getting:
    I 1214 08:51:33.381 THREAD1: candidate: name resolution failed
    java.lang.IllegalArgumentException: requirement failed: You must specify host and port
    for all three servers
    we have following setup:
    candidate: https://qs.ourproduct.com
    and in the run.sh file I have:
    java -jar ./target/scala-2.11/diffy-server.jar \
        -candidate='https://qs.ourproduct.com:80' \
        -master.primary='https://stage1.ourproduct.com:80' \
        -master.secondary='https://stage2.ourproduct.com:80' \
        -service.protocol='https' \
        -serviceName='My Service' \
        -proxy.port=:8880 \
        -admin.port=:8881 \
        -http.port=:8888 \
        -https.port=:443 \
        -rootUrl='localhost:8888' \
        -allowHttpSideEffects=true &\
    also tried not having the https part on the hostnames
    any clues?
    sanlengjingvv
    @sanlengjingvv
    Is there a way to save diffy result then view in another server?
    Puneet Khanduri
    @puneetkhanduri
    You can upgrade your Diffy instance to Isotope by following these steps: https://github.com/opendiffy/diffy#upgrade-to-isotope. You can then track all your historical results in one place.
    eric-caiyao
    @eric-caiyao
    image.png
    Why is the right side always empty?
    version: 19.8.28.0
    @puneetkhanduri
    JackieDing
    @JackieDing
    @eric-caiyao Hi! I have the same problem as you. Have you solved it?
    @puneetkhanduri
    Puneet Khanduri
    @puneetkhanduri
    @JackieDing @eric-caiyao : Apologies for the delayed response. Let me look into it over the weekend. Please file an issue on github(https://github.com/opendiffy/diffy) and let's follow up there.
    JackieDing
    @JackieDing
    @puneetkhanduri thank you !
    Betim Deva
    @betimdeva
    Hi, I am experimenting with opendiffy and noticed that diffy doesn't propagate the response from the primary master to the caller. Am I missing anything?
    Betim Deva
    @betimdeva

    Looks like that feature exists on diffy, but it is not available on opendiffy yet
    twitter/diffy#48

    Are there plans to add it?

    eric-caiyao
    @eric-caiyao
    Has anyone ever encountered this problem?
    image.png
    under windows
    eric-caiyao
    @eric-caiyao
    ignore , unvalid params.
    lizhenwei
    @lizhenwei
    I'm a fresh diify user . how to registry in SN126 and get local.isotope,can anybody help me?
    lizhenwei
    @lizhenwei
    hi ,opendiffy/diffy#28 . how to enabel responseMode ?in docker run flag ?
    sky-eduardolopes
    @sky-eduardolopes
    @puneetkhanduri kudos on the responseMode commit, that's a most useful feature! Thank you
    sky-eduardolopes
    @sky-eduardolopes
    on another note, hoping someone can assist on this: in my tests I'm getting a response larger than the limit and causing a 500. I get " Throw(com.twitter.finagle.http.TooLongMessageException: Response entity too large" on the logs. Looking at a related issue I saw a suggestion to set "com.twitter.finagle.Http.param.MaxRequestSize" when starting the service. Since my error is due to response size I set two parameters when starting diffy, as such: "java -jar -Dcom.twitter.finagle.Http.param.MaxRequestSize=15728640.bytes -Dcom.twitter.finagle.Http.param.MaxResponseSize=15728640.bytes /root/Diffy/diffy-server.jar". Does anyone know how to make Diffy accept a larger response?
    Puneet Khanduri
    @puneetkhanduri
    @sky-eduardolopes : thanks for your kind words. The flags you are already setting should be sufficient if your payload is less than 15 MB. Can you confirm the size of your payload?
    sky-eduardolopes
    @sky-eduardolopes
    Content-Length: 6454768
    Due to the lack of a responseMode I'm still using a quite old version of the openDiffy, before the isotope...
    Could this be the reason for those flags not applying?
    sky-eduardolopes
    @sky-eduardolopes

    Due to the lack of a responseMode I'm still using a quite old version of the openDiffy, before the isotope...

    actually one that I patched with theresponseMode commit from twitter/diffy

    sky-eduardolopes
    @sky-eduardolopes
    FYI I had asked on the finagle gitter before asking here and this is what they told me:
    "those are Stack params which are not read from System properties. They’re generally set as code via the Finagle client"
    Puneet Khanduri
    @puneetkhanduri
    @sky-eduardolopes : Please verify the latest Opendiffy build works for you and comment on opendiffy/diffy#45
    Nick Reffitt
    @nickreffitt
    Hello, are there plans to support Protocol Buffers ?
    Puneet Khanduri
    @puneetkhanduri
    @nickreffitt : Currently, there are no plans to support protobuf in Diffy which behaves purely as a network proxy. We do have a commercial product - Isotope - that supports protobuf via the Isotope sdk integration. What language & framework is your service written in?
    Nick Reffitt
    @nickreffitt
    Thanks for getting back to me, it's written in Java - we have a mixture of Protobuf and JSON endpoints in the same service
    Puneet Khanduri
    @puneetkhanduri
    Cool. What framework are you using in Java? e.g. Spring Boot, JAX-RS?
    Nick Reffitt
    @nickreffitt
    Netty for the web framework - no Spring/JAX-RS sadly
    it's pretty vanilla - no DI
    Puneet Khanduri
    @puneetkhanduri
    We may be able to help depending on how you have written your netty handlers. We would need to see some sample code. You have my email so let me know if you want to jump on a call.
    Akhil Reddy Mandadi
    @akhilmandadi
    Hi @puneetkhanduri, We would like to use isotope for test protobufs, but seems like our organization is not registered on your end right now. How can we move forward?