These are chat archives for openseadragon/openseadragon

29th
Jun 2015
VoidVolker
@VoidVolker
Jun 29 2015 13:59 UTC
hi! how to make overlay work with looped world?
I used option for map wrapHorizontal: true - but overlay not wraped
Ian Gilman
@iangilman
Jun 29 2015 15:52 UTC
@VoidVolker Unfortunately we don't support wrapping the overlays yet. Feel free to file an issue and/or propose a patch!
Conner Wingard
@ConnerMan
Jun 29 2015 17:44 UTC
Hey @iangilman I addressed your suggestions about #673. Let me know if the changes make sense
Ian Gilman
@iangilman
Jun 29 2015 17:45 UTC
@ConnerMan Awesome...will do :)
Conner Wingard
@ConnerMan
Jun 29 2015 17:58 UTC
Any reason the Navigator tests seem to fail sometimes and pass others?
Ian Gilman
@iangilman
Jun 29 2015 17:59 UTC
Is this in browser or in the terminal?
Conner Wingard
@ConnerMan
Jun 29 2015 18:00 UTC
I've seen it happen in the browser, but the Travis CI build just failed on them too
Ian Gilman
@iangilman
Jun 29 2015 18:01 UTC
Hmm :(
I think there is a known issue with them in Firefox, but I haven't seen them failing in Travis
@avandecreme Any thoughts? You wrote them, right?
Mark Salsbery
@msalsbery
Jun 29 2015 18:02 UTC
They should work in all supported browsers as far as I know
Conner Wingard
@ConnerMan
Jun 29 2015 18:02 UTC
Possible I broke them :worried:
Antoine Vandecreme
@avandecreme
Jun 29 2015 18:03 UTC
iangilman: I believe msalsbery wrote them
Mark Salsbery
@msalsbery
Jun 29 2015 18:04 UTC
I extended them for positioning
Ian Gilman
@iangilman
Jun 29 2015 18:04 UTC
Oh, sorry :)
Mark Salsbery
@msalsbery
Jun 29 2015 18:07 UTC
Which tests are failing?
Looks like navigator - CustomDialogNavigatorElementWithTallImageTallViewer
Mark Salsbery
@msalsbery
Jun 29 2015 18:11 UTC
That's an old one from before my time...should work :)
The numbers are pretty far off. I would first make sure the tests don't assume square tiles anywhere.
Mark Salsbery
@msalsbery
Jun 29 2015 18:19 UTC
...and I think that test was one I wrote ("after resize")
Conner Wingard
@ConnerMan
Jun 29 2015 19:33 UTC
I made a tweak (reverting changes to IIIFTileSource that are no longer needed with new approach) and now #673 is passing.
Ian Gilman
@iangilman
Jun 29 2015 20:53 UTC
Funky. Doesn't seem related. Perhaps we have an intermittent failure. :( @ConnerMan
@gechols The build failure on https://travis-ci.org/openseadragon/openseadragon/builds/68849462 looks related to the one on your patch.
Conner Wingard
@ConnerMan
Jun 29 2015 20:55 UTC
@iangilman Yeah, not sure. But I looked through navigator code, and it doesn't seem to directly interact with tileSize in any way.
Ian Gilman
@iangilman
Jun 29 2015 20:56 UTC
We're seeing a similar fail here on #666, which is an unrelated patch
I don't see anything in recent PRs that seems like it would have introduced an intermittent issue... https://github.com/openseadragon/openseadragon/pulls?q=is%3Apr+is%3Aclosed