These are chat archives for openseadragon/openseadragon

9th
Oct 2015
Antoine Vandecreme
@avandecreme
Oct 09 2015 02:28
I think you misread that as the drawer's code. This is the overlays code, they are always rendered in HTML :)
Ian Gilman
@iangilman
Oct 09 2015 16:15
@avandecreme Ah so, good point! In that case, it's probably just copied from the old HTML renderer code...rounding is in fact probably a better choice for overlays. Good spotting. Do you want to make a patch?
Antoine Vandecreme
@avandecreme
Oct 09 2015 17:23
Ok, I will.
Ian Gilman
@iangilman
Oct 09 2015 17:24
Awesome :)
Antoine Vandecreme
@avandecreme
Oct 09 2015 17:56
Hum, we should probably add a BREAKING CHANGE in the changelog about TileSource.tileSize not existing anymore
Ian Gilman
@iangilman
Oct 09 2015 20:28
@avandecreme Good point. Just in master so far, right? Are you testing that page with pre-release code?
Ian Gilman
@iangilman
Oct 09 2015 20:33
Done: openseadragon/openseadragon@808442e
Antoine Vandecreme
@avandecreme
Oct 09 2015 20:41
Yes I submitted a fix
Ian Gilman
@iangilman
Oct 09 2015 20:42
Excellent, thank you. Just making sure it's pre-release. We can land the fix when we release 2.1.0
(which I keep slacking on doing)
Antoine Vandecreme
@avandecreme
Oct 09 2015 20:44
Making a release always take more time than you expect, so I understand ^_^
Ian Gilman
@iangilman
Oct 09 2015 20:44
:)