24th
Nov 2015
Matthias Guth
@ChiSamurai
Nov 24 2015 09:21
Hm... I have to confess that I'm not that familiar with the internal calculation of the different coordinate systems. But I think there could appear problems when transforming coordinates from one coordinate system to another and then once more. the rotation must not affect the second transformation because the point was already rotated in the first transformation. So... rotation of the coordinates should somehow be done once. Maybe indeed a flag "isRotated" would be a solution?!
Matthias Guth
@ChiSamurai
Nov 24 2015 12:57
or something like \$.Point.rotationApplied ?
Antoine Vandecreme
@avandecreme
Nov 24 2015 14:34
I think the rotation should always be applied when going from element to viewport and viewport to element. Adding the logic inside pointFromPixel and pixelFromPoint should do the trick because all the elementToViewport and windowToViewport are using those methods underneath IIRC.
There might be some problems with the corresponding methods working on rectangles though.
Ian Gilman
@iangilman
Nov 24 2015 16:59
Indeed...we want to be careful with double applying the rotation.
As for rectangles, that is tricky, because we don't have a rotated rectangle object to return
It does seem to me like all of the API-facing functions don't really have any reason not to take rotation into account (except the above concerns)
Ian Gilman
@iangilman
Nov 24 2015 17:48
VoidVolker
@VoidVolker
Nov 24 2015 18:00
wow
Antoine Vandecreme
@avandecreme
Nov 24 2015 18:01
Maybe we could modify the rectangle class to allows rotated rectangles.
VoidVolker
@VoidVolker
Nov 24 2015 18:01
what that? what it do?
Antoine Vandecreme
@avandecreme
Nov 24 2015 18:01
That might be useful to handle rotation and overlays as well.
VoidVolker
@VoidVolker
Nov 24 2015 18:02
dynamically generate OSD instance an load there any image?
Antoine Vandecreme
@avandecreme
Nov 24 2015 18:02
VoidVolker: yes :)
VoidVolker
@VoidVolker
Nov 24 2015 18:02
it just for fun?
what for it need?
Antoine Vandecreme
@avandecreme
Nov 24 2015 18:03
I personnaly miss the capability to zoom and pan in the browsers
when you visualize big images
VoidVolker
@VoidVolker
Nov 24 2015 18:04
yes, make sense, if you need often to view big images in network
o, I know use case
Ian Gilman
@iangilman
Nov 24 2015 18:04
Much nicer than the zoom that's built into the browser
VoidVolker
@VoidVolker
Nov 24 2015 18:05
nasa have site with big images of space
Ian Gilman
@iangilman
Nov 24 2015 18:05
Indeed :)
VoidVolker
@VoidVolker
Nov 24 2015 18:05
but there no viewer