These are chat archives for openseadragon/openseadragon

12th
Feb 2016
Antoine Vandecreme
@avandecreme
Feb 12 2016 00:00
@iangilman any idea why getHomeBounds does not simply return this.homeBounds here: https://github.com/openseadragon/openseadragon/blob/master/src/viewport.js#L235
VoidVolker
@VoidVolker
Feb 12 2016 00:10
@iangilman looks cool =)
Ian Gilman
@iangilman
Feb 12 2016 00:36
@avandecreme @dwrogers @VoidVolker Thanks!
@avandecreme Looks like this.homeBounds is the shape of the content and getHomeBounds is the aspect ratio of the viewer
So maybe this.homeBounds would more accurately be this.contentBounds
Antoine Vandecreme
@avandecreme
Feb 12 2016 00:40
should we rename that somehow? Might break things...
Ian Gilman
@iangilman
Feb 12 2016 00:41
Well, it's undocumented, so it's probably reasonable to rename it. I'd still add something to the changelog just in case
Antoine Vandecreme
@avandecreme
Feb 12 2016 00:42
alright
Ian Gilman
@iangilman
Feb 12 2016 00:43
setHomeBounds is documented, and it basically sets homeBounds (plus some other stuff)...
Antoine Vandecreme
@avandecreme
Feb 12 2016 00:43
ha was gonna ask about it
it is really setContentBounds though
or not?
I get lost :D
Ian Gilman
@iangilman
Feb 12 2016 00:44
Looks like it
So maybe it needs to be renamed (and the old function can have a deprecation warning and call the new one)
Antoine Vandecreme
@avandecreme
Feb 12 2016 00:46
makes sense. Maybe go private too, I can't see a good reason for the user to call that
Ian Gilman
@iangilman
Feb 12 2016 00:48
Agreed. We can always expose it later if it becomes apparent
Best to stay private until needed
Antoine Vandecreme
@avandecreme
Feb 12 2016 00:56
According to the changelog it has been introduced in 2.0.0, so not that long ago. Hopefully no one uses it.
Ian Gilman
@iangilman
Feb 12 2016 00:56
Cool
Antoine Vandecreme
@avandecreme
Feb 12 2016 01:19
I made a PR for the renaming. I am done coding for today :)
Ian Gilman
@iangilman
Feb 12 2016 01:30
Cool :)
foobarable
@foobarable
Feb 12 2016 06:50
Hi there, I want to use openseadragon for a scientific project where we have 30tb images in the zoomify format. I've come far with defining an inline custom tile source. The problem is, that
ups
too early for chat :/
i still need to find out how to define which tiles are requested from osd
my pyramid looks like this: level 0: 1 tile, level 1: 4 tiles, level 2: 6,8,9,12 or 16 tiles (depending on the size and dimension ratios)
and so on..
With some advise I also could provide a zoomify tile source plugin
foobarable
@foobarable
Feb 12 2016 07:08
my current lead is to overload tileExists: function (level, x, y) in my static definition as well
is this a good solution?
foobarable
@foobarable
Feb 12 2016 12:41
It also seems so that i have tiles different to the default tile size at the right and bottom border of the image
openseadragon scales the tile then. this is not good behaviour :/
foobarable
@foobarable
Feb 12 2016 15:38
maybe this is the solution for my problem as well: openseadragon/openseadragon#690 (the clip parameter)
David Rogers
@dwrogers
Feb 12 2016 18:14
@avandecreme I missed this question yesterday: "What [OpenSlide multilayer]support would do?"
OpenSlide only returns the central focus plane for any image format that has multiple focal planes, e.g., .ndpi. Ideally, it would learn how to handle multiple focal planes. This would include capturing and exposing the metadata about the various levels and adding a way to select a level.
There is a comment on the site indicating that they are in need of sample images with multiple focal planes, and I am in the process of getting some of those which can be freely redistributed.
Antoine Vandecreme
@avandecreme
Feb 12 2016 18:20
@foobarable I am not sure what is your problem. Have you been able to implement a custom tile source?
@dwrogers I got it I think thanks.
David Rogers
@dwrogers
Feb 12 2016 23:35
Is there a jsdoc build product? Or is there a place where I can see the jsdoc output?
David Rogers
@dwrogers
Feb 12 2016 23:47
Pretty simple, actually: from the openseadragon directory, run: node_modules.bin\jsdoc build\openseadragon\openseadragon.js