These are chat archives for openseadragon/openseadragon

16th
Feb 2016
foobarable
@foobarable
Feb 16 2016 08:42 UTC
avandecreme
This message was deleted
foobarable
@foobarable
Feb 16 2016 12:32 UTC
@avandecreme I could show you the problem on the website. The problem is, i can't offer a direct link yet so you have to do some clicks before: Steps to reproduce: 1) visit https://gp3.mpg.de 2) Search for "BA10" 3) Add the set to the cart/selection, 4) Click on selection in the menu 5) Click on the small image icon on the first image.
zoom
Antoine Vandecreme
@avandecreme
Feb 16 2016 16:50 UTC
ok, so the issue is with the tiles in the borders, right?
@foobarable ^
Antoine Vandecreme
@avandecreme
Feb 16 2016 16:56 UTC
I think you should make a simple example outside of angular. I can't see your source code right now.
Ian Gilman
@iangilman
Feb 16 2016 17:15 UTC
@msalsbery I'd love event improvement contributions to svg-overlay as well!
@dwrogers OSD's built-in overlays don't scale their content as you zoom (giving the effect @sickrandir is looking for) whereas svg-overlay scales everything, so it's like the overlays are part of the image. The fabric overlay is good for interactive drawing as @altert says, and his canvas overlay would be probably the most low level, where you want fine control over every pixel drawn in your overlay
David Rogers
@dwrogers
Feb 16 2016 17:46 UTC
@msalsbery "grunt doc" was what I was looking for. Thanks!
Ian Gilman
@iangilman
Feb 16 2016 17:47 UTC
@dwrogers Just keep in mind that it's in the site-build repository; if you're working with the openseadragon repository, you'll have to grunt publish it into the site-build before doing grunt doc
David Rogers
@dwrogers
Feb 16 2016 17:48 UTC
Grunt responded: "Eh <crunch><crunch>.... Whats doc, doc."
Ian Gilman
@iangilman
Feb 16 2016 17:49 UTC
Yup, if you did it in the openseadragon repository
David Rogers
@dwrogers
Feb 16 2016 17:49 UTC
Never mind. It's a different repo. Gotta read the whole message...
Ian Gilman
@iangilman
Feb 16 2016 17:50 UTC
Just to verify: do you just want the docs for the latest release? If so, those are online. You only need to build if you are writing new docs and want to test them
David Rogers
@dwrogers
Feb 16 2016 17:51 UTC
@iangilman I need to learn how to use jsdocs so I can understand and contribute.
Ian Gilman
@iangilman
Feb 16 2016 17:52 UTC
Cool, just making sure :)
One approach is to just edit openseadragon.js in site-build directly and experiment there
David Rogers
@dwrogers
Feb 16 2016 17:59 UTC
@msalsbery @altert @iangilman Thanks for the comments on the various overlays!
David Rogers
@dwrogers
Feb 16 2016 18:22 UTC
@msalsbery @altert @iangilman Thanks for the comments on the various overlays!
Ian Gilman
@iangilman
Feb 16 2016 18:24 UTC
:)
Mark Salsbery
@msalsbery
Feb 16 2016 18:41 UTC
@iangilman So would I... ;)
Ian Gilman
@iangilman
Feb 16 2016 18:41 UTC
:P
Mark Salsbery
@msalsbery
Feb 16 2016 18:44 UTC
:squirrel:
Alexey Tikhonov
@altert
Feb 16 2016 19:52 UTC
hmm that ZoomTo("OverlayId") seems like an nice function to have. It would need to be dependant on overlay size though, I guess?
referring to #838
Ian Gilman
@iangilman
Feb 16 2016 21:02 UTC
@altert Absolutely
I think it would be more generally useful to be able to get the bounds of an overlay in viewport coordinates. You could then pass that directly into fitBounds or manipulate it somehow (like zooming out a little) before passing it
It looks like overlays already have a .bounds property (though it might be good to provide a getBounds method), so I think the big piece that's missing is being able to get an overlay by passing its ID
Something like Viewer.getOverlayById(id)
Alexey Tikhonov
@altert
Feb 16 2016 21:14 UTC
yes, I've created such function in one application using fabricoverlay, to be able to get overlay and connected fabric objects by id
but that was external to osd, could be nice to have it inside it as well of course
Ian Gilman
@iangilman
Feb 16 2016 21:21 UTC
Agreed! Would you be up for making a patch?
Alexey Tikhonov
@altert
Feb 16 2016 21:22 UTC
I'll experiment at least, and see where it's going)
Ian Gilman
@iangilman
Feb 16 2016 21:22 UTC
Excellent :)
Alexey Tikhonov
@altert
Feb 16 2016 21:24 UTC
small question: as navigator is just somewhat specialized viewer, I guess making two syncronized (or kind of semi-syncronized, i.e. map and book) viewers shouldn't be too hard?
Ian Gilman
@iangilman
Feb 16 2016 21:29 UTC
@altert Yes, that's exactly what the navigator is, for instance
(more or less)