These are chat archives for openseadragon/openseadragon

19th
Feb 2016
foobarable
@foobarable
Feb 19 2016 10:12
@iangilman Yeah, Ill open a pull request. Also, could you look into my code and see if I fulfill your coding guidelines? Im also not sure if I placed my two additional methods there correctly.
But we can discuss this in the pull request then
sickrandir
@sickrandir
Feb 19 2016 10:51
Hi guys, do you know if this module is up-to-date and working with the latest version of OSD? https://github.com/MaitreDede/angular-openseadragon
sickrandir
@sickrandir
Feb 19 2016 11:01
@avandecreme thank you for the suggestion to use a OSD native point overlay. That is exactly what I was looking for!
foobarable
@foobarable
Feb 19 2016 12:15
@sickrandir Im using it and it seems to work fine
@sickrandir You have to modify it a little if you want other plugins
@iangilman http://libvips.blogspot.de/2013/03/making-deepzoom-zoomify-and-google-maps.html heres a documentation on howto create zoomify images
sickrandir
@sickrandir
Feb 19 2016 13:18
@foobarable Thank you, I'll give it a go then! Would you consider pushing your modifications to use multiple plugins to the repo?
foobarable
@foobarable
Feb 19 2016 13:45
@sickrandir it's not my repo and i made small, dirty modifications ;)
sickrandir
@sickrandir
Feb 19 2016 13:53
@foobarable oook. so I guess I'll do some small, dirty modification too ;-)
Ian Gilman
@iangilman
Feb 19 2016 17:07
@foobarable Sounds good! We're already linking to that article from http://openseadragon.github.io/examples/creating-zooming-images/ but once you've added zoomify support we can update that page to mention it there
Alexey Tikhonov
@altert
Feb 19 2016 21:36
@iangilman I have a question about one of your notes
you said that @return {OpenSeadragon.Overlay} is incorrect in getOverlayById
Ian Gilman
@iangilman
Feb 19 2016 21:36
Ok
Alexey Tikhonov
@altert
Feb 19 2016 21:38
I think I'm missing something there)
Ian Gilman
@iangilman
Feb 19 2016 21:38
Oh yeah, sorry...I guess that part is correct...I just saw the "Chainable"
Alexey Tikhonov
@altert
Feb 19 2016 21:38
ah! then I get it
Ian Gilman
@iangilman
Feb 19 2016 21:38
Chainable should be removed...it means that it returns this so you can chain calls like in jQuery
...some of the OSD calls have that, but we're moving away from it because I don't think it adds anything to this API and in fact paints us into corners
Alexey Tikhonov
@altert
Feb 19 2016 21:39
yes. I thought I was missing something there
Ian Gilman
@iangilman
Feb 19 2016 21:40
Instead of "chainable" you could say something like "the matching overlay or null if none found"
Alexey Tikhonov
@altert
Feb 19 2016 21:40
chainable maybe makes sense for methods dealing with viewport? zoomBy etc
Ian Gilman
@iangilman
Feb 19 2016 21:40
I know it's kind of redundant...
Yeah, I suppose it might make more sense with the viewport, though in practice it's probably not a good idea...for instance you might think you could do viewport.panTo().zoomBy() and everything would work out great but the results are subpar (due to the asynchronous nature) compared to just calling fitBounds
Anyway, sorry for the confusing comment! :)
Alexey Tikhonov
@altert
Feb 19 2016 21:42
no problem. your comments are very helpful
working with OSD is making my javascript better, actually)
Ian Gilman
@iangilman
Feb 19 2016 22:38
Awesome :)