These are chat archives for openseadragon/openseadragon

9th
Mar 2016
sickrandir
@sickrandir
Mar 09 2016 11:34
@iangilman built master, it's available here: https://d3q1sz07sa4p57.cloudfront.net/js/osd/20160309/openseadragon.js
however it doesn't seem to work wheter I put tabIndex = 0, tabIndex = '' or nothing in the options
the jump at the first click is still there on chrome
Ian Gilman
@iangilman
Mar 09 2016 17:01
@sickrandir What you have there is not the latest...make sure you pull down the latest master before building.
(or maybe your CDN has the old one cached)
David Rogers
@dwrogers
Mar 09 2016 17:25
@iangilman the pen you gave me uses something other than the lastest master build - is that version available somewhere?
Ian Gilman
@iangilman
Mar 09 2016 17:28
@dwrogers If you want the latest master you have to build it yourself. We don't have any sort of "nightly" build or anything.
David Rogers
@dwrogers
Mar 09 2016 17:39
@iangilman Roger. So if I wanted to do a codepen then I would just include openseadragon.js as in http://codepen.io/anyoneis/pen/PNNaJb?
It looks to me that #852 et.al. is not an issue in the master branch.
sickrandir
@sickrandir
Mar 09 2016 17:41
@iangilman totally right! I had messed up with the CDN. It's working now with tabIndex = ''
thanx a lot!!
Ian Gilman
@iangilman
Mar 09 2016 17:41
@sickrandir Excellent :)
@dwrogers Interesting...I guess you totally could just drop all of OSD into the pen!
Ian Gilman
@iangilman
Mar 09 2016 17:47
There has been a lot of work around rotation since the latest release, so I'm not surprised if some issues have been fixed without updating the tickets.
Antoine Vandecreme
@avandecreme
Mar 09 2016 18:34
@dwrogers did you test rect overlays rotation as well?
David Rogers
@dwrogers
Mar 09 2016 18:35
@avandecreme Yep, but the news is not so good there.
Antoine Vandecreme
@avandecreme
Mar 09 2016 18:36
ok
I guess some users might expect the overlays to rotate with the viewport as well. So we might need to introduce an option for that.
David Rogers
@dwrogers
Mar 09 2016 18:37
I have updated the pen to add a regular overlay.
David Rogers
@dwrogers
Mar 09 2016 18:43
@avandecreme Instead of relying on "scales"? it looks to me as if "scales" really means "under viewport control," is that right?
Antoine Vandecreme
@avandecreme
Mar 09 2016 19:47
sorry, what is the context about "scales"?
David Rogers
@dwrogers
Mar 09 2016 19:48
Overlay.scales - set if we pass in a Rect rather than a Point.
to addOverlay (sp?)
Antoine Vandecreme
@avandecreme
Mar 09 2016 19:52
which file?
David Rogers
@dwrogers
Mar 09 2016 19:53
Overlay.js - line 111 - this.scales = options.location instanceof $.Rect;
Antoine Vandecreme
@avandecreme
Mar 09 2016 19:54
ha, scales means that the overlays need to be scaled by OSD
otherwise, it just uses the default size of the element
so yes
:)
David Rogers
@dwrogers
Mar 09 2016 19:55
Right, but it also controls rotation in the current code. perhaps rotation needs to be a separate option.
Antoine Vandecreme
@avandecreme
Mar 09 2016 19:56
yeah, not sure why it is in the test
maybe just because Rect rotation have never been supported
hum actually that seems correct
except that the size/position computation is probably wrong
David Rogers
@dwrogers
Mar 09 2016 20:00
Yep. That's my target.
Antoine Vandecreme
@avandecreme
Mar 09 2016 20:02
hopefully, the position computation will be simpler now
also I am wondering whether point and rect overlays should be separated in 2 classes
would make the code more readable I think
David Rogers
@dwrogers
Mar 09 2016 20:03
I plan on looking at the changes to the point overlays to inform my changes for rect overlays.
It seems like they are different animals....