These are chat archives for openseadragon/openseadragon

5th
Sep 2016
John Susi
@johnsusi
Sep 05 2016 10:07
anyone using the event 'fully-loaded-changed'?
Ian Gilman
@iangilman
Sep 05 2016 16:15
@johnsusi I do (and I wrote it). Are you using it as well?
John Susi
@johnsusi
Sep 05 2016 16:16
yeah, I just switch from the old PR (that had 'fully-loaded') to the new api but now I get that event very early on, long before any tiles have been loaded
Ian Gilman
@iangilman
Sep 05 2016 16:17
Interesting. I wonder if it has to do with #1014
I'm just taking a look at #1025 now
#1025 looks like a good fix
John Susi
@johnsusi
Sep 05 2016 16:19
what I'm doing is calling addTiledImage and in the success-handler i call addOnceHandler('fully-loaded-changed')
the event fires and getFullyLoaded reports true
Ian Gilman
@iangilman
Sep 05 2016 16:19
Cool, I'll check it out
Is that with #1025 in place?
John Susi
@johnsusi
Sep 05 2016 16:20
yeah, latest master with 1025
Ian Gilman
@iangilman
Sep 05 2016 16:20
Have you tried without #1025?
John Susi
@johnsusi
Sep 05 2016 16:21
will do, just wondered if my usage was correct
Ian Gilman
@iangilman
Sep 05 2016 16:21
Yeah, the usage should be correct
John Susi
@johnsusi
Sep 05 2016 16:21
great
about 1025, i haven't tested much outside of my own usage scenario
might break things ;-)
Ian Gilman
@iangilman
Sep 05 2016 16:23
Fair enough. It seems like the right direction though
Ian Gilman
@iangilman
Sep 05 2016 16:30
Yeah, #1025 would short circuit this check: https://github.com/openseadragon/openseadragon/blob/master/src/tiledimage.js#L948 ... which is how "Fully loaded" is determined
There needs to be an additional "Are there any tiles currently being loaded" flag there
@johnsusi ^
Can you make that fix in your patch?
John Susi
@johnsusi
Sep 05 2016 16:42
ill have a look
Ian Gilman
@iangilman
Sep 05 2016 16:53
@johnsusi Excellent, thank you. I've had some more thoughts and added them to the ticket
John Susi
@johnsusi
Sep 05 2016 16:56
good points. I was worried something like that could be a problem.
Ian Gilman
@iangilman
Sep 05 2016 16:57
:) There's a lot to think about in there!
John Susi
@johnsusi
Sep 05 2016 16:59
let me know when you want to do a total rewrite ;-)
Ian Gilman
@iangilman
Sep 05 2016 17:00
:)
I'm not against it! It just needs to work as well as the old version
John Susi
@johnsusi
Sep 05 2016 17:07
:)