These are chat archives for openseadragon/openseadragon

19th
Oct 2016
John Hoffer
@thejohnhoffer
Oct 19 2016 14:41
@iangilman , TLDR; I'm not seeing the focus indicator at all when using the site with just a keyboard. but I think we should have a focus indicator for that purpose. If people's asthetic sensibilities are offended, we could perhaps disable the focus indicator only when the viewport is being used with a mouse. If we had the indicator on for container:focus but off for container:hover, then people who never use the keyboard should only see the indicator when leaving, and people who never use the mouse should always see the indicator.
.openseadragon-canvas:focus:not(:hover) + div + div {
background-color: rgba(0, 0, 0, 0.8) !important;
padding: .5em .5em 0em 1em !important;
font-size: xx-large;
transition: .5s;
height: 3em;
width: 8em;
}
.openseadragon-canvas:focus:not(:hover) + div + div:after {
content: 'WASD moves \A ⇧WS zooms';
white-space: pre;
color: white;
}
Ian Gilman
@iangilman
Oct 19 2016 16:39
@thejohnhoffer I like it! I've responded in the issue...
John Hoffer
@thejohnhoffer
Oct 19 2016 18:32
What is the expected behavior for a custom tilesource where the total tiled image size is not an even multiple of the tileSize?
Ian Gilman
@iangilman
Oct 19 2016 21:01
@thejohnhoffer As with the DZI, I think we always expect the right column of tiles and the bottom row of tiles to have tiles smaller than the rest.
John Hoffer
@thejohnhoffer
Oct 19 2016 22:07
That happens correctly in the most recent release, but it doesn't work for me on more recent builds from the master branch. I've found that I can see that the error only happens when built from the master after openseadragon/openseadragon@0b28b5f
Ian Gilman
@iangilman
Oct 19 2016 22:08
Interesting... but it's a custom tile source not a DZI?
John Hoffer
@thejohnhoffer
Oct 19 2016 22:08
That's right...
It's not making sense, but I've double checked. I'll send you a gif
Ian Gilman
@iangilman
Oct 19 2016 22:08
Strange that that change would affect anything other than DZI
Cool
What happens if you change those four lines back? Does everything work again?
John Hoffer
@thejohnhoffer
Oct 19 2016 22:10
Let me try.
I've just swapped out minnified builds from those two commits, but I'll swap out the full builds and make sure the don't differ by any other lines.
John Hoffer
@thejohnhoffer
Oct 19 2016 22:15
So there are more differences between the builds from those two commits. I'm new to this so I don't understand why that would be the case, but I can send you the diffs.
Ian Gilman
@iangilman
Oct 19 2016 22:16
Interesting... sure
John Hoffer
@thejohnhoffer
Oct 19 2016 22:21
thejohnhoffer/2016-08-OSD-Diffs@adee57e
Odd that the earlier verison starts with 2.2.0 and the later version starts with 2.2.1. I coppied the commit hashes from August 01 and August 04 in full, but I thought both should be at least version 2.2.2 based on earlier commit messages.
...which is part of openseadragon/openseadragon#987 by @VoidVolker
@thejohnhoffer It would be helpful to see your custom tile source code. Perhaps you could file an issue and include that and tag @VoidVolker and I?
Of course you can verify that that's the code change by manually reverting that little block
Or maybe reverting all of #987 if you want
John Hoffer
@thejohnhoffer
Oct 19 2016 22:29
Sure, I can do both those things right now.
Yep- swapping out the old getTileAtPointinto the new openseadragon.js makes the behavior return to normal. Thank you!
I'll file a issue with those details.
Ian Gilman
@iangilman
Oct 19 2016 22:32
Cool... looks like you found an edge case @VoidVolker didn't consider. Thank you for catching it and filing an issue!
Would you be up for making a patch once we get to the bottom of why the new code doesn't work in your case?
John Hoffer
@thejohnhoffer
Oct 19 2016 22:37
Sure- right now I don't understand why this small code change should cause this behavior in my case. When we figure that out, I'll be happy to make a pull request to fix it. Are 0d9e2e8 and 0b28b5f the correct before and after commit hashes to include for reference in the issue I file? I'll be sure to put a reference to issue #987.
Ian Gilman
@iangilman
Oct 19 2016 22:39
Hmm, I don't know about the commit numbers, but if that's the change, just referencing it with #987 should be enough
John Hoffer
@thejohnhoffer
Oct 19 2016 22:40
Ian Gilman
@iangilman
Oct 19 2016 22:42
Cool
John Hoffer
@thejohnhoffer
Oct 19 2016 23:17
Issue here: openseadragon/openseadragon#1052
Ian Gilman
@iangilman
Oct 19 2016 23:19
Awesome... hopefully @VoidVolker will have some thoughts