These are chat archives for openseadragon/openseadragon

20th
Oct 2016
VoidVolker
@VoidVolker
Oct 20 2016 04:36
ok, I'll check it when I have time
John Hoffer
@thejohnhoffer
Oct 20 2016 15:35
Looks like this diff in openseadragon/openseadragon#1006 solves it for my use case.
John Hoffer
@thejohnhoffer
Oct 20 2016 15:41
This message was deleted
Ian Gilman
@iangilman
Oct 20 2016 16:41
@thejohnhoffer Nice! @avandecreme @VoidVolker ^
VoidVolker
@VoidVolker
Oct 20 2016 16:49
this is just old code
*this diff
just use stable version
Ian Gilman
@iangilman
Oct 20 2016 16:50
#1006 isn't old code; it's a new patch that's still in progress
I think @thejohnhoffer's point is that the latest code (not including that patch) has a bug in it, and that that patch fixes the bug
So I guess that means problem solved, though I wanted to draw your attention to it in case you had any comments to make about the change
John Hoffer
@thejohnhoffer
Oct 20 2016 17:11
@iangilman- that's right. I hope that the getTileAtPoint function from #1006 makes it into the next release. I would use the stable version, but my use case really depends on the tiledImage:fully-loaded-change from the development version.
Ian Gilman
@iangilman
Oct 20 2016 17:14
Cool... I expect it will. Glad you're unblocked for now :)
John Hoffer
@thejohnhoffer
Oct 20 2016 19:47
Is there any way to change the keys for keyboard navigation? I'm using ViewerInputHook for a custom event, but the plugin doesn't really look designed to simply swap keyboard shortcuts.
Ian Gilman
@iangilman
Oct 20 2016 20:11
@thejohnhoffer Unfortunately it's not terribly extensible as currently architected... it's just hard coded here: https://github.com/openseadragon/openseadragon/blob/master/src/viewer.js#L2367-L2452
John Hoffer
@thejohnhoffer
Oct 20 2016 20:13
That's okay- the keybinding defaults are pretty good as they are. And this way at least it's super clear how to change them if really necessary. Thanks.
Ian Gilman
@iangilman
Oct 20 2016 20:13
You can override by doing viewer.innerTracker.keyHandler = ... (using the function from above as your template). You'll also want to override keyDownHandler (we have both because arrow keys only work with key down (or up))
Cool
John Hoffer
@thejohnhoffer
Oct 20 2016 20:15
Ah- this explains why I was getting very different behavior when overwriting the arrowkeys than I was when messing with wasd. I had forgotten about the keydown/keyup distinction. Thanks again!
Ian Gilman
@iangilman
Oct 20 2016 20:19
:)