These are chat archives for openseadragon/openseadragon

12th
Sep 2017
tloch
@tloch
Sep 12 2017 14:41
Ian Gilman: i see... i don't have lot of JS debugging experience so not really sure what to look for (or how to trace this issue in running code)
At the moment i'm tempted to put my own previous/next buttons up there and not use OSD in sequence mode at all. I need to hook the page event anyway to redraw overlays on images changes anyway
tloch
@tloch
Sep 12 2017 15:03
The sequence button logic looks goos, but i can't figure out how tp put a break point where the button click is doing its magic
tloch
@tloch
Sep 12 2017 15:19
I Think i found it. It seems that i'm accidentially passing page numbers as numeric strings to goToPage(). In onNex() that causes string concatenation when assigigning the "next" variable. I.e. if the current page was 17 then it would try to go to 171 next
OnPrevious() doesn't have the problem because the minus is unambiguous. Putting a parseInt() around the argument in all calls to goToPage() in my code seems to fix the issue and make the nav buttons work as expected
tloch
@tloch
Sep 12 2017 15:26
This is not a bug in OSD, but sanitizing arguments sound like it could be a good idea with dynamic typing in this case