These are chat archives for openseadragon/openseadragon

4th
Apr 2018
harshalitalele
@harshalitalele
Apr 04 2018 04:23
As part of my project, we had to make the navigator of OpenSeadragon draggable.
So, here I am writing a plugin sort of thing for the same- https://github.com/harshalitalele/OpenSeadragonDraggableNavigator
See if it is of any use to anyone or anyone can help me with it.
Thanks! :smile:
Ian Gilman
@iangilman
Apr 04 2018 16:27
@harshalitalele Awesome! You should add it to http://openseadragon.github.io/#plugins
Also, you should add usage instructions to the readme, and post a live demo somewhere.
What sort of help are you looking for?
harshalitalele
@harshalitalele
Apr 04 2018 16:28
I am contributing in the Open Source project for the first time, so looking for help in reviewing and improving code
Ian Gilman
@iangilman
Apr 04 2018 16:30
Cool :)
harshalitalele
@harshalitalele
Apr 04 2018 16:30
Have you made a pull request before?
harshalitalele
@harshalitalele
Apr 04 2018 16:31
Nope
But I think I know
I will do it.
Thanks :)
Ian Gilman
@iangilman
Apr 04 2018 16:32
Excellent... thank you!
Here's some helpful info: https://github.com/openseadragon/openseadragon/wiki/Making-a-Pull-Request just keep in mind that they are different repositories.
harshalitalele
@harshalitalele
Apr 04 2018 16:34
Ok. I will do it after I am done with readme and demo.
Thanks again!
Ian Gilman
@iangilman
Apr 04 2018 16:35
:) Sounds good!
Your code looks reasonable to me... I think my biggest critique is that your demo seems a lot more complicated than it needs to be.
Also, if you link to the OSD CDN version, you don't need to include a copy of OSD in your repository.
harshalitalele
@harshalitalele
Apr 04 2018 16:39
I didn't know about CDN version. I will use that.
Ok, I will see if I can put the demo in simpler form.
Is that ok if use the image resources used on OpenSeadragon site?
Ian Gilman
@iangilman
Apr 04 2018 16:41
Absolutely :)
harshalitalele
@harshalitalele
Apr 04 2018 16:42
Great! It will be done, then. :)
Ian Gilman
@iangilman
Apr 04 2018 16:44
:thumbsup: