hmm never seen that before
oh yeah
multi-measures don't have notes, so avoid checking cursor notes there
(I generated SVGs with some meta data to help cursor movement on the server, but I'm most likely moving back to running OSMD on the client because my poor cheap Heroku server didn't have a truckload of memory and kept crashing.. I'm not going to debug memory leaks that could be somewhere in my code or OSMD or Vexflow or JSDOM..well, anywhere. :/ )
But I might end up with a hybrid solution that prefers SVG from server if it is available, otherwise loads MusicXML and OSMD. :)
I didn't expect getSVGElement() to throw. Seems like a known condition you may want to handle by returning null or something? Don't know what the coding conventions around here are, but I'd expect exceptions only for stuff that's truly unexpected or wrong. If "no notes for a multi-measure rest" is a known thing, returning null and documenting this would make sense to me.
yeah, true that, we should return undefined for multi measure rests in getSVGElement().
@sschmidTU for example some variables
// protected zoomUpdated: boolean = false;
// protected needBackendUpdate: boolean = false;
// protected rules!: EngravingRules;
// protected sheet?: MusicSheet;
// protected graphic?: GraphicalMusicSheet;
// protected drawer!: VexFlowMusicSheetDrawer;
// protected drawingParameters!: DrawingParameters;and the private function reset
I create a class which extends the OpenSheetMusicDisplay.ts and need override some function and needs call these variable. It's wonderful if the lib change the private to protected for extend
for now at least for the variables you can use e.g.
(sheet as any).member to access them.
there is nothing private anymore in OpenSheetMusicDisplay.ts
you're welcome! by the way, it would be fantastic if you considered becoming our sponsor on github :)
https://github.com/sponsors/opensheetmusicdisplay
https://github.com/sponsors/opensheetmusicdisplay
I think I have seen a method with a promising name, but I ended up doing something like this:
let graphicalMeasure = osmdInstance.graphic.getGraphicalMeasureFromSourceMeasureAndIndex(
measure,
0
);
let rect = document.createElementNS(SVGNS, 'rect');
if (graphicalMeasure && graphicalMeasure.stave) {
['x', 'y', 'width', 'height'].forEach(prop => {
rect.setAttribute(prop, graphicalMeasure.stave[prop]);
}
svg.appendChild(rect);and styling the rect appropriately.
I'm sort of happy with the above solution, only complaint is that the lower border is below the bottom line of the system - sort of makes sense because you get the noteheads below the bottom line inside your frame, but it also looks a bit odd.
(This of course requires using the SVG backend too, I don't know how to do it if you use Canvas)
@sschmidTU I think I saw a "render until measure X" parameter mentioned somewhere. Would that be a step towards rendering parts at a time?
I mean #937 by the way
@zhong_yi_ta_gitlab do you want this?
@zhong_yi_ta_gitlab
public moveToGraphicalMeasure(graphicalMeasure?: GraphicalMeasure, forceShow?: boolean): this {
if (!graphicalMeasure) return this;
const musicSystem: MusicSystem = graphicalMeasure.ParentMusicSystem;
if (!musicSystem) return this;
const nextMusicSystem = musicSystem.NextSystem;
const bboxMusicSystem = musicSystem.PositionAndShape;
const bboxMeasure = graphicalMeasure.PositionAndShape;
const x = bboxMeasure.AbsolutePosition.x + bboxMeasure.BorderMarginLeft;
const width = bboxMeasure.Size.width;
const y = bboxMusicSystem.AbsolutePosition.y + bboxMusicSystem.BorderMarginTop;
let height = 0;
if (!nextMusicSystem) {
height = bboxMusicSystem.Size.height;
} else {
const bboxNextMusicSystem = nextMusicSystem.PositionAndShape;
height = bboxNextMusicSystem.AbsolutePosition.y + bboxNextMusicSystem.BorderMarginTop - y;
}
const offsetHaftHeight = 0.1;
const offsetHaftWidth = 0.2;
const tmpRect = new RectangleF2D(
x - offsetHaftWidth,
y - offsetHaftHeight,
width + offsetHaftWidth * 2,
height + offsetHaftHeight * 2
);
const rect = this.controller.applyScreenTransformationForRect(tmpRect);
this.currentGraphicalMeasure = graphicalMeasure;
// console.log(graphicalMeasure)
// console.log((graphicalMeasure as any).stave, x, y, width, height)
if (forceShow && this.hidden) {
return this.updateStyle(rect).show();
} {
return this.updateStyle(rect);
}
}