Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Oct 13 22:06
    julidegulen edited #1123
  • Oct 13 22:06
    julidegulen edited #1123
  • Oct 13 22:06
    julidegulen commented #1123
  • Oct 13 22:06
    julidegulen commented #1123
  • Oct 13 22:05
    julidegulen edited #1123
  • Oct 13 22:05
    julidegulen edited #1123
  • Oct 13 22:04
    julidegulen commented #1123
  • Oct 13 22:04
    julidegulen commented #1123
  • Oct 13 21:44
    julidegulen synchronize #1123
  • Oct 13 21:44
    julidegulen synchronize #1123
  • Oct 13 21:39
    julidegulen synchronize #1123
  • Oct 13 21:39
    julidegulen synchronize #1123
  • Oct 13 12:07
    dependencies[bot] opened #1125
  • Oct 13 12:07
    dependencies[bot] opened #1125
  • Oct 13 12:07

    dependencies[bot] on update-f8f92ddb

    Update husky from 3.0.8 to 3.0.9 (compare)

  • Oct 13 12:07

    dependencies[bot] on update-f8f92ddb

    Update husky from 3.0.8 to 3.0.9 (compare)

  • Oct 10 22:05

    matteofigus on v0.48.5

    (compare)

  • Oct 10 22:05

    matteofigus on v0.48.5

    (compare)

  • Oct 10 22:05

    matteofigus on master

    0.48.5 changelog (compare)

  • Oct 10 22:05

    matteofigus on master

    0.48.5 changelog (compare)

Ken Crawford
@kmcrawford
@matteofigus I’m online if you want to have a quicker discussion about the PR, I just updated the comments
Matteo Figus
@matteofigus
@purwnt I am not aware of a maintained vue template but anyone can create their own
@jherr good point, there is nothing that I'm aware of. Can I know what's your usecase?
@pbazydlo @mattiaerre I just merged and published the storage adapters
@kmcrawford thanks for your PR. I added some comments. I think it's good to add a try/catch, I only would like some test there to ensure we have that documented somehow
Ken Crawford
@kmcrawford
@matteofigus I updated the code and attempted to add a test, but cannot find a suitable test that will execute that logic. Any pointers?
Davide
@jesty
Hi all! Can you suggest to me some references on how to use OpenComponents with an existing Angular application? I would like to create opencomponents from existing Angular applications.
Matteo Figus
@matteofigus
Hi @jesty I have a very old example here, just to show a little example. https://github.com/opencomponents/oc-components-examples/tree/master/angular-component
Nima
@NimaSoroush
Hi, Where is the source code of https://opencomponents.github.io/ page? Skyscanner changed the logo recently and would be great if we can get it updated there
Nima
@NimaSoroush
@matteofigus : ^
Matteo Figus
@matteofigus
dmills1723
@dmills1723

Hi everyone! I'm working on a senior design project for school and we're trying to integrate OC with an existing application, but we can't use paid services like S3 or Google Storage for our component library. Does anyone have experience or information on using alternatives like Min.io or something else? Is this even possible or are S3 and Google Storage the only tools that can be used?

Thank you!

Matteo Figus
@matteofigus
@dmills1723 check our storage-adapters repo in github. We have an implementation using Riak, which you can host on-premises, but I personally never tried it.
Minio has been discussed before but is not a good candidate for security reasons, given there is no implementation of file-based ACLs
Francisco
@francjpd

Hello,

i am pretty new :)

I've been reading the docs and something called my attention:

Why does the server.js has to pass a null as first parameter?, would not make alot more sense to have the first parameter the most used one ?...

For example:

module.exports.data = function(context, callback) {
  callback(null, {
    name: 'John'
  });
};

to me this makes more sense

module.exports.data = function(context, callback) {
  callback({
    name: 'John'
  });
};

And if i want to handle an error then provide the error... But don't make every single component to pass null to every call, in other words , it's less verbose, etc.

Matteo Figus
@matteofigus
Hi @francjpd we follow the node convention of using the first param for error, second for result
Francisco
@francjpd

Hi @francjpd we follow the node convention of using the first param for error, second for result

@matteofigus thanks for the info and the fast reply.

Francisco
@francjpd

After reading the documentation, it sounds really good :). i enjoyed reading the whole thing. Hopefully i will make a POC soon.

just wanted to say good job.

Matteo Figus
@matteofigus
Thanks!
Ken Crawford
@kmcrawford
We are using oc-template-react, and after looking at react-component.js that is getting bundled, it looks like facebook’s react is part of it. Which is 80% of the file. Is this suppose to be part of the bundle?
Ken Crawford
@kmcrawford
I created a new oc init test oc-template-react and can see it doesn’t bundle react. It must be something we are doing.
dmills1723
@dmills1723
@matteofigus Thank you. Another quick question. Will the Riak storage adapter be actively developed going forward? Do you expect it to be fully supported in the near future?
Matteo Figus
@matteofigus
@dmills1723 I don’t think it’s going to be. I mean, riak is a well built product and the adapter is just a minimal layer. There’s not much complexity around it. AFAICT it was developed for a spike but never used in production. If you’re happy to contribute, you can own it, everything here is co-owned.
dmills1723
@dmills1723
@matteofigus Understood on all points. Thank you!
Stefano Ricciardi
@stefanoric
@matteofigus you around?
A recent release of oc-template-handlebars-compiler seem to have broken some of our code
Stefano Ricciardi
@stefanoric
and it seems that oc-dev is eagerly trying to install the newer version, event though in the package.json we have pinned an older one
Stefano Ricciardi
@stefanoric
oc-dev seems to somehow go and change package.json files
to change a pinned version from "1.2.3" to something like "^1.2.3"
Stefano Ricciardi
@stefanoric
The error we are seeing it a parse error thrown by acorn.js
Stefano Ricciardi
@stefanoric
after a lot of digging I suspect there's been a change to webpack/acorn that fails to parse some of our code.
what is strange is that the new parser seems to care about whitespace (!)
I can only make one particular line of code to work only if it's not indented
I cannot even add eslint comments
Stefano Ricciardi
@stefanoric
The parsing weirdness is fixed if I move to oc-template-handlebars 6.2.7 but then I get errors about "Template was precompiled with a newer version of handlebars than the current runtime"
Stefano Ricciardi
@stefanoric
6.2.7 is also causing some parsing error for some other component :(
Stefano Ricciardi
@stefanoric
sorry, I mean 6.2.9 is also causing parsing errors for another component
Matteo Figus
@matteofigus
@stefanoric have you got a plan to stop the bleeding? Like locking your deps while clarifying?
Stefano Ricciardi
@stefanoric
@matteofigus I am afraid it's too late to lock my dependencies as we only had a lock file at the root level, not in every component folder
I have tried upgrading all packages to depend to 6.2.9
that fixed the issue with different versions of runtime
however, I still have the parsing issues
unfortunately argus.js is not very helpful in the error messages
it just says there's a parse error
at a given line
even if you replace with something bare bone/silly it still raises an error
so it's not easy to narrow down which particular line is offending
Everything was fine until last Friday, now all of a sudden builds are failing