Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 08:35
    ManishShah120 review_requested #239
  • 08:29
    coveralls commented #239
  • 08:25
    ManishShah120 synchronize #239
  • 03:49
    nemesisdesign labeled #242
  • 03:49
    nemesisdesign opened #242
  • 03:11

    nemesisdesign on master

    [ux] Fix logged in user section… (compare)

  • 03:11
    nemesisdesign closed #182
  • 03:10
    nemesisdesign commented #182
  • 02:56
    nemesisdesign commented #241
  • 02:54
    nemesisdesign commented #241
  • Apr 21 21:45
    ManishShah120 review_requested #239
  • Apr 21 21:45
    ManishShah120 review_requested #239
  • Apr 21 21:42
    ManishShah120 commented #239
  • Apr 21 21:29
    coveralls commented #239
  • Apr 21 21:25
    ManishShah120 synchronize #239
  • Apr 21 19:26
    pandafy edited #419
  • Apr 21 19:26
    pandafy edited #419
  • Apr 21 19:26
    pandafy edited #419
  • Apr 21 17:42
    nemesisdesign edited #419
  • Apr 21 17:01
    coveralls commented #193
Sankalp
@codesankalp

@codesankalp I proposed a solution that should work: https://github.com/openwisp/openwisp-controller/pull/410#pullrequestreview-638191592
I did some testing before posting it.

Yes I will look into it, thanks for review.

Federico Capoano
@nemesisdesign
@atb00ker I just noticed now: BASEURL, would be better to have BASE_URL
I'm changing fw-upgrader
Ajay Tripathi
@atb00ker
topology & radius would also need to be changed.
I'll check that out.
Federico Capoano
@nemesisdesign
I forgot that we have it in the topology module as well
that one has been already released though
I'll leave this then, it's going to require time to change it in a backward compatible way
@codesankalp check your PM
Federico Capoano
@nemesisdesign
@atb00ker https://github.com/openwisp/openwisp-radius/pull/241#pullrequestreview-638264373
Ajay Tripathi
@atb00ker
Okay.
Ajay Tripathi
@atb00ker

Updated:

Will review a couple of PRs next... ! :smile:

Nguyen Quang Minh
@minhng99
is there any variable to modify for faster config update?
after i saved the template, it seems very slow to update the config on the devices
idk if it's because i have a lot of devices or what
Federico Capoano
@nemesisdesign
there's an issue with SSL certificates on the websites which I'm resolving
Federico Capoano
@nemesisdesign
@minhng99 I'd look at increasing the capability of the celery network queue, increase the autoscale and/or spawn up more workers
Federico Capoano
@nemesisdesign

@frappelatte28 @Purhan @niteshsinha17 @devkapilbansal @s0mnaths @codesankalp @R9295 @ManishShah120
@atb00ker @pandafy

Just reinstating it here in case it's not clear to everybody:

make sure to send one pull request for each feature. Whenever changes are requested during reviews, please send new commits (do not amend previous commits), if multiple commits are present in a single pull request, they will be squashed in a single commit by the maintainers before merging

From https://openwisp.io/docs/developer/contributing.html#commit-message-style-guidelines

Please do not squash/amend your commits during the review process or it makes the life of the mentors harder because we lose track of what we reviewed and what is new. We will squash at the end once it's approved, not earlier.

Thanks for your collaboration.

1 reply
Nguyen Quang Minh
@minhng99
i wonder if the openwisp-firmware-upgrade can do sysupgrade -n?
because my custom built firmware have a luci-defaults in it, sometimes it will conflict with the previous firmware version
Nguyen Quang Minh
@minhng99
looks like i've found an issue... dunno if this behavior is expected
image.png
the device named wifi8640 has been offline for a long time
but its management IP still being stored
but another device has taken that IP address
it looks like that another device has upgraded to the new firmware instead
can we make it so it will flush the management address if the thing doesn't calling home for a long time?
Federico Capoano
@nemesisdesign
@minhng99 are you sure it reflashed the right device?
Nguyen Quang Minh
@minhng99
no, it's flashed the wrong device
the device wifi8640 isn't online when the mass upgrade being triggered
meanwhile the management IP 10.11.11.45 is being used by another device
and it's upgraded that device
Nguyen Quang Minh
@minhng99
uhh... i don't know, i can't confirm if it's upgraded the "wrong device" or not
because the device using the address 10.11.11.45 is also meant to be upgraded on the same mass upgrade operation
Nguyen Quang Minh
@minhng99
@nemesisdesign can I modify it so it will run sysupgrade -n everytime?
https://github.com/openwisp/openwisp-firmware-upgrader/blob/master/openwisp_firmware_upgrader/upgraders/openwrt.py#L27
this part, right?
Nguyen Quang Minh
@minhng99
image.png
also i keep getting error like this
0 out of 0
apparently this will happen if i changed the organization
can I use 1 firmware file to upgrade for every device across all orgs?
Federico Capoano
@nemesisdesign

@nemesisdesign can I modify it so it will run sysupgrade -n everytime?

you should create a custom backend if you don't want to lose your change when you upgrade

Apostolis Poulias
@apoulias
Hello again! I'm facing a strange issue with my deployment. Three devices are registered to the controller. Whenever I make a change in the configuration template all three devices get triggered by the management vpn, to be updated. Now is the strange part. Arbitrarily, a device doesn't update its configuration files with the new ones I've noticed that the files in /etc/openwisp/remote are different from those in /tmp/openwisp/configuration.tar.gz. The former contain the old configuration. Are the contents of the tar archive those retrieved from the controller? Does this imply that the problem lies on the device side? I'm using openwisp-controller version 0.8.4 and openwisp-config version 0.5.0. Any advice will be highly appreciated!
Federico Capoano
@nemesisdesign
@apoulias can you please reboot the devices and try again repeating the operation and then paste the logread output of the span of time in which the update happens?
Apostolis Poulias
@apoulias
@nemesisdesign, this is the log https://pastebin.com/ZVGgm7hz . I've noticed that all devices that don't apply the new configuration get two consecutive ssh connections from the controller.
Federico Capoano
@nemesisdesign
@apoulias can you please open an issue in https://github.com/openwisp/openwisp-controller/, including that log there and the steps to reproduce the issue?
I have experienced a similar issue and this needs to be solved.
Federico Capoano
@nemesisdesign
although I was not able to replicate it consistently
Federico Capoano
@nemesisdesign
@atb00ker I have one doubt here:
https://github.com/openwisp/openwisp-firmware-upgrader/pull/139#pullrequestreview-641629988
Federico Capoano
@nemesisdesign
@pniaps I merged your PRs, thanks!
However now that I'm testing other work with the latest changes I noticed the menu button looks like it has a smaller horizontal width. I will keep an eye on this and let you know more info.
@ManishShah120 reviewed & tested: https://github.com/openwisp/openwisp-users/pull/239#pullrequestreview-641752279
Is good, please do the requested clean up and we can merge.