Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    pandafy
    @pandafy:matrix.org
    [m]

    Ok, I will create permission for import-export subnet.

    Please only create it if really needed.

    Sankalp: you should be able to assign issues to yourself.
    Sankalp
    @codesankalp

    Sankalp: you should be able to assign issues to yourself.

    Yes, I assigned it now.

    Federico Capoano
    @nemesisdesign
    @codesankalp great work! I will review, thanks!
    @codesankalp I suggest that for anything which is not wifi login pages we use the general chat please
    Sankalp
    @codesankalp

    @codesankalp I suggest that for anything which is not wifi login pages we use the general chat please

    :+1:

    Federico Capoano
    @nemesisdesign
    @codesankalp do you think we can link files instead of copying them during build process?
    I explain you the issue: if I edit the custom CSS files in organizations/ or any other static file, I have to either:
    • rebuild each time I make a change
    • edit the file which gets copied instead of the source, then remember to update also the source files when I'm done
    both are not very practical
    ideally it would be great if the app can just take the file from the original location
    or alternatively it could create symbolic links
    Sankalp
    @codesankalp
    It's possible if we change webpack config.
    to watch content change on the organizations directory.
    I will find a better solution for this.
    Federico Capoano
    @nemesisdesign
    @codesankalp thanks, could you please open an issue with what I wrote above?
    Sankalp
    @codesankalp
    Yes, I will open the issue.
    Federico Capoano
    @nemesisdesign
    @codesankalp have you opened the issue we discussed yesterday yet?
    I didn't see any new issue
    Sankalp
    @codesankalp
    Federico Capoano
    @nemesisdesign
    Thanks :+1:
    chanduaki
    @chanduaki
    image.png
    28 replies
    Federico Capoano
    @nemesisdesign
    @codesankalp is the suggestion to run yarn upgrade in the installation steps in the README right?
    2 replies
    Sankalp
    @codesankalp

    @codesankalp is the suggestion to run yarn upgrade in the installation steps in the README right?

    We can but we are using dependabot for keeping track of dependencies and updating them.

    Federico Capoano
    @nemesisdesign
    yes, I am asking if that suggestion is correct
    it doesn't look correct to me
    @chanduaki is having failing tests and is fillowing instructions in the README
    Sankalp
    @codesankalp
    We can remove it.
    Federico Capoano
    @nemesisdesign
    ok let's do it, can you do it when you get time if I don't do it sooner? I would do it but I am fixing several issues elsewhere
    Sankalp
    @codesankalp
    Yes, I will do it in few minutes.
    Federico Capoano
    @nemesisdesign
    thx :+1:
    Sankalp
    @codesankalp
    Is there any change made in openwisp-radius related to phone token?
    I am getting this and browser tests are also failing.
    Internal Server Error: /api/v1/radius/organization/mobile/account/phone/token/
    Traceback (most recent call last):
      File "/home/sankalp/Desktop/op-wifi/venv/lib/python3.7/site-packages/django/core/handlers/exception.py", line 47, in inner
        response = get_response(request)
      File "/home/sankalp/Desktop/op-wifi/venv/lib/python3.7/site-packages/django/core/handlers/base.py", line 181, in _get_response
        response = wrapped_callback(request, *callback_args, **callback_kwargs)
      File "/home/sankalp/Desktop/op-wifi/venv/lib/python3.7/site-packages/django/views/decorators/csrf.py", line 54, in wrapped_view
        return view_func(*args, **kwargs)
      File "/home/sankalp/Desktop/op-wifi/venv/lib/python3.7/site-packages/django/views/generic/base.py", line 70, in view
        return self.dispatch(request, *args, **kwargs)
      File "/home/sankalp/Desktop/op-wifi/openwisp-radius/openwisp_radius/api/views.py", line 126, in dispatch
        return super().dispatch(*args, **kwargs)
      File "/home/sankalp/Desktop/op-wifi/venv/lib/python3.7/site-packages/rest_framework/views.py", line 509, in dispatch
        response = self.handle_exception(exc)
      File "/home/sankalp/Desktop/op-wifi/venv/lib/python3.7/site-packages/rest_framework/views.py", line 469, in handle_exception
        self.raise_uncaught_exception(exc)
      File "/home/sankalp/Desktop/op-wifi/venv/lib/python3.7/site-packages/rest_framework/views.py", line 480, in raise_uncaught_exception
        raise exc
      File "/home/sankalp/Desktop/op-wifi/venv/lib/python3.7/site-packages/rest_framework/views.py", line 506, in dispatch
        response = handler(request, *args, **kwargs)
      File "/home/sankalp/Desktop/op-wifi/venv/lib/python3.7/site-packages/django/utils/decorators.py", line 43, in _wrapper
        return bound_method(*args, **kwargs)
      File "/home/sankalp/Desktop/op-wifi/venv/lib/python3.7/site-packages/rest_framework/generics.py", line 190, in post
        return self.create(request, *args, **kwargs)
      File "/home/sankalp/Desktop/op-wifi/openwisp-radius/openwisp_radius/api/views.py", line 551, in create
        phone_token.full_clean()
      File "/home/sankalp/Desktop/op-wifi/venv/lib/python3.7/site-packages/django/db/models/base.py", line 1216, in full_clean
        self.clean()
      File "/home/sankalp/Desktop/op-wifi/openwisp-radius/openwisp_radius/base/models.py", line 1248, in clean
        self._validate_max_attempts()
      File "/home/sankalp/Desktop/op-wifi/openwisp-radius/openwisp_radius/base/models.py", line 1277, in _validate_max_attempts
        qs = PhoneToken.objects.filter(created__range=[date_start, date_end])
      File "/home/sankalp/Desktop/op-wifi/venv/lib/python3.7/site-packages/django/db/models/manager.py", line 85, in manager_method
        return getattr(self.get_queryset(), name)(*args, **kwargs)
      File "/home/sankalp/Desktop/op-wifi/venv/lib/python3.7/site-packages/django/db/models/query.py", line 942, in filter
        return self._filter_or_exclude(False, *args, **kwargs)
      File "/home/sankalp/Desktop/op-wifi/venv/lib/python3.7/site-packages/django/db/models/query.py", line 962, in _filter_or_exclude
        clone._filter_or_exclude_inplace(negate, *args, **kwargs)
      File "/home/sankalp/Desktop/op-wifi/venv/lib/python3.7/site-packages/django/db/models/query.py", line 969, in _filter_or_exclude_inplace
        self._query.add_q(Q(*args, **kwargs))
      File "/home/sankalp/Desktop/op-wifi/venv/lib/python3.7/site-packages/django/db/models/sql/query.py", line 1358, in add_q
        clause, _ = self._add_q(q_object, self.used_aliases)
      File "/home/sankalp/Desktop/op-wifi/venv/lib/python3.7/site-packages/django/db/models/sql/query.py", line 1380, in _add_q
        split_subq=split_subq, check_filterable=check_filterable,
      File "/home/sankalp/Desktop/op-wifi/venv/lib/python3.7/site-packages/django/db/models/sql/query.py", line 1319, in build_filter
        condition = self.build_lookup(lookups, col, value)
      File "/home/sankalp/Desktop/op-wifi/venv/lib/python3.7/site-packages/django/db/models/sql/query.py", line 1165, i
    lookup = lookup_class(lhs, rhs)
      File "/home/sankalp/Desktop/op-wifi/venv/lib/python3.7/site-packages/django/db/models/lookups.py", line 24, in __init__
        self.rhs = self.get_prep_lookup()
      File "/home/sankalp/Desktop/op-wifi/venv/lib/python3.7/site-packages/django/db/models/lookups.py", line 227, in get_prep_lookup
        rhs_value = self.lhs.output_field.get_prep_value(rhs_value)
      File "/home/sankalp/Desktop/op-wifi/venv/lib/python3.7/site-packages/django/db/models/fields/__init__.py", line 1357, in get_prep_value
        value = super().get_prep_value(value)
      File "/home/sankalp/Desktop/op-wifi/venv/lib/python3.7/site-packages/django/db/models/fields/__init__.py", line 1217, in get_prep_value
        return self.to_python(value)
      File "/home/sankalp/Desktop/op-wifi/venv/lib/python3.7/site-packages/django/db/models/fields/__init__.py", line 1314, in to_python
        value = timezone.make_aware(value, default_timezone)
      File "/home/sankalp/Desktop/op-wifi/venv/lib/python3.7/site-packages/django/utils/timezone.py", line 234, in make_aware
        return timezone.localize(value, is_dst=is_dst)
      File "/home/sankalp/Desktop/op-wifi/venv/lib/python3.7/site-packages/pytz/tzinfo.py", line 341, in localize
        raise NonExistentTimeError(dt)
    pytz.exceptions.NonExistentTimeError: 2021-10-03 00:00:00
    [03/Oct/2021 11:34:05] "POST /api/v1/radius/organization/mobile/account/phone/token/ HTTP/1.1" 500 207005
    pandafy
    @pandafy:matrix.org
    [m]
    Sankalp
    @codesankalp
    It's fascinating :sweat_smile:, I will try testing it again.
    pandafy
    @pandafy:matrix.org
    [m]
    Seems like we have something similar to Y2K in openwisp 😬
    Federico Capoano
    @nemesisdesign
    @codesankalp do you know what the library colormin is used for?
    pandafy
    @pandafy:matrix.org
    [m]

    Hi, I am adding a new component (payment-buffer) to the wifi-login-pages app.
    I have defined the component in client/components/payment-buffer/(both index.js and payment-buffer.js

    I have imported it in client/components/organization-wrapper/lazy-import.js and defined it's route in client/components/organization-wrapper/organization-wrapper.js

    I am getting following error:

    [hardsource:16bd0d0a] Could not freeze ./components/organization-wrapper/lazy-import.js: Cannot read properties of undefined (reading 'hash')

    Is there anything else that needs to be done?

    I will share the code in a bit. There are too many console.log('here') statements now. :P
    Sankalp
    @codesankalp
    Clearing cache may resolve this issue:
    rm -rf node_modules/.cache
    pandafy
    @pandafy:matrix.org
    [m]

    Clearing cache may resolve this issue:

    rm -rf node_modules/.cache

    this worked, thank you Sankalp!

    Sankalp
    @codesankalp
    welcome :smile:
    Federico Capoano
    @nemesisdesign
    @codesankalp @pandafy:matrix.org I found out what's going on on old versions of Android!
    pandafy
    @pandafy:matrix.org
    [m]
    I am getting this error in console when a redirect is being performed from the component I just introduced
    Sankalp
    @codesankalp
    using return after this.setState({redirectUrl}) may solve this problem.
    pandafy
    @pandafy:matrix.org
    [m]
    thanks! I will test it. :)