openzipkin/zipkin

Zipkin is a distributed tracing system

José Carlos Chávez

@jcchavezs

I think it is worth to ping @xeraa on this one ^

Jeff Thompson

@jeffthompson1971

Can anyone tell me what 'closes' a span? I'm getting nearly all of my spans dumped as zipkin-js.flush annotations ... literally all of them 'time out'. I don't know what is supposed to trigger a span to be 'closed'. I'm using zipkin-js . It's a node service and i'm using the axios instrumentation.. I see it calling recordRequest and then recordResponse, but what triggers the system to know the span is 'done' or 'closed'?

Jeff Thompson

@jeffthompson1971

Any reason we don't make different channels for different language/instrumentation? guessing most of you dont' care about javascript zipkin right?

Philipp Krenn

@xeraa

@zhaofuw not sure I fully understand since I don't speak chinese. is the question about the timeout or precomputing hashes for a cardinality aggregation? for the precomputing "it depends". big dataset with high cardinality might benefit. low cardinality or numeric values probably won't

José Carlos Chávez

@jcchavezs

@jeffthompson1971 we are all volunteers. We need to focus our efforts and use our time efficiently, hence we can't afford having one channel per language. I have been answering your questions directly in a private thread.

abkura

@abkura

@abkura
getting the below warning when shutting down server - using kinesissender
[WARNING]
java.lang.IllegalStateException: Connection pool shut down
at org.apache.http.util.Asserts.check (Asserts.java:34)
at org.apache.http.pool.AbstractConnPool.lease (AbstractConnPool.java:196)
at org.apache.http.impl.conn.PoolingHttpClientConnectionManager.requestConnection (PoolingHttpClientConnectionManager.java:268)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at com.amazonaws.http.conn.ClientConnectionManagerFactory$Handler.invoke (ClientConnectionManagerFactory.java:76)
at com.amazonaws.http.conn.$Proxy152.requestConnection (Unknown Source)
at org.apache.http.impl.execchain.MainClientExec.execute (MainClientExec.java:176)
at org.apache.http.impl.execchain.ProtocolExec.execute (ProtocolExec.java:186)
at org.apache.http.impl.client.InternalHttpClient.doExecute (InternalHttpClient.java:185)
at org.apache.http.impl.client.CloseableHttpClient.execute (CloseableHttpClient.java:83)
at org.apache.http.impl.client.CloseableHttpClient.execute (CloseableHttpClient.java:56)
at com.amazonaws.http.apache.client.impl.SdkHttpClient.execute (SdkHttpClient.java:72)
at com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeOneRequest (AmazonHttpClient.java:1297)
at com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeHelper (AmazonHttpClient.java:1113)
at com.amazonaws.http.AmazonHttpClient$RequestExecutor.doExecute (AmazonHttpClient.java:770)
at com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeWithTimer (AmazonHttpClient.java:744)
at com.amazonaws.http.AmazonHttpClient$RequestExecutor.execute (AmazonHttpClient.java:726)
at com.amazonaws.http.AmazonHttpClient$RequestExecutor.access$500 (AmazonHttpClient.java:686)
at com.amazonaws.http.AmazonHttpClient$RequestExecutionBuilderImpl.execute (AmazonHttpClient.java:668)
at com.amazonaws.http.AmazonHttpClient.execute (AmazonHttpClient.java:532)
at com.amazonaws.http.AmazonHttpClient.execute (AmazonHttpClient.java:512)
at com.amazonaws.services.kinesis.AmazonKinesisClient.doInvoke (AmazonKinesisClient.java:2809)
at com.amazonaws.services.kinesis.AmazonKinesisClient.invoke (AmazonKinesisClient.java:2776)
at com.amazonaws.services.kinesis.AmazonKinesisClient.invoke (AmazonKinesisClient.java:2765)
at com.amazonaws.services.kinesis.AmazonKinesisClient.executePutRecord (AmazonKinesisClient.java:2013)
at com.amazonaws.services.kinesis.AmazonKinesisClient.putRecord (AmazonKinesisClient.java:1984)
at zipkin2.reporter.kinesis.KinesisSender$KinesisCall.doExecute (KinesisSender.java:231)
at zipkin2.reporter.kinesis.KinesisSender$KinesisCall.doExecute (KinesisSender.java:222)
at zipkin2.Call$Base.execute (Call.java:380)
at zipkin2.reporter.AsyncReporter$BoundedAsyncReporter.flush (AsyncReporter.java:285)
at zipkin2.reporter.AsyncReporter$Flusher.run (AsyncReporter.java:354)
at java.lang.Thread.run (Thread.java:748)

@parkerc_gitlab

Is there any plan to add support for version 2 of the API for https://github.com/openzipkin/zipkin4net at this point?

José Carlos Chávez

@jcchavezs

Worth to as @jcarres-mdsol on this ^

Mauricio Mercado

@maumercado

Hello everyone, how can I set up my Tracer so that my url query strings are shown?

Im using nodejs

zipkinjs v 0.19

José Carlos Chávez

@jcchavezs

Hi @maumercado in which instrumentation? Client or server?

José Carlos Chávez

@jcchavezs

In either case, we removed the http.url in favour of path by default because of security concerns but maybe it is worth to add an option that allows to record the URL too.

Pirogov Alexey

@AlexeyPirogov

Hi. Is there a way to configure TimeZone in Zipkin UI (per server or request using url-params)? I have Grafana in UTC and I use "Grafana Link" to navigate to Zipkin with same time window.

Mauricio Mercado

@maumercado

Hi @jcchavezs I'm configuring my client, so that configuration would be done on the client side.

I believe it can be really useful to add that option.

Mauricio Mercado

@maumercado

@jcchavezs is there any documentation on why the decision to remove http.url was made :), would be of help

José Carlos Chávez

@jcchavezs

openzipkin/zipkin-js#226

Mauricio Mercado

@maumercado

thank you so much @jcchavezs is there a way to artificially add that, like with a tag? or span?

77_Bala_77

@Ba777

Hi everyone, I face some trouble when integrating https://github.com/rnburn/zipkin-cpp-opentracing with my code base. I installed the library and just added #include <zipkin/opentracing.h>.

It showed the below error:

sample.cc:(.text+0x6b): undefined reference to

opentracing::v3::propagation_error_category()'
sample.cc:(.text+0x82): undefined reference to

opentracing::v3::propagation_error_category()'
sample.cc:(.text+0x99): undefined reference to

opentracing::v3::propagation_error_category()'
sample.cc:(.text+0xb0): undefined reference to

opentracing::v3::propagation_error_category()'
sample.cc:(.text+0xc7): undefined reference to `opentracing::v3::propagation_error_category()'
collect2: error: ld returned 1 exit status

José Carlos Chávez

@jcchavezs

@maumercado ideally it should be added as a tag but passing an option to the client.

Mauricio Mercado

@maumercado

@jcchavezs can I see an example of how to manage that configuration? I'm not too familiarized with zipkin client yet, still learning about it :)

José Carlos Chávez

@jcchavezs

What client do you use?

If you want we can take it directly by PM

77_Bala_77

@Ba777

https://github.com/rnburn/zipkin-cpp-opentracing

Mauricio Mercado

@maumercado

that would be awesome @jcchavezs

royamiteswar

@royamiteswar

@jeqo My bad, I used self signed cert without creating a trust store for my local client apps.

paolocanon

@paolocanon

hello everyone, im new to zipkin, i have been trying to implement a telegraf agent reporting to zipkin with c# (zipkin4net). i am struggling as i keep getting HTTP 400 on the post request sent by the telegraf agent to zipkin server , i tried to output the the telegraf output to file and use postman to manually post the spans through api call but i get "Expected a JSON_V1 encoded list"

José Carlos Chávez

@jcchavezs

Does the telegraph agent support V2?

Apparently it does: https://github.com/influxdata/telegraf/blob/master/plugins/inputs/zipkin/codec/jsonV1/jsonV1.go

Could you please paste your payload here?

paolocanon

@paolocanon

@jcchavezs

some context, i have my var httpSender = new HttpZipkinSender("http://localhost:9412", "application/json");
this port is where my telegraf is listening to then outputs the data to . url = "http://127.0.0.1:9411/api/v2/spans"
i was assuming whatever httpzipkin sender send to telegraf, it will just forward it to that zipkin

here is the payload that got generated when i printed the output of telegraf
{
"fields":{
"duration_ns":48000
},
"name":"zipkin",
"tags":{
"host":"mycomputer",
"id":"52d1693e74225d64",
"name":"get",
"parent_id":"677abad90c6d84e0",
"service_name":"backend",
"trace_id":"f95cd7242c484960"
},
"timestamp":1576002349
}

José Carlos Chávez

@jcchavezs

That is now zipkin payload. There should be something translating that payload into zipkin v1 or V2.

Chech the API here: https://zipkin.io/zipkin-api/

That is V2 but you can change to v1 and click in Explore

paolocanon

@paolocanon

ok, i did saw that earlier today, i was hoping to know if that same payload is what zipkin receives from zipkin4net

paolocanon

@paolocanon

hmm actually nvm that question, i should've read hehe.. yeah looks like telegraf massages the input from zipkin... sooo i guess my question is, how is the usual implementation for zipkin-server ?is it direct logging from the application? i was hoping to utilize telegraf agent and then agent send the data instead of my app to zipkin instead

Tommy Ludwig

@shakuzen

Is there a way to configure TimeZone in Zipkin UI (per server or request using url-params)? I have Grafana in UTC and I use "Grafana Link" to navigate to Zipkin with same time window.

@AlexeyPirogov that's certainly a use case we'd like to support, I think. Zipkin timestamps are epoch microseconds, though. There's no timezone configuration. Can Grafana not do any conversion of the selected time window?

yhzhou

@zyuhong

public class ApplicationConfiguration {

    @Bean()
    public AsyncUpdateCprPasswordService getAsyncUpdateService() {
        return new DefaultAsyncServiceImpl(ldapConnectionPool);
    }

}

public class DefaultAsyncServiceImpl implements AsyncService {


    @NewSpan
    @Override
    public CompletionStage<Boolean> updatePassword(String email) {

        User user = fetchUser(email);
    }

    @NewSpan
    public User fetchUser(String email) {

        return new User();
    }
}

Hi guys, I use @NewSpan in updatePassword and fetchUser method but in zipkin that's not work

did anyone knows how to do that, thanks

Tommy Ludwig

@shakuzen

@zyuhong I believe you're using Sleuth for this, right? I'd check the Sleuth documentation, and then if it's still not clear, ask in their Gitter: https://gitter.im/spring-cloud/spring-cloud-sleuth

Marcin Grzejszczak

@marcingrzejszczak

since we're making proxies around methods annotated with @NewSpan, if you call one method with @NewSpan from another method that is annotated that way, the proxied object will not go via a proxy but directly calls the method. In other words move fetchUser to a separate bean

Andy Lintner

@beowulfe

I sent a PR to fix a leaking scope in an edge case for the HttpAsyncClient instrumentation. Should I create a matching issue for it as well, or is the PR enough? openzipkin/brave#1050

Jeff Thompson

@jeffthompson1971

I have a question about docker-zipkin and memory.... If we use the 'in memory' option, is zipkin smart enough to purge old data or will it crash after time?

Jeff Thompson

@jeffthompson1971

I"m still seeing the issue where all day long i can use the website and every single span as the exact same traceID! can anyone please explain how this could happen? what is the trigger for zipkin-js to know a span a trace is done.

Jeff Thompson

@jeffthompson1971

what tells axios-js instrumentation that indeed this next call is it's own trace?

José Carlos Chávez

@jcchavezs

@jeffthompson1971 you need to restart the container to empty the traces.

Where communities thrive

People

Repo info

Activity