Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jun 24 19:16
    gdimitrov7 commented #3461
  • Jun 23 10:08
    qzmer1104 commented #3342
  • Jun 23 10:06
    qzmer1104 commented #3342
  • Jun 23 05:08
    jcchavezs commented #1334
  • Jun 22 21:24
    frosiere commented #1334
  • Jun 22 21:21
    frosiere commented #1334
  • Jun 21 17:15
    gdimitrov7 opened #3461
  • Jun 21 17:06
    gdimitrov7 closed #3459
  • Jun 21 11:39
    basvanbeek closed #192
  • Jun 21 11:39
    basvanbeek edited #192
  • Jun 21 11:39
    frosiere edited #1334
  • Jun 21 11:37
    frosiere edited #1334
  • Jun 21 11:34
    frosiere edited #1334
  • Jun 21 11:33
    frosiere edited #1334
  • Jun 21 11:32
    frosiere edited #1334
  • Jun 21 11:29
    frosiere commented #1334
  • Jun 21 11:28
    frosiere opened #1334
  • Jun 21 11:28
    frosiere labeled #1334
  • Jun 21 08:59
    gdimitrov7 commented #3459
  • Jun 21 06:06
    codefromthecrypt commented #3460
Omid Pourhadi
@omidp

Hi,

I am using zipkin-autoconfigure-storage-elasticsearch-http 2.8.4 with zipkin-server 2.10.0 I can not connect to remote elasticsearch server.

I set System.setProperty("ES_HOSTS", "http://IP:9200"); in my spring boot app.

The exception is :


 Failed to connect to localhost/0:0:0:0:0:0:0:1:9200
    at zipkin2.internal.Platform$Jre8.uncheckedIOException(Platform.java:71) ~[zipkin-2.11.7.jar:na]
    at zipkin2.elasticsearch.ElasticsearchStorage.ensureIndexTemplates(ElasticsearchStorage.java:306)

in ElasticsearchStorage.java Line 67 : host is hardcoded like this

hosts(Collections.singletonList("http://localhost:9200"))

how can I change that ?

Adrian Cole
@adriancole
@omidp please use the normal server download as we don't support custom servers https://github.com/openzipkin/zipkin#quick-start
it comes with elasticsearch client integrated with variables to control it https://github.com/openzipkin/zipkin/tree/master/zipkin-server#elasticsearch-storage
pnilesh1
@pnilesh1
Can i use javaagent with jipkin client. I have my existing application in which i cant add the new jars so i was looking if i can attach zipkin client with javaagent.
Adrian Cole
@adriancole
I cannot vouch for the quality of data etc, but this recently said it supports sending data to zipkin https://inspectit.github.io/inspectit-ocelot/docs/tracing/trace-exporters
eleven26tech
@eleven26tech
@adriancole .. m new to DistributedTracing. Able to use Brave and setup tracing between my services. Is there a way I can pass a custom header from frontend, which gets recorded in my spans as a tag without manually setting it in all services?
I'm able to propagate the header all the way to the backend service by .propagationFactory(ExtraFieldPropagation.newFactory(B3Propagation.FACTORY, "order-id")) in the config class. But was wondering how can I get this header as a tag in all my spans so that I can search by that in the UI
Adrian Cole
@adriancole
@eleven26tech if you are using brave directly, you can setup a FinishedSpanHandler to read that property and if present add it as a tag. If you are using spring-cloud-sleuth, they have a property to set to do the same via configuration
Csaba Kos
@csabakos
Hi @adriancole , thanks for the comments on openzipkin/zipkin#2438 . Came here to continue the discussion
Adrian Cole
@adriancole
hi!
yeah LS doesn't open source their brave integration AFAICT
but yeah it should be a fix in that
Csaba Kos
@csabakos
So the LightStep collectors provide a Zipkin-compatible ingress: https://docs.lightstep.com/docs/use-zipkin-with-lightstep
heh jinx!
so in there you see them talk about a FinishedSpanHandler
so the input to that is 2 args, trace context and a mutable span
the latter does nothing to interfere with case format
so instead of using their zipkin endpoint, use a FinishedSpanHandler that renders into their model
assuming they have it.. literally I have no idea
Csaba Kos
@csabakos
We are using their Zipkin endpoint, and I don't believe they have a FinishedSpanHandler that talks to their "native" endpoint
Adrian Cole
@adriancole
also ask them to open source that because it is easier to discuss when you can see the code heh
"If you’re using Brave, add a FinishedSpanHandler to the Tracing configuration."
so I guess this has a different purpose.. again there are no details
Csaba Kos
@csabakos
Yeah the purpose of that is to add the API key (token)
Adrian Cole
@adriancole
ok
yeah so from performance and everything else POV, I think FinishedSpanHandler is what you want to have implemented
they probably have a zipkin library to send data for example, it might be better than our async sender who knows..
also they may have a means to render stack traces native to their format
they have full access to the throwable in FinishedSpanHandler
TL;DR; I think this is the best solution to the problem
otherwise you can hack and I do mean hack :)
use bytebuddy and scrub out the .toLowerCase that happens in the zipkin2.Span class
or make your own copy of the default FinishedSpanHandler that writes plain json not using our codec
Csaba Kos
@csabakos
Is LightStep the only collector that would want this feature? I'm not super familiar with the tracing space, but it seems like there are a bunch of collectors that offer Zipkin protocol compatibility.
It would be nice to allow case preservation rather than asking every vendor to write a custom FinishedSpanHandler
Adrian Cole
@adriancole
from a vendor POV, there hasn't yet been a request like yours about case format
that doesn't mean they haven't done it.
Csaba Kos
@csabakos
I guess writing my own FinishedSpanHandler that does the same as the default one now but without the lowercasing is an option, but that also feels like a hack and it would be much nicer to just set a flag on the official client
Adrian Cole
@adriancole
the code that applies the downcasing is in the model type which is used by the server etc
putting a flag would require somehow propagating it everywhere
zipkin v2 format is flat and plainer than most if not all other types there are
there are no nested lists etc
we designed the format to be stupid easy
this allows edge cases to be resolved in other ways vs forcing the project to change code types due to one request :P
also literally lightstep have tons of staff
they are billing you and it is unfair for us to have to hold that burden vs even asking them to address this
for example, stackdriver are responsible and they care for their users by helping with things like this
Csaba Kos
@csabakos
From the GitHub issue it looked like other users were asking for this feature as well, which is why I suggested reopening and gauging the interest
But anyways, thanks for the comments, now at least I have some options to pick from!
I will also ask LightStep if they would be open to creating a custom FinishedSpanHandler that avoids this problem