These are chat archives for opf/openproject

4th
Nov 2014
Alex Coles
@myabc
Nov 04 2014 10:30
@machisuji ich w├╝rde dir denn PR #2136 widmen
Markus Kahl
@machisuji
Nov 04 2014 10:32
lovely
github needs quite some time to even serve that PR
I'm seeing unicorns even.
Alex Coles
@myabc
Nov 04 2014 10:34
The conversation tab displays for me. I think it's best not to try looking at the Files Changed tab.
Markus Kahl
@machisuji
Nov 04 2014 10:37
yep ^^
Azure7111
@Azure7111
Nov 04 2014 10:39
More unicorns over here
Alex Coles
@myabc
Nov 04 2014 10:40
git diff dev origin/feature/consistent-ruby-style | $EDITOR
Markus Kahl
@machisuji
Nov 04 2014 10:45
gitx
Markus Kahl
@machisuji
Nov 04 2014 10:58
I think 120 char lines would be fine
Azure7111
@Azure7111
Nov 04 2014 11:00
We have exactly that limit
ulferts
@ulferts
Nov 04 2014 11:03
Au contraire, we have a 100 char limit
@myabc, I am a supporter for having hound on our PRs but is there a way to deactivate hound for that one branch until you deem it checkable?
@ulferts unfortunately, not AFAIK. It's either on or off.
@ulferts once Travis is through, #2136 should be checkable
Personally, I'd still encourage devs to stick to 80 chars (or possibly 100). 120 should be for exceptional cases.
Azure7111
@Azure7111
Nov 04 2014 11:19
What I meant to express was that the Add-In team has a 120 character limit
Alex Coles
@myabc
Nov 04 2014 11:22
In Ruby-land most projects seem to opt for https://github.com/bbatsov/ruby-style-guide#80-character-limits
Alex Coles
@myabc
Nov 04 2014 11:31
#2136 is green - for whoever manages to load the page.
Markus Kahl
@machisuji
Nov 04 2014 11:46
@myabc the README changes in #2136 seem to be unrelated to the rest of the PR.
Am I allowed to complain about whitespace?
I would annotate the spot on github but you know ... unicorns.
Alex Coles
@myabc
Nov 04 2014 11:51
@machisuji README changes? where?
Sure, complain all you like .. where are the whitespace issues?
Markus Kahl
@machisuji
Nov 04 2014 11:52
@myabc nevermind that's what happens when you just take a look at the diff not considering that dev probably has moved meanwhile. ;)
Alex Coles
@myabc
Nov 04 2014 15:57
@machisuji you're welcome to merge #2136 :)
Markus Kahl
@machisuji
Nov 04 2014 16:11
@myabc I merged it.
Alex Coles
@myabc
Nov 04 2014 16:11
@machisuji great! danke