These are chat archives for opf/openproject

23rd
Jun 2015
Alex Coles
@myabc
Jun 23 2015 07:37
@/all RE: Rails 4 Upgrade: plugins are ready for review (check the core PR opf/openproject#2104 for links)
Florian Kraft
@floriank
Jun 23 2015 07:38
Big PR.. I am digging through it currently
Alex Coles
@myabc
Jun 23 2015 07:39
@floriank :worried: thanks!
It is unweildy, not least because the GitHub UI lags with a PR of this size. My idea/preference was to try to reduce size + scope of subsequent PRs (e.g. removing deprecation warnings), but that relies on a fairly fast-paced review/merge cycle.
Florian Kraft
@floriank
Jun 23 2015 07:42
Probably a good idea. At the moment I actually can't Start the rails Server on the branch.. I'll check back in a minute when I reached the office
Alex Coles
@myabc
Jun 23 2015 07:43
@floriank you’re running OP on your phone?
Jan Sandbrink
@NobodysNightmare
Jun 23 2015 07:44
@myabc You don't?
Azure7111
@Azure7111
Jun 23 2015 07:44
Sounds like a decent challenge for a hackathon
Alex Coles
@myabc
Jun 23 2015 07:45
yeah, great idea!
Azure7111
@Azure7111
Jun 23 2015 07:46
If that isn't mobile first I don't know what is ^^
Florian Kraft
@floriank
Jun 23 2015 07:48
I finished the mobile version thanks to my php2js compiler last night!
Jan Sandbrink
@NobodysNightmare
Jun 23 2015 08:05
@myabc Thanks for the read on opf/openproject#3160
Alex Coles
@myabc
Jun 23 2015 08:17
garbage in, garbage out
Florian Kraft
@floriank
Jun 23 2015 13:17
is it just me or is the rails4 branch noticably faster - or am I the victim of some serious wishful thinking here? (production mode)
Alex Coles
@myabc
Jun 23 2015 13:43
Text formatting now works in deb mode too ;)
Florian Kraft
@floriank
Jun 23 2015 13:44
wuhu.
finally.
Azure7111
@Azure7111
Jun 23 2015 13:44
:+1:
ulferts
@ulferts
Jun 23 2015 13:44
What did you do in order to have the text formatting working @myabc
Florian Kraft
@floriank
Jun 23 2015 13:45
probably a deal with this mephisto person i have been hearing so much about.
@myabc the translations plugin probably needs some luvin' before we can use a rails4 based core with the community config (cuz https://github.com/opf/openproject-translations/blob/dev/openproject-translations.gemspec)
Alex Coles
@myabc
Jun 23 2015 14:28
@ulferts Nothing. It just works in Rails 4.
ulferts
@ulferts
Jun 23 2015 14:28
Yeah, right
Florian Kraft
@floriank
Jun 23 2015 14:29
i smell sulfur and brimstone.
Jan Sandbrink
@NobodysNightmare
Jun 23 2015 14:32
Trying to google for brimstone: https://de.wikipedia.org/wiki/Brimstone
Alex Coles
@myabc
Jun 23 2015 14:55
Haha 😎
kgalli
@kgalli
Jun 23 2015 14:56
Anti Tank Guided Missile — ich bin mir sicher, dass das der Florian gemeint hat ;-)
Florian Kraft
@floriank
Jun 23 2015 15:00
i love the smell of anti tank guided missiles in the morning, smells like...
anyway, @myabc I played around with the rails4 PR and found smaller issues regarding different configurations, which might or might not be important
cratz
@cratz
Jun 23 2015 15:04
I think you can drop "openproject-timestamp_migrator" for good since it is /was only needed for a migration from ruby 1.8.7 -> (1.9.x or 2.x)