These are chat archives for opf/openproject

7th
Jul 2015
Jan Sandbrink
@NobodysNightmare
Jul 07 2015 07:17
PSA: I messed up a merge into release/4.2 yesterday... I will have to force push release/4.2 and release/4.3 soon
Alex Coles
@myabc
Jul 07 2015 07:17
@NobodysNightmare oh shit
which commits shouldn’t be there?
Jan Sandbrink
@NobodysNightmare
Jul 07 2015 07:26
I merged a PR from @apfelfabrik against dev into release/4.2
Not thinking about the fact that I will also merge all from...
So it is basically dev which is now in 4.2
Alex Coles
@myabc
Jul 07 2015 07:27
ah, understood
Jan Sandbrink
@NobodysNightmare
Jul 07 2015 07:27
My force push will probably invalidate all rebases made yesterday
Alex Coles
@myabc
Jul 07 2015 07:48
please say Bescheid once it’s pushed :)
Jan Sandbrink
@NobodysNightmare
Jul 07 2015 08:00
To git@github.com:opf/openproject.git
 + 9e28c56...0418507 dev -> dev (forced update)
 + 3b47017...403757d release/4.2 -> release/4.2 (forced update)
 + 57126ea...c453b80 release/4.3 -> release/4.3 (forced update)
Oliver Günther
@oliverguenther
Jul 07 2015 08:06
@myabc @NobodysNightmare I'll have quite some time for tedious work on my train. I would thoroughly check #3149 for remaining AR issues (if that is still necessary?)
Jan Sandbrink
@NobodysNightmare
Jul 07 2015 08:08
@oliverguenther No objections from my side.
Alex Coles
@myabc
Jul 07 2015 08:42
@oliverguenther what do you mean AR issues?
Alex Coles
@myabc
Jul 07 2015 09:44
After merging newly-rebased release/4.3 > feature/rails4 > PR #3194, I’m getting some basic auth spec failures.
@machisuji / @oliverguenther does these failures mean anything to you? https://travis-ci.org/myabc/openproject/jobs/69857243
@machisuji / @oliverguenther rspec ./spec/requests/api/v3/authentication_spec.rb has failures on release/4.3 branch
Markus Kahl
@machisuji
Jul 07 2015 09:49
bummer
I'll have a look in a moment
or probably after lunch rather
Alex Coles
@myabc
Jul 07 2015 09:51
ok thanks :)
Oliver Günther
@oliverguenther
Jul 07 2015 09:59
I conclude: Gitter on mobile is highly inefficient. I receive notifications (e.g. for mentions) just fine, but loading the chat takes ages.
Mihail Maxacov
@0xF013
Jul 07 2015 09:59
just like the osx app
they seem to be running a browser canvas
Azure7111
@Azure7111
Jul 07 2015 09:59
In the browser it is somewhat ok
Mihail Maxacov
@0xF013
Jul 07 2015 10:00
also it’s crap if you have a bad connection or didn’t open it in some time
Alex Coles
@myabc
Jul 07 2015 10:05
Is Slack much better?
Mihail Maxacov
@0xF013
Jul 07 2015 10:05
I think gitter is a couple iterations from being fine
Markus Kahl
@machisuji
Jul 07 2015 10:19
Slack feels a lot faster
also once it has all the acquired screen hero stuff integrated it should be pretty useful too
Alex Coles
@myabc
Jul 07 2015 12:16
@NobodysNightmare @ulferts got time for opf/openproject#3194 and opf/openproject#3210
?
Markus Kahl
@machisuji
Jul 07 2015 12:27
@myabc regarding the failing auth specs: In release/4.3 the warden-basic_auth gem is too old. Updating it makes the specs green again. Dunno why it isn't up-to-date on release/4.3
Alex Coles
@myabc
Jul 07 2015 12:30
@machisuji oh ok
@machisuji looks like stricter versions should be defined in the Gemfile then, i.e.
gem 'warden', '~> 1.2'
gem 'warden-basic_auth', '~> 0.2.0’
gem 'warden-basic_auth', '~> 0.2.1’
Markus Kahl
@machisuji
Jul 07 2015 12:33
yes true
Alex Coles
@myabc
Jul 07 2015 12:34
@machisuji will you update the Gemfile? I’d suggest just pushing it directly, as Travis is really backed up.
Markus Kahl
@machisuji
Jul 07 2015 12:37
yeah I'll go ahead and do that
Alex Coles
@myabc
Jul 07 2015 12:40
👍
Jan Sandbrink
@NobodysNightmare
Jul 07 2015 13:04
@machisuji That was surely me. Today I had conflicts in the Gemfile.lock during merge of release/4.2 into release/4.3. My merge strategy for Gemfile.lock is git reset + bundle
Oliver Günther
@oliverguenther
Jul 07 2015 14:00
@myabc That should have read AR deprecations. I checked:
  1. No AR warnings occurred, tried to walk through the paths I didn't have the time to check last time.
  2. Finders listed here are no longer used (only User with a custom function that's named similarly)
Oliver Günther
@oliverguenther
Jul 07 2015 14:09
I browsed through the diff (compared to rails4) and overall this looks good to me, but I'm not eligible / competent to comment on the changes and discussions regarding awesome_nested_set.
Alex Coles
@myabc
Jul 07 2015 15:56
@oliverguenther thanks for the feedback!