Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Nov 25 09:35

    jacobtomlinson on master

    Add Gitlab Connector (#1869) *… (compare)

  • Nov 25 09:35
    jacobtomlinson closed #1869
  • Nov 25 09:35
    jacobtomlinson closed #1861
  • Nov 25 06:10
    codecov[bot] commented #1869
  • Nov 25 06:08
    codecov[bot] commented #1869
  • Nov 25 06:08
    codecov[bot] commented #1869
  • Nov 25 06:07
    codecov[bot] commented #1869
  • Nov 25 06:07
    codecov[bot] commented #1869
  • Nov 25 06:06
    codecov[bot] commented #1869
  • Nov 25 06:06
    codecov[bot] commented #1869
  • Nov 25 06:02
    codecov[bot] commented #1869
  • Nov 25 06:02
    FabioRosado synchronize #1869
  • Nov 24 16:36
    codecov[bot] commented #1869
  • Nov 24 16:36
    codecov[bot] commented #1869
  • Nov 24 16:36
    codecov[bot] commented #1869
  • Nov 24 16:35
    codecov[bot] commented #1869
  • Nov 24 16:34
    codecov[bot] commented #1869
  • Nov 24 16:34
    codecov[bot] commented #1869
  • Nov 24 16:33
    codecov[bot] commented #1869
  • Nov 24 16:30
    codecov[bot] commented #1869
Documentation Bot
@documentation-bot:cadair.com
[m]
Check the log for details.
Ajit D'Sa
@ajitdsa:matrix.org
[m]
Jacob Tomlinson: Are you kidding me? Yes, that was the problem. There was an error in what I was importing in the skill. FIxed that and now back to good. Thank you so much.
Jacob Tomlinson (Slack)
@_slack_opsdroid_U5MK1BW83:matrix.org
[m]
Do you see any opportunities to add some more logging anywhere to help others avoid this in the future?
1 reply
Ajit D'Sa
@ajitdsa:matrix.org
[m]

Hehe I’m looking into that exact thing :) Going to finish my current train of thought, and then recreate the issue and either get some logging going or suggest what might have helped.

Thanks again.

Jacob Tomlinson (Slack)
@_slack_opsdroid_U5MK1BW83:matrix.org
[m]
👍
Ajit D'Sa
@ajitdsa:matrix.org
[m]
Maybe there's an opportunity to add something in the docs about this. For me, I think my expectation was that app would have just errored out and stopped working rather than just throw an error but continue on. I didn't realize that might be the case until i was literally typing my original message in this channel. I'll take a look and potentially make a suggestion if I think it would help.
Sleuth
@sloth56:chat.mountainview.theworkpc.com
[m]
Opsdroid doesn't crash out when a skill causes a crash when other skills are running. And sometimes not even then.
Ajit D'Sa
@ajitdsa:matrix.org
[m]
Yes, I get that now. :) And it totally makes sense. I'm just trying to think of what may help other developers who don't realize this when they are working with opsdroid in the future.
Sleuth
@sloth56:chat.mountainview.theworkpc.com
[m]
Yeah, I hear you. Opsdroid is very hard to debug for sure.
Ajit D'Sa
@ajitdsa:matrix.org
[m]
Well now that I get it, I'm having a great time 😀 But I wasn't familiar with opsdroid (or python really) before, so I was just easily confused
Sleuth
@sloth56:chat.mountainview.theworkpc.com
[m]
Yeah, I think everyone has that ah-ha moment. I definitely did.
Jacob Tomlinson (Slack)
@_slack_opsdroid_U5MK1BW83:matrix.org
[m]
I'd love to hear thoughts about how we can improve this, I totally get that it can be a pain. If your skill errors it shows in the log. I'm pretty liberal with breakpoints when I'm debugging. But what would folks like to see?
Ajit D'Sa
@ajitdsa:matrix.org
[m]
No it’s exactly what I would like to see. I just missed it. That’s totally my fault. That’s why I’m advocating for something in the docs for writing/understanding skills that implies that if your skill fails, you will get an error in the logs, but the app won’t necessarily die.
Jacob Tomlinson (Slack)
@_slack_opsdroid_U5MK1BW83:matrix.org
[m]
Sure fair enough. More docs are always good!
Sleuth
@sloth56:chat.mountainview.theworkpc.com
[m]
I think what's needed is a start to finish writing your first skill guide. And a cheat sheet for common use cases.
Ajit D'Sa
@ajitdsa:matrix.org
[m]
I have a request for some testing help for decorators and asyncpg mocking if anyone has any experience or insight that might be helpful: https://github.com/opsdroid/opsdroid/pull/1805#issuecomment-927864969 ... then I feel we would be able to merge this PR (pending feedback from others, which I'm more than happy to receive)
Sleuth
@sloth56:chat.mountainview.theworkpc.com
[m]
Cadair: Is the matrix connector documented somewhere? Functions to create rooms, invite users, etc? If not it would be a good idea to have them.
Cadair
@cadair:cadair.com
[m]
Almost all the events supported are implemented, there is an issue tracking docs in general
Sleuth
@sloth56:chat.mountainview.theworkpc.com
[m]
Cadair: When you have a second can you comment on this? https://github.com/opsdroid/opsdroid/issues/1792#issuecomment-931506914
FabioRosado
@fabiorosado:matrix.org
[m]

Im picking up the slack connector after a long time and seems like the bot is ignoring all the breakpoints 🤔

Anyone has a vscode debug settings file ?

Sleuth
@sloth56:chat.mountainview.theworkpc.com
[m]
_LOGGER.info() 😉 You don't have to use a debugger.
FabioRosado
@fabiorosado:matrix.org
[m]
Yeah that is not helpful if I want to try different things.
Sleuth
@sloth56:chat.mountainview.theworkpc.com
[m]
Try different things?
Wouldn't you just change the code?
FabioRosado
@fabiorosado:matrix.org
[m]
Because I’m developing and debugging at the same time. Using PDB is rather powerful when you try to do those things
Cadair
@cadair:cadair.com
[m]
It shouldn't ignore breakpoints, where you putting them?
FabioRosado
@fabiorosado:matrix.org
[m]
In the slack connector before handling events as soon as the connector gets a payload
Cadair
@cadair:cadair.com
[m]
If you put a print statement in there it hits that?
FabioRosado
@fabiorosado:matrix.org
[m]

It doesn’t and I just realised that I’m dumb. I had to install with pip install . to get it to work. 🤦‍♂️

I’ve been relying on auto installs while developing for too long

Sleuth
@sloth56:chat.mountainview.theworkpc.com
[m]
It happens. Especially to me all the time.
dud1337
@dud1337:138.io
[m]
https://twitter.com/1st1/status/1002230996559949830 I'm making the jankest mock postgres module :P
1 reply
dud1337
@dud1337:138.io
[m]
thanks, FabioRosado
1 reply
I think Ajit D'Sa is giving it another shot with tests, then I'm going back to my mock asyncpg connection method. I agree with most of your comments
I'm half-tempted to put a gitpay bounty on it ^^
I'll move to fstrings. I've zero preference
FabioRosado
@fabiorosado:matrix.org
[m]
Alright thank you!
dud1337
@dud1337:138.io
[m]
these mocked DB unit tests are doing my head in
Sleuth
@sloth56:chat.mountainview.theworkpc.com
[m]
Unit tests are the worst. I'm sure those are very difficult.
dud1337
@dud1337:138.io
[m]
technically it's all mockable relatively easily, but the way the module is defined (e.g. its use of decorators) doesn't lend itself well to codecov. e.g. making unit tests for returned wrapped funcs in decorator wrappers
Sleuth
@sloth56:chat.mountainview.theworkpc.com
[m]
Yep, always hard when the lib isn't written to make tests easy.
dud1337
@dud1337:138.io
[m]
obviously in large part it's my ignorance. I'll give it a few hours
dud1337
@dud1337:138.io
[m]
pytest-psycg needs to be removed, doesn't work with async (hence build errors). going to revert
dud1337
@dud1337:138.io
[m]
I give up. This code works and had a lot of effort behind it.
There's no point mocking the entire postgresql DB, it's wheel spinning that doesn't actually give us real tests
dud1337
@dud1337:138.io
[m]
opsdroid/opsdroid#1854 take it or leave it - thanks for the project & apologies for my frustration
Oleg
@oleg:fiksel.info
[m]
FabioRosado: I'm currently checking out opsdroid/opsdroid#1855 😉
1 reply
Oleg
@oleg:fiksel.info
[m]
BTW: in the time of the preparation of the demo for the FrOSCon I found some of the parts we need to improve in the Rasa matcher.
Unfortunately I will get to them only in December.
oleg:fiksel.info @oleg:fiksel.info adds the moving of the _check_rasanlu_compatibility function call to the earlier phase to that list...
Oleg
@oleg:fiksel.info
[m]
Here's the things I have on the backlog for Rasa:
FabioRosado
@fabiorosado:matrix.org
[m]

Hey folks, it's been a long while since I looked at this section of the code base and I vaguely remember that we did some work on getting opsdroid to reload if we add a new module.

Does this mean we can hot load modules without any issue? I haven't tested this, but wanted to check before.