I'm half-tempted to put a gitpay bounty on it ^^
I'll move to fstrings. I've zero preference
Unit tests are the worst. I'm sure those are very difficult.
technically it's all mockable relatively easily, but the way the module is defined (e.g. its use of decorators) doesn't lend itself well to codecov. e.g. making unit tests for returned wrapped
funcs in decorator wrappers
Yep, always hard when the lib isn't written to make tests easy.
pytest-psycg needs to be removed, doesn't work with async (hence build errors). going to revert
There's no point mocking the entire postgresql DB, it's wheel spinning that doesn't actually give us real tests
1 reply
BTW: in the time of the preparation of the demo for the FrOSCon I found some of the parts we need to improve in the Rasa matcher.
Unfortunately I will get to them only in December.
Unfortunately I will get to them only in December.
oleg:fiksel.info @oleg:fiksel.info adds the moving of the
_check_rasanlu_compatibility function call to the earlier phase to that list...
Here's the things I have on the backlog for Rasa:
- Disable UTF-8 -> ASCII conversion to enable International support
- Handle the confusing error when opsdroid start without rasa accessible
- The hello-example matches almost everything (maybe increase the confidence level to 0.999?)
- Docs show the Rasa on port 5000 but the docker run command states port 5005
- argv switch for enable regex functionality
- Use more implicit regex (
@match_rasanlu("^.*$")) for "catch-all" matcher - Test if more implicit matching can be used for
@match_rasanlu("ask_weather"). Like@match_rasanlu("^ask_weather$") - Move the call of
_check_rasanlu_compatibilitysome place earlier (thentrain_rasanlu)- To get the compatibility check independent of the model training call
- In case user wants to skip the model training (via config option)
- https://github.com/opsdroid/opsdroid/blob/master/opsdroid/parsers/rasanlu.py#L161
Hey folks, it's been a long while since I looked at this section of the code base and I vaguely remember that we did some work on getting opsdroid to reload if we add a new module.
Does this mean we can hot load modules without any issue? I haven't tested this, but wanted to check before.
Im doing some crazy experiment. I want to pick up opsdroid web and turn it into a command centre that allows you to see your active/inactive modules and allows you to toggle modules on/off without reloading opsdroid.
I’m currently working on the api endpoint and it’s been a fun experience so far. I’ll open an issue with a scope/proposal in a bit
would be great to have a web UI
do make sure that you can opt-out or put it into another port
so that you can have a web UI and a webhook listener without security issues or whatever
being able to add and configre skills via a web UI would be cool
Yeah the idea is to make it configurable with a new param under web
I guess ideally it would be separate to the existing web stuff, but no need to worry about that for now
I was able to do it for connectors and worked fine I suspect skills should be easy as well
Mostly I’ve been hacking at it today in between baby naps 🤣
congrats on 👶
Merged
cadair:cadair.com @cadair:cadair.com wonders how good the docs are
cognifloyd:matrix.org @cognifloyd:matrix.org looks for the release docs
they are somewhere
they are a little overkill
the process I normally follow is:
- make sure the CI is passing
- Check the draft release here: https://github.com/opsdroid/opsdroid/releases and make any changes via editing PRs and re-running the release drafter action
- Publish the release
I am really busy at work at the moment, so I probably wont have too much time
uhm. so,
installation/packaging is an excluded label for release drafter, but it's a bugfix, so shouldn't it be in the release notes?
ie something that says
pip install opsdroid[all] should work again...
You can either change the label or edit the notes just before you publish the release
personally I would probably just throw the bugfix label on it
I did. I would have to remove the installation/packaging label to get it to show up I think
I'll try that