Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • May 25 10:14
    FabioRosado edited #1872
  • May 25 09:49
    FabioRosado commented #1924
  • May 21 11:26
    codecov[bot] commented #1927
  • May 21 11:25
    codecov[bot] commented #1927
  • May 21 11:25
    codecov[bot] commented #1927
  • May 21 11:24
    codecov[bot] commented #1927
  • May 21 11:24
    codecov[bot] commented #1927
  • May 21 11:24
    codecov[bot] commented #1927
  • May 21 11:19
    github-actions[bot] labeled #1927
  • May 21 11:19
    github-actions[bot] labeled #1927
  • May 21 11:18
    st01cs opened #1927
  • May 20 10:15
    jacobtomlinson labeled #1926
  • May 20 10:15
    jacobtomlinson labeled #1926
  • May 20 10:15
    jacobtomlinson opened #1926
  • May 20 10:15
    jacobtomlinson labeled #1926
  • May 18 10:13
    codecov[bot] commented #1875
  • May 18 10:13
    codecov[bot] commented #1875
  • May 18 10:12
    codecov[bot] commented #1875
  • May 18 10:11
    codecov[bot] commented #1875
  • May 18 10:10
    codecov[bot] commented #1875
dud1337
@dud1337:138.io
[m]
I think Ajit D'Sa is giving it another shot with tests, then I'm going back to my mock asyncpg connection method. I agree with most of your comments
I'm half-tempted to put a gitpay bounty on it ^^
I'll move to fstrings. I've zero preference
FabioRosado
@fabiorosado:matrix.org
[m]
Alright thank you!
dud1337
@dud1337:138.io
[m]
these mocked DB unit tests are doing my head in
Sleuth
@sloth56:chat.mountainview.theworkpc.com
[m]
Unit tests are the worst. I'm sure those are very difficult.
dud1337
@dud1337:138.io
[m]
technically it's all mockable relatively easily, but the way the module is defined (e.g. its use of decorators) doesn't lend itself well to codecov. e.g. making unit tests for returned wrapped funcs in decorator wrappers
Sleuth
@sloth56:chat.mountainview.theworkpc.com
[m]
Yep, always hard when the lib isn't written to make tests easy.
dud1337
@dud1337:138.io
[m]
obviously in large part it's my ignorance. I'll give it a few hours
dud1337
@dud1337:138.io
[m]
pytest-psycg needs to be removed, doesn't work with async (hence build errors). going to revert
dud1337
@dud1337:138.io
[m]
I give up. This code works and had a lot of effort behind it.
There's no point mocking the entire postgresql DB, it's wheel spinning that doesn't actually give us real tests
dud1337
@dud1337:138.io
[m]
opsdroid/opsdroid#1854 take it or leave it - thanks for the project & apologies for my frustration
Oleg
@oleg:fiksel.info
[m]
FabioRosado: I'm currently checking out opsdroid/opsdroid#1855 😉
1 reply
Oleg
@oleg:fiksel.info
[m]
BTW: in the time of the preparation of the demo for the FrOSCon I found some of the parts we need to improve in the Rasa matcher.
Unfortunately I will get to them only in December.
oleg:fiksel.info @oleg:fiksel.info adds the moving of the _check_rasanlu_compatibility function call to the earlier phase to that list...
Oleg
@oleg:fiksel.info
[m]
Here's the things I have on the backlog for Rasa:
FabioRosado
@fabiorosado:matrix.org
[m]

Hey folks, it's been a long while since I looked at this section of the code base and I vaguely remember that we did some work on getting opsdroid to reload if we add a new module.

Does this mean we can hot load modules without any issue? I haven't tested this, but wanted to check before.

FabioRosado
@fabiorosado:matrix.org
[m]

Im doing some crazy experiment. I want to pick up opsdroid web and turn it into a command centre that allows you to see your active/inactive modules and allows you to toggle modules on/off without reloading opsdroid.

I’m currently working on the api endpoint and it’s been a fun experience so far. I’ll open an issue with a scope/proposal in a bit

Cadair
@cadair:cadair.com
[m]
ooh
would be great to have a web UI
do make sure that you can opt-out or put it into another port
so that you can have a web UI and a webhook listener without security issues or whatever
being able to add and configre skills via a web UI would be cool
FabioRosado
@fabiorosado:matrix.org
[m]
Yeah the idea is to make it configurable with a new param under web
Cadair
@cadair:cadair.com
[m]
I guess ideally it would be separate to the existing web stuff, but no need to worry about that for now
FabioRosado
@fabiorosado:matrix.org
[m]

I was able to do it for connectors and worked fine I suspect skills should be easy as well

Mostly I’ve been hacking at it today in between baby naps 🤣

Cadair
@cadair:cadair.com
[m]
niiice
congrats on 👶
FabioRosado
@fabiorosado:matrix.org
[m]
Haha thanks 😄
cognifloyd (Jacob Floyd)
@cognifloyd:matrix.org
[m]
RFR to fix the pip install opsdroid[all] issue: opsdroid/opsdroid#1871
Cadair
@cadair:cadair.com
[m]
🥳 Merge it, do a release!
cognifloyd (Jacob Floyd)
@cognifloyd:matrix.org
[m]
Hmm... I've never done a release before.
Merged
cadair:cadair.com @cadair:cadair.com wonders how good the docs are
cognifloyd:matrix.org @cognifloyd:matrix.org looks for the release docs
Cadair
@cadair:cadair.com
[m]
I wonder where the docs are
they are somewhere
they are a little overkill
the process I normally follow is:
Sleuth
@sloth56:chat.mountainview.theworkpc.com
[m]
Cadair: I would like to get my PR merged soon but I'm not sure if I can write the tests on my own. Would you or someone else be willing to work with me on writing them?
Cadair
@cadair:cadair.com
[m]
I am really busy at work at the moment, so I probably wont have too much time
cognifloyd (Jacob Floyd)
@cognifloyd:matrix.org
[m]
uhm. so, installation/packaging is an excluded label for release drafter, but it's a bugfix, so shouldn't it be in the release notes?
ie something that says pip install opsdroid[all] should work again...
Cadair
@cadair:cadair.com
[m]
You can either change the label or edit the notes just before you publish the release
personally I would probably just throw the bugfix label on it
cognifloyd (Jacob Floyd)
@cognifloyd:matrix.org
[m]
I did. I would have to remove the installation/packaging label to get it to show up I think
I'll try that
Cadair
@cadair:cadair.com
[m]
sure