Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Aug 23 15:16
    nayrban edited #217
  • Aug 23 15:14
    nayrban opened #217
  • Aug 21 09:44
    YoranBrondsema commented #213
  • Aug 21 01:59

    dgeb on master

    Update CHANGELOG (compare)

  • Aug 21 01:55
    dgeb labeled #215
  • Aug 20 15:47
    Travis orbitjs/ember-orbit (v0.16.1) passed (683)
  • Aug 20 15:42
    cibernox commented #215
  • Aug 20 15:39
    dgeb commented #215
  • Aug 20 15:37

    dgeb on v0.16.1

    (compare)

  • Aug 20 15:37

    dgeb on master

    v0.16.1 (compare)

  • Aug 20 15:22
    dgeb closed #213
  • Aug 20 15:22
    dgeb commented #213
  • Aug 20 15:21

    dgeb on master

    Fix in Ember 3.11+ Merge pull request #215 from ci… (compare)

  • Aug 20 15:21
    dgeb closed #215
  • Aug 20 15:06
    cibernox synchronize #215
  • Aug 20 14:57
    dgeb labeled #192
  • Aug 20 14:56
    dgeb labeled #211
  • Aug 20 14:53
    dgeb synchronize #215
  • Aug 20 14:40
    dgeb commented #215
  • Aug 20 14:01
    cibernox commented #215
Dan Gebhardt
@dgeb
and thinking about what would be an ideal approach
I'm fine with providing an ESM + ES5 build, but I think I'd prefer to target that as module:es5 in package.json
while shipping modern ES (stage 4 and older) in module
I realize that the current situation is fairly broken, and I think that providing both these options covers the spectrum of what most folks need.
Christian
@makepanic
:+1: on targetting modern module systems. Do you think it would be ok to still fix the glimmer-build babel config to get correct es5 builds until the module reconfiguration is done?
Hermann
@maniodev_twitter
Hi awesome people :) I need some help regarding the id attribute when adding a record. Is there a way to prevent orbit to add it ? the B/E i'm using doesn't allow this parameter even if it's empty string. I added a comment here https://github.com/orbitjs/orbit/issues/516#issuecomment-520596941 . Thanks
Dan Gebhardt
@dgeb
@makepanic yes, I'd like to fix this upstream in glimmer-build. I'll be reviewing your PR soon.
@maniodev_twitter hi there! It does seem that id should only be sent if it is present. Let me review what's happening now. Are you using a remoteId key?
Hermann
@maniodev_twitter
@dgeb I went through this guide again https://github.com/orbitjs/orbit/issues/516#issuecomment-406594751 and looks like i missed it. It works now, thanks. POST doesn't send id. However the changes applies to PATCH too where i still need it. I just want to omit id on POST.
Dan Gebhardt
@dgeb
@maniodev_twitter hmmm, so id is being omitted on PATCH as well?
Hermann
@maniodev_twitter
@dgeb Yes.
Dan Gebhardt
@dgeb
do you have a KeyMap configured for your JSONAPISource?
a KeyMap will maintain a mapping between local ids and and keys (like remoteId)
so that when you send an update via PATCH, the corresponding remoteId will be looked up for the record's id
the same KeyMap should be shared among all your sources
Hermann
@maniodev_twitter
I don't have a KeyMap configured. I simply passed a new instance of KeyMap as mentioned in the issue. Right now because of time constraint, the B/E has been updated to not being strict on the id parameter.
I will try KeyMap later. It would be nice though to have a guide on KeyMap or could you please document such steps as mentionned here https://github.com/orbitjs/orbit/issues/516#issuecomment-406594751 ? It would be nice.
Dan Gebhardt
@dgeb
sure, I am working to expand the docs
you shouldn't need to configure anything about the KeyMap - just pass the same instance into all your sources
Hermann
@maniodev_twitter
I did it, passed keymap: new KeyMap() to my custom JSONAPISource config but didn't get id in my PATCH request.
Anyways, i'll try again and compare with the upcoming docs.
Thanks for your time!
Dan Gebhardt
@dgeb
sure thing - we'll get this straightened out for you eventually
Hermann
@maniodev_twitter
Oh yes, i saw it before. Thanks for reminding, will give another try later.
Dan Gebhardt
@dgeb
:+1:
Bernhard Halbartschlager
@Bernhard---H

Hi,

anyone here interested in my first try on implementing an abstraction layer for orbit.js?

https://github.com/orbit-model/main/blob/develop/app/src/index.ts

this is how it would be used at it's current state

Dan Gebhardt
@dgeb
@Bernhard---H very exciting! :tada:
looks like you've made quite a lot of progress
Bernhard Halbartschlager
@Bernhard---H
yes!
and I found a way to make my DI user friendly: hide it behinde a Proxy object (like laravel.php does it with it's facades)
Dan Gebhardt
@dgeb
now that you've got something working we should see how many pieces can be shared
for instance, there's now a simple identity map package in orbit: https://github.com/orbitjs/orbit/tree/master/packages/%40orbit/identity-map
and although I consider DI a bit high level for orbit itself, there may be some other primitives you've implemented that you consider to be good candidates to upstream
Bernhard Halbartschlager
@Bernhard---H

for instance, there's now a simple identity map package in orbit: https://github.com/orbitjs/orbit/tree/master/packages/%40orbit/identity-map

what exactly does this identity map do?

is a first step towards integrating models into orbit?
Bernhard Halbartschlager
@Bernhard---H

and although I consider DI a bit high level for orbit itself, there may be some other primitives you've implemented that you consider to be good candidates to upstream

the thing is, everything is built using my DI => not so easy, if you really don't want to add something like it

Bernhard Halbartschlager
@Bernhard---H
I am however trying to come up with some kind of very flexible but opinionated boot-up/factory system for Orbit itself, simply to save users some of the initial setup work => flattening the lerning curve and thus hopefully eventually find some user for my code
... this thing could probably easily be integrated into orbit itself, once it's mature enough
Miguel Camba
@cibernox
@dgeb I believe that I've found a bug in ember-orbit in the latest ember versions. Seems that Models do not receive the settings since the EMBER_FRAMEWORK_OBJECT_OWNER_ARGUMENT flag was enabled in 3.11 (https://github.com/emberjs/ember.js/commit/d1977547c09940c84daf83610b646445656bae92#diff-13a5930016c660eb0562841c81822107)
Miguel Camba
@cibernox
@dgeb something weird happened publishing 0.16.1
? Please choose a version of "@orbit/identity-map" from this list:
❯ 0.16.0
  0.16.0-beta.11
  0.16.0-beta.10
  0.16.0-beta.9
  0.16.0-beta.8
  0.16.0-beta.7
  0.16.0-beta.6
Dan Gebhardt
@dgeb
@cibernox ah, let me see ... npm crapped out during lerna publish so I had to do some things manually :/
Miguel Camba
@cibernox
weirdly enough, in npmjs.com I can see 0.16.1 🤔
Dan Gebhardt
@dgeb
ugh ... really not sure
I got the notice that it was published, and it appears to be
I just installed it in a fresh project without incident
Miguel Camba
@cibernox
maybe it's a caching issue?
Dan Gebhardt
@dgeb
perhaps?
Miguel Camba
@cibernox
trying myself