Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 01:59

    dgeb on master

    Update CHANGELOG (compare)

  • 01:55
    dgeb labeled #215
  • Aug 20 15:47
    Travis orbitjs/ember-orbit (v0.16.1) passed (683)
  • Aug 20 15:42
    cibernox commented #215
  • Aug 20 15:39
    dgeb commented #215
  • Aug 20 15:37

    dgeb on v0.16.1

    (compare)

  • Aug 20 15:37

    dgeb on master

    v0.16.1 (compare)

  • Aug 20 15:22
    dgeb closed #213
  • Aug 20 15:22
    dgeb commented #213
  • Aug 20 15:21

    dgeb on master

    Fix in Ember 3.11+ Merge pull request #215 from ci… (compare)

  • Aug 20 15:21
    dgeb closed #215
  • Aug 20 15:06
    cibernox synchronize #215
  • Aug 20 14:57
    dgeb labeled #192
  • Aug 20 14:56
    dgeb labeled #211
  • Aug 20 14:53
    dgeb synchronize #215
  • Aug 20 14:40
    dgeb commented #215
  • Aug 20 14:01
    cibernox commented #215
  • Aug 20 13:57
  • Aug 20 13:57
    tchak commented #215
  • Aug 20 13:52
    cibernox synchronize #215
Oliver Searle-Barnes
@opsb
Regarding querying the sources, what do you think to
const fetchResults = source.fetch(query);

fetchResults.transforms;
fetchResults.lastTransform;

const subscription = source.subscribe(query); // for liveQueries
So, keeping an object for the results, as we were with QueryResult
Dan Gebhardt
@dgeb
up above, we'll want to use {op: 'addRecord', record} instead of addRecordOperation - it's easier to construct the ops now
Oliver Searle-Barnes
@opsb
right
so there’s no path I take it?
Dan Gebhardt
@dgeb
right
Oliver Searle-Barnes
@opsb
would be redundent I guess
nice
yeah, that really does look better (the higher level ops)
Dan Gebhardt
@dgeb
yes, I should better document them
Oliver Searle-Barnes
@opsb
so, thoughts on that last gist?
Dan Gebhardt
@dgeb
so fetch is not bad!
Oliver Searle-Barnes
@opsb
fetchResults.lastTransform seems to be the important one
yeah, woke up this morning and it just seemed like the right word
Dan Gebhardt
@dgeb
yeah let's go with fetch
Oliver Searle-Barnes
@opsb
ok
Dan Gebhardt
@dgeb
but can it just return a promisified transform or array of transforms?
Oliver Searle-Barnes
@opsb
yeah, it could be either of those
Dan Gebhardt
@dgeb
feels like we've had this discussion :P
Oliver Searle-Barnes
@opsb
which is why I thought fetchResults might be handy ;) makes it easy to change our minds later
yeah, I’m just confirming really, we went backwards and forwards a bit
I think it’s probably best to just press forwards with that approach
Just wanted to make sure you hadn’t had any seconds thoughts
It is possible that we may want to include meta data with the fetch results
Dan Gebhardt
@dgeb
that's true
Oliver Searle-Barnes
@opsb
If we return an object we’re hedging our bets
Dan Gebhardt
@dgeb
should the metadata go on Transform?
such that every Transform can have metadata
about its source et al
there's a nice symmetry to that with transform() too
Oliver Searle-Barnes
@opsb
There’s definitely times when that will be useful (rethinkdb will include “timestamps” which can be used to check synchronisation for instance)
Dan Gebhardt
@dgeb
right
Oliver Searle-Barnes
@opsb
I can see there being meta data for the “fetch” itself though
(in addition)
Dan Gebhardt
@dgeb
ok
we can go with FetchResult
Oliver Searle-Barnes
@opsb
you’ve got me wondering about symmetry with transform() now, but I think we better back away ;)
we can tweak later
Dan Gebhardt
@dgeb
well, why not start simple though?
both transform() and fetch() can return a single Transform
and we can see if we hit any bumpy patches
Oliver Searle-Barnes
@opsb
ok, can’t see any reason why not, let’s go with that for now
Dan Gebhardt
@dgeb
we've been burned by adding unnecessary abstractions in the past :P
Oliver Searle-Barnes
@opsb
agreed
Dan Gebhardt
@dgeb
pointing the finger at myself here to be clear ;)
Oliver Searle-Barnes
@opsb
ha, I’m sure I’ve been complicit ;)
Dan Gebhardt
@dgeb
alright, let's see where this takes us ... I like the name and the symmetry between transform and fetch
Oliver Searle-Barnes
@opsb
yeah, that’s nice
ok, I’ve got some things to take care of first but I’m planning on getting back to that change later on
Dan Gebhardt
@dgeb
I was going to start by getting transforms working with JSONAPI again