Hi guys, here's some plans on reorganizing the database regarding wfslayers:
I'm working on removing transport related server code and I'm suggesting that all relevant info in portti_wfs_layer table is moved to oskari_maplayer.attributes.
Currently:
portti_wfs_layer.selected_feature_params (these are lists of feature data to show to the user)
{
"default": ["kunta_fi", ...]
"fi": ["kunta_fi", ... ],
"sv": ["kunta_se", ...]
}
portti_wfs_layer.feature_params_locales (localization for said data NOTE! They need to be in sync with the arrays in selected_feature_params):
{
"fi": ["Kunta","Ruutu-ID","ID-nro","X-koordinaatti","Y-koordinaatti","Väestö","Miehet","Naiset","Ikä 0-14","Ikä 15-64","Ikä 65+"],
"sv": ["Kommun","Rut-ID","ID-nr","X-koordinat","Y-koordinat","Folkmängd","Män","Kvinnor","Ålder 0-14","Ålder 15-64","Ålder 65+"],
"en": ["Municipality","Grid ID","ID No.","X-coordinate","Y-coordinate","Population","Male","Female","Age 0-14","Age 15-64","Age 65+"]
}
My thought is to combine these in oskari_maplayer.attributes:
{
data: {
// portti_wfs_layer.selected_feature_params (defaults to geoportal default language when requested):
selected: {
fi: ["kunta_fi", ...],
en: ["kunta_en", ...]
},
// portti_wfs_layer.feature_params_locales (changing the model so these are not tied to selected data. These will be used to switch the UI name IF said feature data attribute should be shown to user):
locale: {
fi: {
"kunta_fi": "Kunta",
...
},
en: {
"kunta_en": "Municipality",
...
}
}
},
// portti_wfs_layer.feature_namespace_url (Looks like this is the only required data from portti_wfs_layer in addition to the 2 above)
namespaceURL: 'http://jotain'
...
}
Looks like
oskari_maplayer.name == portti_wfs_layer.feature_namespace + portti_wfs_layer.feature_element already
And these tables can be removed since we don't support SLD or digging/normalizing data from complex features currently on the server side:
Any thoughts on this?
Hi @all. Quick question but some background first:
I've been doing work on updating the new react component library to a new version. It has some breaking changes (mainly regarding how icons are used). I've fixed everything in the oskari-frontend repository, but merging the PR (oskariorg/oskari-frontend#1302) means that anyone using the next version will need to update any custom code using the AntD icons/components manually. We are targeting releasing 1.56 this month and doing a 2.0 after that with the purpose of not really changing too much in behaviour but updating the components/libraries like GeoTools, GeoServer and Jetty that will require similar manual steps on the server side for version upgrade (hence 2.0 instead of 1.57).
So the question: do we merge the AntD upgrade for 1.56 OR wait for 2.0? Opinions?
PS. Updating to the new AntD version means dropping about 500kb worth of code reducing the size of the package the browser needs to load drastically and improving the startup time. The sample app runs at about 4.8megs before the change and 4.3megs after the upgrade.