by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 14:39

    johguenther on devel

    implement OIDN cancellation whe… Require minimum version 1.2.3 o… (compare)

  • 12:48

    johguenther on devel

    Benchmark VDB, unstructured and… (compare)

  • 11:53

    johguenther on devel

    Enable AMR test (compare)

  • 05:45

    johguenther on devel

    Use specific OSPRay error handl… For ospExamples errors are not … (compare)

  • Sep 24 20:32

    johguenther on devel

    move to Open VKL v0.11.0 API; s… (compare)

  • Sep 24 18:59
    johguenther closed #382
  • Sep 24 18:59
    johguenther commented #382
  • Sep 24 18:15
    StasJ commented #382
  • Sep 24 10:11

    johguenther on devel

    Add constructor for ISPC World … fix wrong static/extern declara… add World_Constructor ISPC expo… (compare)

  • Sep 24 09:47

    johguenther on devel

    don't crash when the wrong rend… (compare)

  • Sep 24 08:18
    johguenther commented #446
  • Sep 24 08:17
    johguenther closed #344
  • Sep 24 08:17
    johguenther commented #344
  • Sep 24 08:14
    johguenther commented #443
  • Sep 24 07:53
    johguenther commented #446
  • Sep 23 20:37
    StasJ commented #446
  • Sep 23 20:28
    StasJ commented #443
  • Sep 23 08:45

    johguenther on devel

    Load the denoiser module after … (compare)

  • Sep 23 07:22
    johguenther commented #436
  • Sep 23 07:20
    johguenther commented #341
Xavier
@N3zix_twitter
ok !
Jefferson Amstutz
@jeffamstutz
just got your email
Xavier
@N3zix_twitter
Done, feel free to send feedback about the code, the organization, things I shouldn't do/should do
Jefferson Amstutz
@jeffamstutz
having a look now
will do :)
Xavier
@N3zix_twitter
Awesome ! Thanks again ! There is a cmake file
Jefferson Amstutz
@jeffamstutz
one easy suggestion right of the bat is to strongly consider the C++ wrappers for v2.0+
Xavier
@N3zix_twitter
My silly questions about moving/hiding objects would make more sense I hope :)
Jefferson Amstutz
@jeffamstutz
they are much more a "first class citizen" this time around
Xavier
@N3zix_twitter
This is what I had but most of the examples I found were in C so I switched back to C
Jefferson Amstutz
@jeffamstutz
yeah, I like the idea of supporting "visible/hidden" features, just want to make sure it plays well with everything else (like we now support world-level arbitrary clipping geometries)
Xavier
@N3zix_twitter
That would be great !
Jefferson Amstutz
@jeffamstutz
any chance you could catch the crash in a debugger?
debugging by reading code can be tough sometimes, haha
Xavier
@N3zix_twitter
I am not so good with gdb but let me try :)
Jefferson Amstutz
@jeffamstutz
I actually like lldb, which you can use with:
lldb -- [normal command line]
then r to run it
and bt to get a backtrace when it segfaults
and q to quit
Xavier
@N3zix_twitter
Does it work on Windows ?
Jefferson Amstutz
@jeffamstutz
ah, I'm almost purely a linux user
so I don't know
Xavier
@N3zix_twitter
I am looking for a way to get parameters from an ospray::cpp:Instance for example. How can I get the xfm ? I tried inst.xfm(), inst.getParam<AffineSpace3f>("xfm")
Jefferson Amstutz
@jeffamstutz
OSPRay's parameters are unidirectional: we do not support getting arbitrary parameters which were set
the only exception is querying for a bounding box, as that is something OSPRay computes (and the app may need to know exactly what OSPRay's bounds are)
but all parameters come from the app
so the app is expected to remember values it wants to access at another time
Xavier
@N3zix_twitter
Alright ! I have another issue, when I move objects by setting the xfm, I have some segfaults.
Could it be that the xfm I set is incorrect ?
Jefferson Amstutz
@jeffamstutz
are you committing the world too?
or just the instance?
Xavier
@N3zix_twitter
both
Jefferson Amstutz
@jeffamstutz
unfortunately spatial updates to the world require extra commits, something we want to address in a future version
ok
that's good
all you are doing is setting the xfm parameter on an instance, recommit the instance and world?
Xavier
@N3zix_twitter
yes
and reseting accumulation buffer
Xavier
@N3zix_twitter
I am trying to enable DOF for a perspective camera. All I need to do is set the "apertureRadius" and "focusDistance" parameter to enable DOF, right ?
twitt
@TWITTM
Hi there, just a beginner question: I the context of setting the backgroundColor, I realized that it should be given in linear space. So 1st question : Are all colors expected to be in linear space? And 2nd is there a C/C++ Api function which converts a gamma corrected value to linear space ?
Xavier
@N3zix_twitter
Hi @TWITTM, indeed I think all colors are in linear space and the conversion from gamma to linear is really easy to compute: powf(gamma.r, 2.2f) if gamma.r is in [0, 1] range.
twitt
@TWITTM
Hey @Xavier, thanx, I found out, that in the example project, where you can change the background via color picker ,did it wrong, so it would be good to clearify this fact that the colors are expected in linear space in the documentation. As there is an other fomula to compute the srgba_to_linear conversation - it would be good to add these functions to the API.
Xavier
@N3zix_twitter
twitt
@TWITTM
There are already functions in the OSPRay but just missed to export them as being part of the API definition. As they can even been changed by a define wether the use the functions you mention from will Usher or just the simple pow(x,2,2). Lets see I might update my Pull Request with extending the API with those conversion functions.
twitt
@TWITTM
Sorry, I need assistance,. The function that should be exported ( srgba_to_linear ) is in ospray\math\vec.ih but I'm lost in finding a way to make them accessible in the API , and could not find the right spot and naming either .
Jefferson Amstutz
@jeffamstutz
OSPRay tries to hide its implementation details, such as internal vec math ISPC code, so the public OSPRay API is intentionally keeping this away from applications
tone mapping and/or framebuffer formats encode color space conversions in the frame itself
you can also do things with libraries that display your frame, such as using OpenGL to do SRGB color conversion on display (i.e. of a full screen quad containing of the rendered OSPRay frame buffer)
twitt
@TWITTM
@jeffamstutz Could you check my pull request #433. Defining the colorspace by OSP_TYPE similar to Texture2D could be a solution. As I'm not to deep in the project I can't tell if there are to many side effects - by adding new types.