Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Oct 17 2019 14:20

    akshatkarani on master

    Make travis green Merge pull request #44 from aks… (compare)

  • Oct 17 2019 14:20
    akshatkarani closed #44
  • Oct 07 2019 15:36
    akshatkarani synchronize #44
  • Oct 07 2019 15:28
    akshatkarani synchronize #44
  • Oct 07 2019 15:04
    akshatkarani synchronize #44
  • Oct 07 2019 14:47
    akshatkarani synchronize #44
  • Oct 07 2019 14:43
    akshatkarani closed #45
  • Oct 07 2019 14:43
    akshatkarani commented #45
  • Oct 07 2019 10:10
    sonusourav commented #45
  • Oct 07 2019 10:03
  • Oct 07 2019 09:43
    sunn-e pinned #45
  • Oct 07 2019 09:43
    sunn-e labeled #45
  • Oct 07 2019 09:43
    sunn-e assigned #45
  • Oct 07 2019 09:43
    sunn-e assigned #45
  • Oct 07 2019 09:43
    sunn-e assigned #45
  • Oct 07 2019 09:43
    sunn-e opened #45
  • Oct 07 2019 09:40
    sunn-e labeled #37
  • Oct 07 2019 09:40
    sunn-e labeled #30
  • Oct 07 2019 09:40
    sunn-e labeled #41
  • Oct 07 2019 09:40
    sunn-e labeled #34
Ritik Jain
@Rits1272
Hey @sunn-e I can work on twilio api.
Harshit Jain
@iharshit009
Can we collaborate @Rits1272 ??
Ritik Jain
@Rits1272
Ya why not...
Yash Agarwal
@yashagarwal1999
I can work on the scraper and integrate with flask
Sunny Dhoke
@sunn-e
@yashagarwal1999 cool
Ritik Jain
@Rits1272
Can mentors please review my PR?
Akshat Karani
@akshatkarani
Left some comments
Munish Grover
@MunishGrover
Hello, admins, I am Interested in contributing can u please guide me
Sunny Dhoke
@sunn-e
Sure. Please visit the github repo.
Read the readme file first.
:)
Munish Grover
@MunishGrover
Okay thank you
Sunny Dhoke
@sunn-e
@Rits1272 , I was just checking on, So how is it going, Got any success? :)
You can ask for help here if you get stuck or have any doubts
Ritik Jain
@Rits1272
Sir actually @akshatkarani said to make author an opt
Sunny Dhoke
@sunn-e
Sure. One more thing, please keep the discussions here instead of personal messages. This insure's two things. 1. It strengthens our open source community values i.e. open discussion . 2. It helps other to figure out what is going on currently :)
This is for everyone
and You can call me by my name, No Sir or anything else.
Also if you have any doubts, please let us discuss here, you need not be pro and nobody will judge you for silly mistakes. https://ohshitgit.com/
Atleast I won't ;)
Sunny Dhoke
@sunn-e
@akshatkarani It's 19th july already, where are we in our plan?
Also we may have to think of some other name for pip package. pyqotes is already taken.
PARAM MITTAL
@parammittal16
Hi mentors, this is param I am new to this project, recently worked on an issue please review my PR? oss2019/pyquotes#35
Sunny Dhoke
@sunn-e
Clever one, I'm not even mad. :p
Approved and merged.
@akshatkarani , closes #14
One announcement guys. This is the last week I guess.
Sunny Dhoke
@sunn-e
Please hurry up if you have any work remaining. Mention me @sunn-e and @akshatkarani in case your PRs are not resolved/reviewed/merged.
hardik-kgp
@hardik-kgp
@sunn-e My PR is still pending.
Aayush Bisen
@aayushbisen
Hey everyone, we should add requirements.txt so that new contributors can easily install the required dependencies.
Aayush Bisen
@aayushbisen
@sunn-e @akshatkarani I have submitted a PR regarding this. Please review.
Aayush Bisen
@aayushbisen

Due to lazy-loading of images on brainyquotes website I'm able to get starting 30 images from this page.

Should we look into different source or this is fine? Also where should we put the downloaded images?

oss2019/pyquotes#33 Question regarding this.
@sunn-e @akshatkarani
Sunny Dhoke
@sunn-e
@hardik-kgp can you please post the pr link here
@aayushbisen , any source is okay as long as the source is authorised.
hardik-kgp
@hardik-kgp
Sunny Dhoke
@sunn-e
I merged it @hardik-kgp , congrats.
Guys, we have one time till tomorrow. Please get your PR merged. I am posting the unresolved PR here, whoever is the sender, should get the issues solved.
I am ready to be generous as usual. :p
Harsh Raj
@harshraj22
For good first issue, can we add that to the same repo along with the pyquotes scrapper ? @sunn-e
Sunny Dhoke
@sunn-e
also, now i will post the open PRs, whoever wants to hijack someone else's PR, can do so if the sender has not resolved it from last 10 day. Seems fair to me. Consistency is key in open source. Communication is important too, just sending a PR and then ghosting out is not appreciable.
@harshraj22 , As I said, if it helps the project even slightly, I am ready to get it merged, just make sure it is in a new module file.
Any PR is welcome.
Harsh Raj
@harshraj22
You mean new directory ?
Sunny Dhoke
@sunn-e
Whatever suits you. I do not mind.
PARAM MITTAL
@parammittal16
Changes are done oss2019/pyquotes#37 to this PR @sunn-e plz review
Shivam Chaturvedi
@DestroyerAlpha
If the website is using Lazy-loading they are probably doing it via an API, you can check it on the Devloper Console and maybe use that API to scrape all the images
Aayush Bisen
@aayushbisen
@DestroyerAlpha Can you tell which api this page is using?