These are chat archives for oxyplot/oxyplot

9th
Dec 2014
Xavier Hahn
@Gimly
Dec 09 2014 12:29
@objorke thanks for the tip, I'll try that.
Geert van Horrik
@GeertvanHorrik
Dec 09 2014 18:59
@objorke Just a minor tip, didn't want to pollute the PR too much with comments. You only have to review the latest commit (for example, GeertvanHorrik/oxyplot@733e1aa stuff was already fixed in a later commit)
Øystein Bjørke
@objorke
Dec 09 2014 19:02
right, I started commenting on the last commit, but found some issues from the first commit later. Maybe I should have started on the oldest commit?
Geert van Horrik
@GeertvanHorrik
Dec 09 2014 19:03
no. for example, the this.ViewMinimum was already changed to this.GetMinimum() in a later commit.
when you see a pr, you only have to go through the "files changed" list: https://github.com/oxyplot/oxyplot/pull/276/files
at the left, you can hit the + button and comment on the latest version
The cool thing is that the PR => Files changed will always show the latest, so that is what you will actually be accepting when accepting the PR
Øystein Bjørke
@objorke
Dec 09 2014 19:05
thanks for the tip! I will try that next time!