Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Parker Lewis
    @pakalewis
    My comicvine api key: 8e3b162c7e676d496e5a8717190a723852915f88
    Alex Gordiyenko
    @coffellas-cto
    standard_xlarge
    Casey R. White
    @casecode
    New code for character thumbnail has been pushed to master.
    Parker Lewis
    @pakalewis
        func indexOfViewController(viewController: IntroPageVC) -> Int {
            // Return the index of the given data view controller.
            // For simplicity, this implementation uses a static array of model objects and the view controller stores the model object; you can therefore use the model object to identify the index.
            if let dataObject: AnyObject = viewController.dataObject {
                return self.pageData.indexOfObject(dataObject)
            } else {
                return NSNotFound
            }
        }
    when I pulled your code there is a crash in this func. on the if let line
    Parker Lewis
    @pakalewis
    crashes when you try to scroll or return from the detail vc
    Casey R. White
    @casecode
    Okay I will take a look. In the meantime you can just set the nav ctrl back to the initial view.
    Parker Lewis
    @pakalewis
    let kMarvelPediaPublicKey = "cd9833b30562d89cea37c07a3932dc34"
    let kMarvelPediaPrivateKey = "b154f69e4759d0855bc37ee52942ff5b9830c06f"
    Alex Gordiyenko
    @coffellas-cto
    @casecode we've switched to different remote branch called "tempmaster" for now
    Casey R. White
    @casecode
    Bug fix applied on master.
    Parker Lewis
    @pakalewis
    pushed my latest code. added a few todos. Looking pretty good so far!
    Alex Gordiyenko
    @coffellas-cto
    Pushed my changes:
    • Implemented 'itemsLeft' parameter for a completion handler of all the public MarvelNetworking methods. This one is used for better pagination. Now there is no need to make one more redundant API call to check if any objects are left to grab from server.
    • Some UI tweaks
    Parker Lewis
    @pakalewis
    @coffellas-cto we're upstairs for now since they are doing the filming downstairs.
    Alex Gordiyenko
    @coffellas-cto
    let kMarvelPediaPublicKey = "d2d6ca75eea4f72e8a423efb30af55a5"
    let kMarvelPediaPrivateKey = "e690efe9fd4087d72bb9718d634f1f02a8ccc938"
    Casey R. White
    @casecode
    pub key: 302e6667893649ed54fdd284f5e24e2b
    pivate key: a31817286a17a9bcb2d060cf2887427ab4f52859
    Alex Gordiyenko
    @coffellas-cto
    hello guys. Spent a lot of time on new UI theme and switching between characters & comics search. You can grab the latest version of the app from origin/master. Not everything is done yet, and there are still some bugs. But I think we can finish that on friday for sure
    Parker Lewis
    @pakalewis
    Awesome! Looks great
    l'll be in a little late today. Probably around 9:45
    Casey R. White
    @casecode
    Same
    Alex Gordiyenko
    @coffellas-cto
    Hi guys. I'll be late too, went to bed too late last night
    Parker Lewis
    @pakalewis
    another set of keys
    let kMarvelPediaPublicKey = "a685f1a1dbc2512d628c177105461b44"
    let kMarvelPediaPrivateKey = "8e307ec4a838f2f8141223c7d4edbe1866046559"
    Alex Gordiyenko
    @coffellas-cto
    guys, i've updated history in our github repository, because my previous commits were made from wrong email
    so you need to delete your local folder and re-clone the repo again, I suppose
    Parker Lewis
    @pakalewis

    Hi,

    We are three iOS developers attending a two-month programming "bootcamp" through Code Fellows in Seattle. As part of a weeklong project, we created an app using the Marvel API. The app enables users to search the database of comic books and characters. Here is a link to the project: https://github.com/pakalewis/MarvelPedia.

    We are considering building a simplified database to use as our back end. This would be populated by scheduled calls to the API. This would allow actual users of the app to grab data from our source rather than make more calls to the API and exhaust the rate limit.

    We had a great time creating this app and would love to see it in the App Store, but wanted to make sure that we are in accordance with your policies. Please advise if there is anything about our app that needs to be changed before we submit the app.

    Thanks,
    Parker Lewis
    Alex Gordiyenko
    Casey White

    anything else to add?
    we may not have done enough linking: http://developer.marvel.com/documentation/attribution
    Casey R. White
    @casecode
    Looks pretty good to me
    Alex Gordiyenko
    @coffellas-cto
    If we add a link to Code Fellows would it make any difference?
    Parker Lewis
    @pakalewis
    sure that sounds ok. I'll add that link and send to them via their contact page
    Alex Gordiyenko
    @coffellas-cto
    we probably should add screenshots of our app and add them to our README before sending
    Alex Gordiyenko
    @coffellas-cto
    I have uploaded the screenshots and added them to github's README
    Parker Lewis
    @pakalewis
    oh nice that looks awesome
    I sent them the message yesterday evening. Hopefully we hear back soon
    Alex can you show me how to add images like that to github
    Alex Gordiyenko
    @coffellas-cto
    just open readme file and see the syntax
    Parker Lewis
    @pakalewis
    sweet. good to know
    Parker Lewis
    @pakalewis
    MarvelPedia has been submitted to the App Store. I'll let you know when it's live!
    bradleypj823
    @bradleypj823
    sweet! good work guys
    Parker Lewis
    @pakalewis
    thanks Brad. hope it gets the OK! wow, that submission process is not easy
    bradleypj823
    @bradleypj823
    haha yep and it used to be twice as difficult
    Parker Lewis
    @pakalewis

    Bummer, MarvelPedia was rejected by Apple. Here is what they said:

    Reasons

    8.5: Apps may not use protected third party material such as trademarks, copyrights, patents or violate 3rd party terms of use. Authorization to use such material must be provided upon request
    ----- 8.5 -----

    Your app includes content or features that resemble one or multiple well-known, third-party marks including Marvel. To proceed with the review of your app, we require documentary evidence of your rights to use this content in your app.

    Additionally, it would be appropriate to revise your application name so that the trademarked item is used as a descriptor, but not as part of the product name. For example, the following styles are acceptable formats for names:

    GreatApp - "for Marvel"
    GreatApp - "Marvel edition"
    GreatApp - "Marvel version"

    Pursuant to your agreement with Apple, you represent and warrant that your application does not infringe the rights of another party, and that you are responsible for any liability to Apple because of a claim that your application infringes another party's rights. Moreover, we may reject or remove your application for any reason, at our sole discretion.

    Accordingly, please provide documentary evidence of rights to use this content. Once Legal has reviewed your documentation and confirms its validity, we will proceed with the review of your app.

    If your iTunes Connect Application State is Rejected, a new binary will be required. Make the desired metadata changes when you upload the new binary.

    NOTE: Please be sure to make any metadata changes to all App Localizations by selecting each specific localization and making appropriate changes.

    So we should probably change the name. Any suggestions? A few ideas:
    ComicPedia
    ComicPedia - (Marvel)
    ComicBase
    Parker Lewis
    @pakalewis

    Apple also included two screenshots from the app that both show large images. I'm wondering if Apple noticed that we do not quite follow this set of rules from Marvel:

    Linking to Marvel
    Linking from your application and web pages to Marvel helps us understand how applications are being used by end-users, which applications are most successful, and which presentations of Marvel content is most impactful, all of which helps us improve our API products.

    You must link to Marvel whenever you show any information from the API beyond the title and small (100px width or smaller) thumbnail of an entity. For example, displaying a set of comics with only the title and small thumbnail would require only the attribution language above. If that same set were displayed with any additional information, each comic would need to have a link back to one or more of the URLs associated with that comic.

    We have the one link at the bottom of every view that links to Marvel.com but we do not the part above in bold.

    Alex Gordiyenko
    @coffellas-cto
    Hi Parker. Well, this situation was kind of predictable. The best thing we can do is trying to contact Marvel again. I think renaming the app won't hurt at all. But we should get that "documentary evidence" Apple requires.
    Punita Ojha
    @punitaojha
    This message was deleted