by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Aug 08 15:44
    mightyiam closed #772
  • Aug 08 15:44
    mightyiam commented #772
  • Aug 08 15:04
    patomation commented #772
  • Aug 08 13:00
    patomation opened #772
  • Aug 08 05:25
    renovate[bot] synchronize #702
  • Aug 08 05:25

    renovate[bot] on latest-snabbdom-release-1.x

    chore(deps): update dependency … (compare)

  • Aug 08 05:24
    renovate[bot] synchronize #756
  • Aug 08 05:24

    renovate[bot] on mocha-8.x

    chore(deps): update dependency … (compare)

  • Aug 08 05:16
    patomation closed #768
  • Aug 08 05:15
    patomation closed #769
  • Aug 08 05:11

    mightyiam on allow-ci_patomation_allow-fork-ci

    (compare)

  • Aug 08 05:11

    mightyiam on allow-ci_770

    (compare)

  • Aug 08 05:11

    mightyiam on allow-ci_771

    (compare)

  • Aug 08 05:11

    mightyiam on master

    docs(github): use refs/pull in … (compare)

  • Aug 08 05:11
    mightyiam closed #771
  • Aug 08 05:06

    mightyiam on allow-ci_771

    docs(github): use refs/pull in … (compare)

  • Aug 08 05:00
    patomation synchronize #771
  • Aug 08 04:58

    mightyiam on allow-ci_771

    docs(github): use refs/pull in … (compare)

  • Aug 08 04:54
    patomation opened #771
  • Aug 08 04:17
    renovate[bot] synchronize #702
Mike Reinstein
@mreinstein
it's actually a DOM node
(fetchSvg generates a dom element)
I guess this is easy to fix, just having fetchSvg omit the lines that parse the svg xml into a dom element is the answer
siassaj
@siassaj
Make a strong
Strong
Strong
Fuuuuuck
String
But actually I’m not 100% sure
Innerhtml might take a node?
Mike Reinstein
@mreinstein
oh
yeah maybe
I guess this isn't an important part of the demo, just wanted to make sure I'm not missing something with the snabbdom api
it looks like a straightforward prop passthrough
the only other thing I've noticed is this code embeds an svg inside an image tag
I guess in reality I'd want to do something more like return h('button', { props: { innerHTML: svgXml } })
thanks again for your help! This is great :)
siassaj
@siassaj
Yeah I didn’t check
I just adjusted the tag
David Boyer
@mangr3n
Are you guys actively working on the code? There's a change to the thunk code which would allow the caller to specify his own value comparison function. I need that.
Mike Reinstein
@mreinstein
Hey I was wondering if anyone would be willing to critique/code review a little app I made based on snabbdom?
I'm still learning and I'd love to hear from the experts and see what people think
Ionut Achim
@monojack
Is there a way to do fragments in snabbdom?
siassaj
@siassaj
@monojack i think you can just return them as an array?
unless i'm imagining something
@mreinstein what would you like to hear?
i don't see any issues with your code quality
siassaj
@siassaj
i would definitely switch to typescript if only to handle the model type properly
sebovzeoueb
@sebovzeoueb
Hey, I was using the older version of snabbdom with require before, and now I've started up a new project and I see that now it uses ES6 modules with import instead
I'm using webpack, and I can't for the life of me get it to work at all
if I follow the example from the github page I just get ERROR in ./main.js Module not found: Error: Can't resolve 'snabbdom/init' in 'F:\test'
is there something special I need to do in webpack to make it work?
I feel like I must just be doing something stupid here, but I can't figure out what
I did npm i webpack webpack-cli snabbdom in my test project
and then I have a script in the package that does webpack -w
all this was working just fine with the CommonJS snabbdom
sebovzeoueb
@sebovzeoueb
and so far my main.js just has import {init} from 'snabbdom/init'
like the top line of the example
and webpack just seems unable to find the whole snabbdom module
sebovzeoueb
@sebovzeoueb
and it's not just webpack, vscode isn't generating any suggestions either
it's like it just didn't install at all
sebovzeoueb
@sebovzeoueb
well, it suggests snabbdom, but then only the build and src directories
I don't see any of the exports
sebovzeoueb
@sebovzeoueb
huh, if I'm understanding the issue correctly, stable version webpack doesn't support the package.json exports yet
sebovzeoueb
@sebovzeoueb
OK, I can confirm that it's the problem
you have to use webpack@next otherwise snabbdom's exports don't work
Géraud Henrion
@fuunnx
I can confirm I also have to import under the snabbdom/build folder :
import { eventListenersModule } from "snabbdom/build/package/modules/eventlisteners";
sebovzeoueb
@sebovzeoueb
yeah, I guess that's the other way to do it