by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Jun 05 05:06
    LemingVan closed #779
  • Jun 05 05:06
    LemingVan commented #779
  • Jun 04 18:29
    rabernat commented #779
  • Jun 04 11:33
    TomAugspurger commented #773
  • Jun 04 11:19
    Boes-man commented #773
  • Jun 04 07:38
    LemingVan opened #779
  • Jun 03 18:19
    scottyhq commented #773
  • Jun 03 15:14
    TomAugspurger commented #773
  • Jun 02 23:57
    Boes-man commented #773
  • Jun 02 19:25
    stale[bot] labeled #757
  • Jun 02 19:25
    stale[bot] commented #757
  • Jun 02 13:10
    TomAugspurger commented #773
  • Jun 02 03:15
    Boes-man commented #773
  • May 30 02:33
    stale[bot] closed #769
  • May 30 02:33
    stale[bot] commented #769
  • May 28 17:48
    bradyrx commented #764
  • May 25 01:23
    dgergel commented #778
  • May 25 01:22
    dgergel commented #778
  • May 25 01:20
    dgergel commented #778
  • May 23 19:52
    stale[bot] unlabeled #764
Scott
@scollis
Are folks having issues today with postbuilds.. my jupyter labextentions install is throwing errors..
according to the tracker it should be fixed..
I wonder if the docker image needs updating
@scottyhq ...
David Hoese
@djhoese
@scollis the issue with doing data download in postbuild is that all that gets bundled in the image. If the image takes too long to download it can stop your image from being loaded in time and binderhub will time out
if you do the data download in the start without putting it in the background then a similar thing will happen where binderhub will wait for jupyter lab to start up but it won't happen in time because data is taking too long to download
(from experience)
Scott
@scollis
Great point! One issue is the current way I am building my image is using a Pangeo docker container as a base.. and somehow this stops start being run
BTW Great seeing @kmuehlbauer here.. Kai, I plan to build an OpenRadarScience Pangeo
the AMS Radar workshop will be a launchpad…
Scott Henderson
@scottyhq
@scollis - looks like you can pin jupyterlab<1.1 in your environment file as a solution? if you’re up for a bit of digging a pull request to enable running the ‘start’ script would be great! https://github.com/pangeo-data/pangeo-stacks/blob/4c90b98836c66403ab81ca837ce979ec9628a232/onbuild/r2d_overlay.py#L125
Kai Mühlbauer
@kmuehlbauer
@scollis You seem to be everywhere :grinning: I think I got it working using postBuild. Need to check tomorrow. jupyter hub on a mobile just isn't usable (in terms of screen size, :grimacing:).
Scott
@scollis
Thanks @scottyhq ! I’ll take a look
Scott
@scollis
something like this @scottyhq
Scott Henderson
@scottyhq
Seems like the right idea! looks like you’ll have to add a line here too https://github.com/pangeo-data/pangeo-stacks/blob/4c90b98836c66403ab81ca837ce979ec9628a232/onbuild/Dockerfile#L15. Are you able to run locally to test? @yuvipanda has mentioned putting r2d-overlay in a separate repo b/c it is a useful tool! So some additional changes could be in store in the future, but this feature would be nice to have in the meantime.
Scott
@scollis
Would that be ONSTART RUN?
if do ONBUILD RUN /usr/local/bin/r2d_overlay.py start
it would just run that on build right
(winging it :D )
and do you just check it with Docker?
wonder if it is this
Scott Henderson
@scottyhq
(I’m also winging it ;) I think it would be best to take a look at https://github.com/pangeo-data/pangeo-stacks/issues/38#issuecomment-494125005. Then go ahead and start your pull request w/ the current modifications saying it’ll close that issue.
Scott
@scollis
Cool… so it is Entrypoint
Scott Henderson
@scottyhq
yes - i’ve run repo2docker often in the past locally to check builds - and you can always push to dockerhub and then point to these images to run with any of the binderhubs with Dockerfile.
Joe Hamman
@jhamman
@scollis - yes, the start script is run as an entrypoint. You may be interested in this PR in the main repo2docker repo where the feature was first developed: https://github.com/jupyter/repo2docker/pull/363/files
(we renamed launch —> start but the idea is there)
Scott
@scollis
cool.. I commended on this issue
oh cool.. yeah I can just point repo2docker to the branch
hah.. commended.. I meant commented.. sounds like I have a mouth full of marbles
Scott
@scollis
@scottyhq cool.. I am learning a lot today.. got repo2docker running..
Scott
@scollis
ok.. it ran and I could see the server.. now making a saved image and pushing to dockerhub
Yuvi Panda
@yuvipanda
@scollis @scottyhq @jhamman I left a comment in the issue!
thanks for working on it
Scott
@scollis
@scottyhq can you share the command line you use to make the image?
I am doing `jupyter-repo2docker --no-run --user-name=jovian --image=pgimnomod https://github.com/pangeo-data/pangeo-stacks to reproduce the base stack
Scott Henderson
@scottyhq
or repo2docker --no-run --user-name=jovyan --user-id 1000 --image-name=scottyhq/geohackweek2019:2019-08-01 ./geohackweek2019
(with image definition in ./geohackweek2019/binder)
then docker push scottyhq/geohackweek2019:2019-08-01
Scott
@scollis
Thanks!
Scott Henderson
@scottyhq
no problem. once pushed to dockerhub you can point any binderhub to it. for example: https://github.com/scottyhq/pangeo-binder-test/tree/geohackweek2019
Scott
@scollis
So @scottyhq was the directory you hit in your example similar to https://github.com/pangeo-data/pangeo-stacks/ ? Have you got a link to a repo for ./geohackweek2019
Scott
@scollis
So when I use that command to just build and push the pangeo-stack repo I get
Waiting for build to start...
Picked Git content provider.
Cloning into '/tmp/repo2dockerizn77xre'...
HEAD is now at bb95d23 Merge pull request #29 from scollis/binderfun
Using DockerBuildPack builder
Step 1/1 : FROM scollis/pgimnomod:2019-08-29-1
---> f810db89f888e...
{"aux": {"ID": "sha256:f810db89f888064551d7a64c293ced0303e32ee2c11cc87ebbbf05a539438191"}}[Warning] One or more build-args [NB_USER NB_UID] were not consumed
Successfully built f810db89f888
Successfully tagged gcr.io/pangeo-181919/prod-openradar-2dams-2dopen-2dsource-2dradar-2d2019-581cd2:bb95d230e40a479fd7f3801d4ccc17106626e99d
Pushing image
Pushing image
So, @scottyhq when you build something like pangeo/base-notebook-onbuild:2019.08.18
what do you do?
Joe Hamman
@jhamman
@scollis - all the pangeo/*notebook images are built on Travis. That system is a bit more complex.
Scott
@scollis
ok.. Just working out how to make sure what I did in my upcoming PR is correct