Hi guys! Could you please explain to me is it ok to have connection status "sleeping" on SQL server after querying DB with node-mssql
I have this simple method:
async queryDatabase(queryOption) {
try {
// const pool = new sql.ConnectionPool(this.getConfigCsdb());
let connection = await pool.connect(this.getConfigCsdb());
let result = await connection.request().query(queryOption);
result = result['recordset'][0][''];
return result;
} catch (e) {
throw e;
} finally {
await connection.close();
}
}Which works perfectly but want to confirm that it closes a connection.
After querying Database, using EXEC sp_who2; I see the connection bridge visible in the list of processes:
sleeping Alexanders-MacBook-Pro-3.local node-mssqlwhen I running query I'm observing status to be changed to "RUNNABLE" and after finishing it becomes "sleeping".
Should it be like that or it should vanish at all from the list of connection shown in EXEC sp_who2;?
it just says that close()
Close all active connections in the pool.
And I would be grateful to know in which status it leaves connection ultimately
Close all active connections in the pool.
And I would be grateful to know in which status it leaves connection ultimately
I think it's an operating system level issue and not to do with the lib.
It's nothing to worry about unless you start seeing hundreds of connections
const pool2 = new sql.ConnectionPool(config, err => {
// ... error checks
}).connect();
// ... error checks
}).connect();
I get an error saying already connecting
also connect() returns promise which gives error on the next line
pool2.on('error', err => {
// ... error handler
})
// ... error handler
})
Either omit the callback and use the promise, or embrace callback hell
_g[conn].request().query(preparedQuery, function (err, records) {
_g[conn].on('error', errdb => {
reject(_t.i(1005, configurations.errors, errdb));
Logger.log("error", "tmsmssql", "SYS", _t.i(1005, configurations.errors, errdb));
return;
});
if (err) {
reject(_t.i(1003, configurations.errors, JSON.stringify(err)));
} else {
if (records.rowsAffected[0] > 0) {
if (op === 'INSERT' || op === 'UPDATE' || op === 'DELETE') {
resolve(_t.i(200, null, records));
} else {
resolve(_t.i(200, null, records.recordset));
}
} else {
reject(_t.i(1004, configurations.errors));
}
}
});
_g[conn].on('error', errdb => {
reject(_t.i(1005, configurations.errors, errdb));
Logger.log("error", "tmsmssql", "SYS", _t.i(1005, configurations.errors, errdb));
return;
});
if (err) {
reject(_t.i(1003, configurations.errors, JSON.stringify(err)));
} else {
if (records.rowsAffected[0] > 0) {
if (op === 'INSERT' || op === 'UPDATE' || op === 'DELETE') {
resolve(_t.i(200, null, records));
} else {
resolve(_t.i(200, null, records.recordset));
}
} else {
reject(_t.i(1004, configurations.errors));
}
}
});
I have a problem with the tutorial. I tried the ConnectionPool and always got the message that .on() is not a function and then I commented that out and tried it without, but now I get the error Already connecting to database. What did I do wrong?
const mssql = require('mssql');
let config = {...}; // that one is correct, I tested it with a pure simple query
const sqlPool = new mssql.ConnectionPool(config, err => {
console.log(err);
}).connect();
sqlPool.on('error', err => {
log(err);
});
const sqlQuery = queryString => {
return sqlPool.then(pool => {
pool.request().query(queryString)
}).then(result => {
console.dir(result);
})
};
sqlQuery("SELECT * FROM users");
const mssql = require('mssql');
let config = {...}; // that one is correct, I tested it with a pure simple query
const sqlPool = new mssql.ConnectionPool(config, err => {
console.log(err);
}).connect();
sqlPool.on('error', err => {
log(err);
});
const sqlQuery = queryString => {
return sqlPool.then(pool => {
pool.request().query(queryString)
}).then(result => {
console.dir(result);
})
};
sqlQuery("SELECT * FROM users");
Instead of this
mssql.ConnectionPool(config, err => {
console.log(err);
Try like this:
mssql.ConnectionPool(config)
.then((result) => {})
.catch((reason) => {});
Error handling is in the catch
.catch((reason) => {
console.error(reason);
});
grrrr... no I get the error: TypeError: (intermediate value).then is not a function
maybe I need a complete functioning module to adjust to my needs instead of small code samples. Do you have an example that I could use? I search for one that uses one connection for a long time (there maybe many calls to the same database from the same server without any other connections. So 1 connection that stays open for a longer time should be fine). The samples I found and that work all use a single call on a connection inside the connection call. But that way the connection would have to be closed and reopened on every query.
maybe I need a complete functioning module to adjust to my needs instead of small code samples. Do you have an example that I could use? I search for one that uses one connection for a long time (there maybe many calls to the same database from the same server without any other connections. So 1 connection that stays open for a longer time should be fine). The samples I found and that work all use a single call on a connection inside the connection call. But that way the connection would have to be closed and reopened on every query.
I think I know what you mean, personally I created a class that is technically a singleton for each database. Basically the connectionPool is module variable that calling modules access to. Then anytime I want to run requests I listen to the (already happened) on(“connect”) event
I've tried a connection string like this: Provider=Microsoft.SQLSERVER.CE.OLEDB.3.5;Data Source=Northwind.sdf;Persist Security Info=False;
And get the following error: ConnectionError: Failed to connect to Northwind.sdf:1433 - getaddrinfo ENOTFOUND Northwind.sdf
Any help would be greatly appreciated
dhensby on master
Update changelog for v5 Merge pull request #796 from dh… (compare)