Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Brian Muenzenmeyer
    @bmuenzenmeyer
    i have yet to pull that in
    Matthew Bulfair
    @mbulfair
    I should be releasing the webpack upgrade to my edition in the next week. I think I got it much more effiecent and fixed some bugs. In case anyone is interested :)
    Jonas Ulrich
    @julrich
    ("has the missing pattern inside" in this context meaning: It has relPath: 01-pages/03-amet/01-amet.hbs in there. The pseudo patterns would follow, if processIterative for that pattern would be called, which it is not :/)
    Brian Muenzenmeyer
    @bmuenzenmeyer
    i have been slowly incorporating this into fix/watched-pattern-changes
    @mbulfair awesome!
    Jonas Ulrich
    @julrich
    @mbulfair Definitely interested, we're still wrapping Pattern Lab with our own build process right now
    (including Gulp and Webpack)
    Matthew Bulfair
    @mbulfair
    I’m just testing out the SCSS and CSS updates for my internal version, I may release those addon’s as a file, I keep getting so many requests for it.
    those plugins/loaders don’t work with webpack 4 sadly
    But there’s better alternatives now
    Jonas Ulrich
    @julrich
    @bmuenzenmeyer A quick question I thought about yesterday: What would be the minimal way to realize a workshop / storefront example with the current alpha, where the only difference is in the states that are rendered (excludedPatternStates). Will I still have to create my own uikit-fork of workshop or your bare example? Or is there a quicker way?
    Brian Muenzenmeyer
    @bmuenzenmeyer
    the quickest way would be to fork uikit-workshop as-is
    since its completely functional
    change the name and config and you should be off to the races
    Jonas Ulrich
    @julrich
    Ah yea, btw. our own plugin broke with the upgrade to the current alpha. Something about fs path resolution for a folder called "plugin-", which doesn't work. Had no time to look at that, yet, either :/ Maybe some convetion(s) changed? Saw the comments about postinstall, but we've found a workaround for that
    Cool, sounds great! Will toy with that, too :)
    Thanks a lot for your (continuing) work, btw!
    Brian Muenzenmeyer
    @bmuenzenmeyer
    can you add a note about the plugins breaking to pattern-lab/patternlab-node#812 ?
    Jonas Ulrich
    @julrich
    Yep
    Brian Muenzenmeyer
    @bmuenzenmeyer
    i tabled some changes to plugins, but it sounds like they broke anyway. i think i know where
    and thanks
    Josh Schneider
    @Josh68

    and thanks for the additional info the other day regarding the assetWatcher

    I missed this. Guess maybe that comment was directed at me. Now that Matt's close to a Webpack v4 iteration, I will look again at the PL3 integration. I'll start by pulling in the branch with the modified server.js. But I'd like to take some time to look at Matt's changes, too.

    Jonas Ulrich
    @julrich
    Am I right in assuming that uikit-workshop is an evolution of styleguidekit-assets-default? We already have one of those customized for our needs. Anything to watch out for when just using that? Are there known differences?
    Looks mostly the same, but there are additional / new files like clipboard.min.js in uikit-workshop.
    Brian Muenzenmeyer
    @bmuenzenmeyer
    it was at one time a port of styleguidekit-assets-default, yes
    Jonas Ulrich
    @julrich
    Okay, will diff them, then :)
    Matthew Bulfair
    @mbulfair
    @bmuenzenmeyer @Josh68 I am going to be pushing in a branch on the webpack edition the webpack 4 upgrade. Would either you mind giving it a spin, make sure I didn't miss something? I'll let you know soon when I do the push
    Josh Schneider
    @Josh68
    @mbulfair @bmuenzenmeyer, I will definitely be checking this out when you push it, as my time permits.
    Brian Muenzenmeyer
    @bmuenzenmeyer
    i just opened this
    pattern-lab/patternlab-node#859
    Matthew Bulfair
    @mbulfair
    @Josh68 https://github.com/Comcast/patternlab-edition-node-webpack/tree/latest I have not spent time updated any of the documentation, so any new things I've added aren't there. Some highlights are I added a sample addon file for those wanting to do SCSS loader and extraction. It's a highly requested question. I added some new options in the pl-config to easily make changes. And you can now on demand in build/serve clear the public folder, no matter what is in the config.
    Josh Schneider
    @Josh68
    nice
    if I have anything I think is worthwhile adding to docs for thick-skulled folks like me, I'll suggest
    Matthew Bulfair
    @mbulfair
    The only issue I am seeing is on MAC, after you change a .mustache, the build is run, but it’s getting stuck..
    As if it’s not telling webpack it’s completed
    Josh Schneider
    @Josh68
    working on fixing some issues with package.json and the lock file. think you were working with yarn and forgot some updates for npm
    indeed
    will figure out what min versions to change (at least copy-webpack-plugin) and to a PR. Once I did everything fresh, ran without error
    Matthew Bulfair
    @mbulfair
    Seems now, on windows I 'm seeing the same thing, it just hangs. No errors. Need more testers
    Matthew Bulfair
    @mbulfair
    @Josh68 @bmuenzenmeyer I’ve pushed updates to https://github.com/Comcast/patternlab-edition-node-webpack/tree/latest it works now on MAC/PC, just make sure you clear node_modules to get the webpack 4 supported versions.
    Josh Schneider
    @Josh68
    I've verified on my local (which is actually linux, today)
    Matthew Bulfair
    @mbulfair
    My goal is to get as many people as possible to validate this before I release it, which I would like to do wednesday.
    Josh Schneider
    @Josh68
    issue was in package-lock.json
    GuillaumeASENT
    @GuillaumeASENT
    Hi. I want to know if there is a solution to async css files with paternlab. I used version 2.6.0. I've a file named getAssets.functions.php which send css element in header but i want to know if there is a solution to separate differents files (boostrap first, then all css used by molecules and organisms) without the website who charge a blank page during the time css was charged (I try to make script defer with call of css file in this case). Thanks in advance for the help.
    Mario Hernandez
    @mariohernandez
    I just started using the node version of Pattern Lab within a Drupal theme and when I try to use my drupal path to load pattern lab (i.e. drupal-local-domain/themes/custom/my_theme/patternalb), I get the following error message in my console: Uncaught (in promise) Error: Loading chunk 2 failed.
    (error: http://drupal-local-domainstyleguide/js/2-chunk-e309c72e0e8f5783df94.js)
    at HTMLScriptElement.onScriptComplete (patternlab-viewer.js:115).
    Pattern Lab loads properly on its own under localhost but need to be able to load it as part of my drupal site for server testing purposes. I'd appreciate your input or some guidance.
    Flywall
    @Flywall
    What's new with with the integration of Twig in Pattern Lab 3 (node) ?
    A Twig for Js version exist...
    Ringo De Smet
    @ringods
    @Flywall I recently updated @pattern-lab/engine-twig with the Twing library (https://nightlycommit.github.io/twing/). You can try it since version 5.8.0 of that package. There are still some issues with it, which I hope to fix soon.
    Ringo De Smet
    @ringods
    Unbound Web Design
    @JaiDoubleU
    Hi All,
    I've got a patternlab node implementation that uses a custom bootstrap theme that includes light and dark versions. Is there any way of leveraging the light/dark theme switcher in patternlab to toggle between a light and a dark stylesheets I've proven I can toggle between light and dark stylesheets using a value in my data.json, but I'd like to be able use the currently selected patternlab theme. Any thoughts or ideas on how I might do this would be greatly appreciated.