Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Aug 22 13:20
    aleksip edited #1037
  • Aug 22 13:19
    aleksip opened #1037
  • Aug 20 18:47
  • Aug 20 18:42
    zhawkins commented #1015
  • Aug 20 18:40
    zhawkins opened #1036
  • Aug 20 06:19
    sghoweri edited #1034
  • Aug 20 06:19
    sghoweri commented #1034
  • Aug 20 06:12
  • Aug 20 06:09
  • Aug 20 06:08
    bmuenzenmeyer commented #1034
  • Aug 20 06:07
    bmuenzenmeyer commented #1008
  • Aug 20 06:05

    bmuenzenmeyer on dev

    chore: regen uikit post-merge (compare)

  • Aug 20 06:02
    bmuenzenmeyer closed #1008
  • Aug 20 06:02

    bmuenzenmeyer on dev

    refactor: porting over virtuall… fix: add better pre-rendering s… refactor: disable pre-rendering… and 13 more (compare)

  • Aug 20 05:40
    bmuenzenmeyer synchronize #1008
  • Aug 20 05:40

    bmuenzenmeyer on uikit-refactor--batched-updates

    chore(uikit): regen chore(uikit): regen? (compare)

  • Aug 19 14:36
    zhawkins commented #1024
  • Aug 19 14:35
    stale[bot] unlabeled #1024
  • Aug 19 14:35
    zhawkins commented #1024
  • Aug 18 22:51
    stale[bot] unlabeled #1009
Salem Ghoweri
@sghoweri
Lemme collect my thoughts on these and get back to you guys tomorrow!
Salem Ghoweri
@sghoweri
^ first pass at some of my initial thoughts / recommendations
coreylafferty
@coreylafferty
@sghoweri thanks! sounds like you're proposing a major reworking of the approach... if that's the case, do you think it'd be worthwhile to try to address the identical file/folder name conflict (pattern-lab/patternlab-node#1018) and the dead 'view all' links (https://github.com/pattern-lab/patternlab-node/issues/890) in the short-term? assuming either of those is a relatively simple fix... which is a big assumption on my part. :)
Salem Ghoweri
@sghoweri

@coreylafferty right — what I’m proposing is the overarching milestone we want to work towards (for more stability, more customizations, extendability, plugins, etc) however that of course takes time to get to.

In the interim, any help to squash / patch up these couple of v3.0 bugs would be super helpful and appreciated, especially pattern-lab/patternlab-node#1018 and https://github.com/pattern-lab/patternlab-node/issues/890!

I already took an initial crack at troubleshooting and patching pattern-lab/patternlab-node#890 via pattern-lab/patternlab-node#977 but I’m unsure if this update is addressing the root cause, if there is a more ideal fix for this (other than a larger refactor), etc.

Salem Ghoweri
@sghoweri

@lwpinion totally understandable! And I can at least say that Pattern Lab PHP (especially with Twig) has still provided a ton of value on our end for the past 3 years (so imho it’s still a helpful tool if there’s some dealbreaker issues getting ironed out in PL Node)

Regarding pattern-lab/patternlab-node#1028, I just pinged Brian to get some confirmation about the specifics on that one (if it’s a temporary change, timing etc) since we’d also need at least an interim solution if some things are still getting reworked with organizing / hiding / structuring the PL navigation

Andrew Garman
@Nubville
Anyone familiar with an issue with the patternlab.json not writing with debugging turn on?
Christopher Bloom
@illepic
Hey all, longtime lurker (hi @sghoweri ). pl-node 3 beta tester :) Looking to remove all "view all" links (per pattern, per category, root "all"). Any way to do this in config?
Salem Ghoweri
@sghoweri
Lol - hey @illepic 👋!
Salem Ghoweri
@sghoweri
@illepic I'm taking a look at how viewAll is configured right now... To disable showing those viewAll links, all I think we're going to need to do is add a new prop to the new <pl-nav> web component (which is super quick to get wired up).
^ Getting a PR in with that update (or heck, even just sending you a patch to try out via https://www.npmjs.com/package/patch-package) is easy... the hard part is that almost all of the navigation refactor work is still pending review in pattern-lab/patternlab-node#1008 where we'd need to make the update 🙁🤔
J. Ryan Conklin
@jryanconklin
@sghoweri is there anything we can do to help with #1008
Christopher Bloom
@illepic
@sghoweri thanks!
Salem Ghoweri
@sghoweri
@illepic FYI, I just put in a new PR to add the ability to diable viewAll links in the new Pattern Lab UIKit navigation pattern-lab/patternlab-node#1034 🎉
Luke Pinion
@lwpinion
I've switched to using Pattern Lab 2 with Gulp and so far it's been working well for me as long as I don't nest my folders too deep (didn't realize I had been doing that).
That being said, I just tried to add some additional fonts and it seems that when I perform a build Pattern Lab pulls the folder structure to public, but the font files themselves don't actually get moved over. I looked on Github, but didn't find any open issues related to this. Anyone seen this problem before?
Also, I know @lasseitorp_twitter had said he needed some help with fonts in the General room. Maybe this is related?
J. Ryan Conklin
@jryanconklin
@sghoweri Howdy! In the php version of PL, we use the generated file /pl/styleguide/data/patternlab-data.json to run accessibility tests. In the Node version, I don't think this file gets made. Offhand are you aware of a config option to re-enable this file?
Salem Ghoweri
@sghoweri

Hey! 👋

I know we do something similar (also in the PHP version of PL) to generate our component status board...

Off the top of my head (without digging into the code), I think the data itself is still there in PL Node, however I think it’s now output as “patternlab-data.js”: https://github.com/bolt-design-system/bolt/blob/master/packages/uikit-workshop/src/html/index.html#L26

(although now that I think of it, we might have switched from using the .json version of that data to the .js version to make it easier to pull into our JS build tasks)

Can you check to see if that would work for ya?

If not, let us know! I can’t imagine it’d be difficult to output both data formats if need be (or add a config for that)

J. Ryan Conklin
@jryanconklin
I'll dig in, thanks!
Salem Ghoweri
@sghoweri
👍🏼
J. Ryan Conklin
@jryanconklin
@sghoweri How hard would it be to add a module.exports to the bottom of that file? :joy_cat:
Salem Ghoweri
@sghoweri

@jryanconklin you know it’s funny… I had to patch the EXACT same thing in Pattern Lab PHP! 😅

https://github.com/bolt-design-system/bolt/blob/master/docs-site/.patches/exported-data.patch

^ shouldn’t take more than a few minutes to get that PR’d! Quick win!
(PS. https://www.npmjs.com/package/patch-package can help get a quick temporary patch in added to everything installed via NPM if you need a quick solution before we get the next PL Node beta cut)
J. Ryan Conklin
@jryanconklin
@sghoweri Awesome, thanks!
J. Ryan Conklin
@jryanconklin
This is working locally for what I need. Basically just re-used what you had.
Salem Ghoweri
@sghoweri
Nice!!
@jryanconklin We'll want to double check that all the data PL Node has available is getting exported (so this’ll be done done if there’s other data that other folks might need to hook into) — I’ll try to get a review in later today!
Thanks for PRing that!
J. Ryan Conklin
@jryanconklin
@sghoweri Understood! Switching some gears at work but I'll be back on parts of this next week. I'll monitor the PR for feedback.
Michael Herchel
@mherchel
Hey everyone, I'm in need of some help. I'm running the latest Pattern Lab 3 release. I'm using Twig rendering engine with no starter kit.
The problem is that Pseudo patterns are not working.
In my proof of concept that i'm working on, when i output <p>{{ localdata }}</p> and have "localdata": "Hi!" within my 00-test.json, it works perfectly
but when i create a 00-test~hey.json file and change the data to "localdata": "Hey!", Pattern Lab will display the actual JSON
I created a short video of the issue at https://youtu.be/0uIuOvnn48c
J. Ryan Conklin
@jryanconklin
@mherchel You might want to check the issue queue in GitHub. I think this is a known issue, but couldn't find it offhand.
Michael Herchel
@mherchel
yeah, i did a search, but also couldn't find it. I went to open up a new issue, but the issue template asked me to check here first :D
I'll do another search for good measure.
Still nothing. The closest I can find is pattern-lab/patternlab-node#975, but that's definitely a different (and resolved) issue.
coreylafferty
@coreylafferty
@mherchel yeah, pseudo patterns don't currently work. There's a PR about it, but I don't think it's ready yet: pattern-lab/patternlab-node#1017
Michael Herchel
@mherchel
Thanks for the info :)
Erik Peterson
@erik-peterson-fox

Hello there. I'm looking to get started with something like pattern lab and I have two main barriers to using this:

  1. Markup/HTML is shown when looking at details but there's no way to view the style out of the box. I read an article claiming it's easy to extend to do that but based on the docs and the code, I don't see a clear way to do this.
  2. Scss files I put in the patterns folder aren't being used in the output. The docs don't seem to address this. I see a starter works with scss but it makes no sense to me why it's working. When I try having a style.scss in the css directory, it is not used.

Any help would be much appreciated! My teammates want me to shy away from this product in favor of a less-structured alternative but I think I almost have it working...

Erik Peterson
@erik-peterson-fox

Update: I solved #2 when I stumbled on this https://github.com/pattern-lab/live-server#usage-from-node.

I assume i need to build the scss myself (with more npm scripts) and output it to public/css/style.css ? - That's working.

And now I see why scss was ignored by default - my script handles it, not yours
Luke Pinion
@lwpinion
@erik-peterson-fox Right. You have to use your compiler to generate the CSS from your Sass. In Visual Studio, for instance, I have my compiler set to output to /source/css/style.css and then when you build Pattern Lab it grabs all the files in source and puts them where they should go in public (over-simplified terms there, but my head's not working this morning).
As for your first question, I'm not sure how to go about doing that. I'm not sure I completely understand why it would be necessary. If your source code and Pattern Lab utilize the same styles, then all you should have to do is insert the markup into your project's templates/HTML files and the items in question should be styled appropriately. Unless there's something I'm missing?
At any rate, I definitely understand where you're coming from as far as wanting to do something like this but not having the backing of your teammates. Fortunately, I've made some headway in that area.