Where communities thrive

Join over 1.5M+ people
Join over 100K+ communities
Free without limits
Create your own community

Explore more communities

pattern-lab/spec

get the discussion started on changes to spec

People

Repo info

Activity

Mar 10 2018 21:59

bmuenzenmeyer commented #38
Jan 28 2018 04:03

bmuenzenmeyer commented #38
Jan 27 2018 22:53

bradfrost opened #38
Jan 26 2018 09:34

aleksip commented #37
Jan 26 2018 09:22

aleksip commented #37
Jan 25 2018 15:34

EvanLovely commented #37
Jan 25 2018 10:05

aleksip commented #37
Jan 25 2018 07:29

EvanLovely commented #37
Jan 25 2018 07:08

EvanLovely commented #37
Jan 22 2018 18:09

bmuenzenmeyer commented #37
Jan 22 2018 17:48

aleksip commented #37
Jan 22 2018 13:31

bmuenzenmeyer unlabeled #37
Jan 22 2018 13:31

bmuenzenmeyer labeled #37
Jan 22 2018 13:31

bmuenzenmeyer closed #37
Jan 22 2018 13:31

bmuenzenmeyer commented #37
Jan 19 2018 10:59

aleksip commented #37
Jan 18 2018 20:52

bradfrost commented #37
Jan 18 2018 16:58

geoffp commented #37
Jan 18 2018 13:52

bmuenzenmeyer commented #37
Jan 18 2018 11:31

sghoweri commented #37

Brian Muenzenmeyer

@bmuenzenmeyer

took a stab at some sensible labels: https://github.com/pattern-lab/the-spec/labels

if they look good i'll add my first batch of issues

Dave Olsen

@dmolsen

have at it. thanks.

and i’ll add that vote passed to the two votes so far

Brian Muenzenmeyer

@bmuenzenmeyer

thanks

Dave Olsen

@dmolsen

done

danke

Brian Muenzenmeyer

@bmuenzenmeyer

@dmolsen media query inspection into the ishControls is still supported, yes?

Dave Olsen

@dmolsen

@bmuenzenmeyer : @bradfrost took it out of the UI. so PL/PHP core is collecting and passing that data to the front-end but it doesn’t get displayed

Brian Muenzenmeyer

@bmuenzenmeyer

ahh, ok

by design then. are their plans to resurrect it, make it a plugin, or otherwise strip it out completely? I INVOKETH THE SPEC

Dave Olsen

@dmolsen

i guess from a spec perspective it’s gone. i’ll probably implement as a plugin but core implementations don’t have to match plugins

Brian Muenzenmeyer

@bmuenzenmeyer

thanks

Dave Olsen

@dmolsen

activity here will show the activity on the-spec repo

Brian Muenzenmeyer

@bmuenzenmeyer

cool

did you add issues / comments / or just code? strange its only showing my issue template push for me

Dave Olsen

@dmolsen

i don’t think it grabs historical changes. it should populate as we make comments and what not

i literally just added it

Brian Muenzenmeyer

@bmuenzenmeyer

I opened a process question (pattern-lab/the-spec#18) to answer how to handle resolved votes like pattern-lab/the-spec#15

Brian Muenzenmeyer

@bmuenzenmeyer

does pattern-lab/the-spec#15 only close once we all implement, or after vote passes?

Dave Olsen

@dmolsen

i’d close after vote passes just to keep things clean

Brian Muenzenmeyer

@bmuenzenmeyer

done

Dave Olsen

@dmolsen

thanks

Brian Muenzenmeyer

@bmuenzenmeyer

ironic to me that the spec enhancement we sorta joked about at first is the first to make it through the gauntlet :D

having trouble finding time today to respond to all in earnest

Dave Olsen

@dmolsen

take your time on spec. i think it took me the vast majority of the day yesterday. we have time to make decisions.

Brian Muenzenmeyer

@bmuenzenmeyer

cross post to here: pattern-lab/patternlab-node#408

Brian Muenzenmeyer

@bmuenzenmeyer

@dmolsen - should an engine's name refer to the filetype of the template or the thing that parses them? for example. patternengine-platform-mustache, even though hogan is used to parse them?

Greg Davis

@antelopeb

I'm working on an experimental JSX engine to render react.js style components. Are there any guidelines on the engines? Or has this already been built and I've just missed it? I'm initially just building it based on the Mustache engine's structure.

Geoff Pursell

@geoffp

@antelopeb Are you building in PL/PHP or PL/Node?

Brian Muenzenmeyer

@bmuenzenmeyer

if its Node - we unfortunately have no documentation yet (pattern-lab/patternlab-node#392 to cover consumption and maybe creation) but there are tons of examples to riff off of https://github.com/pattern-lab/?utf8=%E2%9C%93&query=patternengine-node-

Greg Davis

@antelopeb

awesome, that's perfect.

Geoff Pursell

@geoffp

And -- we would be very interested in React component support. We had a similar effort going a long time ago, but it stalled and died on the vine for lack of time to dedicate.

Greg Davis

@antelopeb

cool, well I'll see what I can get working then :)

thanks guys

Geoff Pursell

@geoffp

Good luck, and keep us posted!

Greg Davis

@antelopeb

will do

Brian Muenzenmeyer

@bmuenzenmeyer

if you get something going i'd be honored to include it in as an official repo. that's basically how all of the non-mustache engines were created. with @geoffp being the bossman behind most of them

even partial support is acceptable, like the Twig engine which is probably rough around the edges versus some of the others

Greg Davis

@antelopeb

Okay, got it.

Geoff Pursell

@geoffp

hey, @antelopeb -- any progess on the React engine? I'd love to see what you've got so far and maybe help out if I can.

Geoff Pursell

@geoffp

This message was deleted