These are chat archives for pavelk2/social-feed

19th
Nov 2015
Guillaume K.
@Webarkitekt
Nov 19 2015 13:11
Hello there ;)
Pavel Kucherbaev
@pavelk2
Nov 19 2015 13:13
Hi @Webarkitekt !
Yordi Pauptit
@yp28
Nov 19 2015 13:13
Hey both
Guillaume K.
@Webarkitekt
Nov 19 2015 13:13
Hello @YP28
@YP28 you will have to load every posts before displaying them on the page
Yordi Pauptit
@yp28
Nov 19 2015 13:14
So basically, I'd like to see this plugin improve. The company I work for needed a social media plugin for one of the new campaigns, and we couldn't really find one that fit our needs. Pavel, your plugin came closest, but there are still some things that can be improved I think.
One of which, is indeed ordering before rending the HTML. Which I thought it did, until I came to know it orders by the dt-create attribute.
@Webarkitekt, all posts have to be loaded anyway. I don't expect to see any performance issues, if that's what you mean.
The way it's implemented now, you have to alter the DOM twice. While adding the items to the DOM, and while rearranging them.
I don't have any benchmarks to back this up, but I'm guessing this is inefficient compared to ordering them before altering the DOM.
Guillaume K.
@Webarkitekt
Nov 19 2015 13:20
I don't like the idea to show all the post after every feeds are loaded
I prefer the lazy load effect that is actually in place
but you could eventually add this as an option.
Yordi Pauptit
@yp28
Nov 19 2015 13:28
Explain "show all the post after every feeds are loaded"?
Aah, wait, I think I get it.
Because lazy loading is implemented it shows the response as soon as it receives it from the API's.
Guillaume K.
@Webarkitekt
Nov 19 2015 13:29
yes
Yordi Pauptit
@yp28
Nov 19 2015 13:30
Hmm, good point.
Guillaume K.
@Webarkitekt
Nov 19 2015 13:30
UX thing, users doesn't like to wait ;)
Yordi Pauptit
@yp28
Nov 19 2015 13:30
The least we can do it document that the sort depends on the dt-create attribute.
Guillaume K.
@Webarkitekt
Nov 19 2015 13:36
yes that's would be nice
Do it ;)
Yordi Pauptit
@yp28
Nov 19 2015 13:37
PR opened.
Guillaume K.
@Webarkitekt
Nov 19 2015 14:08
@pavelk2 would be cool to add a github integration in gitter when you get a chance ;)
Yordi Pauptit
@yp28
Nov 19 2015 14:17
Another option that would be nice is to exclude retweets. We chose to only show social media posts that include media, and it's a bitch seeing all that duplicate content.
Guillaume K.
@Webarkitekt
Nov 19 2015 14:20
yes that's could be a nice enhancement
I worked on linkedin support
but need some PHP for the auth so i don't think i will share it
plus it only works with the old api, the new need a user login .. to get ... public posts ... :/
Yordi Pauptit
@yp28
Nov 19 2015 14:23
Let me take a quick look
Yup, that sucks.
Pavel Kucherbaev
@pavelk2
Nov 19 2015 14:29
@Webarkitekt added the integrations
@Webarkitekt for the linkedIn - give a look to social-feed-server. You can implement authorization using nodejs.
Guillaume K.
@Webarkitekt
Nov 19 2015 14:32
yes will do this when i get some more free time ;)
Pavel Kucherbaev
@pavelk2
Nov 19 2015 14:33
thumbs up
Guillaume K.
@Webarkitekt
Nov 19 2015 20:35
When an api return an error the plugin is breaking :/