These are chat archives for pavelk2/social-feed

8th
Oct 2016
Pavel Kucherbaev
@pavelk2
Oct 08 2016 21:25

I checked out the errors on CodeClimate - they were a lot. Some errors I have fixed (now are in the branch 'codeclimate'). Now there are 2 issues left:https://codeclimate.com/github/pavelk2/social-feed/js/jquery.socialfeed.js?from_sha=a7858f8a&to_sha=c48af74a#complexity
1) too big complexity of the whole file (what if we put the code for each social network into a separate file - in such a way overall plugin file will be cleaner and a user will need to include files of social networks s/he needs only)
2) unknown external dependencies (when the page is loaded not all dependencies are loaded immediately)

Do you have ideas how to solve these issues?

Pavel Kucherbaev
@pavelk2
Oct 08 2016 21:32
@HartLarsson @martijngastkemper